[JBoss JIRA] (WFLY-8085) ExpressionSupportSmokeTestCase doesn't properly handle attributes with undefined required attributes
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-8085?page=com.atlassian.jira.plugin.... ]
Brian Stansberry resolved WFLY-8085.
------------------------------------
Resolution: Won't Fix
> ExpressionSupportSmokeTestCase doesn't properly handle attributes with undefined required attributes
> ----------------------------------------------------------------------------------------------------
>
> Key: WFLY-8085
> URL: https://issues.jboss.org/browse/WFLY-8085
> Project: WildFly
> Issue Type: Bug
> Components: Domain Management, Test Suite
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> ExpressionSupportSmokeTestCase is attempting to set attributes even when other required attributes are undefined. In organizeAttributes it checks if the required attribute is undefined due to the presence of a defined alternative, but if that's not the reason it tries to set the base attribute. That will fail if the required attribute is undefined simply because the base config doesn't define it.
> https://github.com/wildfly/wildfly/pull/9628 includes a workaround for this, but it's not ideal. We should look into how setExpressions works and change it from executing a bunch of individual write-attribute ops per resource to executing them all as steps in a single composite. That would remove any reason for leaving these attributes undefined. Both the base attribute and the required attribute would be set in the same composite.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-972) Provide a way to correlate HTTP management requests
by Harald Pehl (JIRA)
[ https://issues.jboss.org/browse/WFCORE-972?page=com.atlassian.jira.plugin... ]
Harald Pehl commented on WFCORE-972:
------------------------------------
We have a working solution right now and as soon as this is in core we'd need a bit of refactoring on the client side anyway. So from a HAL POV it's ok if this gets merged for Core 4.
> Provide a way to correlate HTTP management requests
> ---------------------------------------------------
>
> Key: WFCORE-972
> URL: https://issues.jboss.org/browse/WFCORE-972
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Heiko Braun
> Assignee: Brian Stansberry
> Fix For: 3.0.0.Beta1
>
>
> {noformat}
> public class CorrelationHandler implements HttpHandler {
> private static final HttpString HEADER = new HttpString("X-CORR-ID");
> private final HttpHandler next;
> public CorrelationHandler(HttpHandler next) {
> this.next = next;
> }
> @Override
> public void handleRequest(HttpServerExchange exchange) throws Exception {
> String corr = exchange.getRequestHeaders().getFirst(HEADER);
> if(corr != null) {
> exchange.getResponseHeaders().put(HEADER, corr);
> }
> next.handleRequest(exchange);
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-8085) ExpressionSupportSmokeTestCase doesn't properly handle attributes with undefined required attributes
by Brian Stansberry (JIRA)
Brian Stansberry created WFLY-8085:
--------------------------------------
Summary: ExpressionSupportSmokeTestCase doesn't properly handle attributes with undefined required attributes
Key: WFLY-8085
URL: https://issues.jboss.org/browse/WFLY-8085
Project: WildFly
Issue Type: Bug
Components: Domain Management, Test Suite
Reporter: Brian Stansberry
Assignee: Brian Stansberry
ExpressionSupportSmokeTestCase is attempting to set attributes even when other required attributes are undefined. In organizeAttributes it checks if the required attribute is undefined due to the presence of a defined alternative, but if that's not the reason it tries to set the base attribute. That will fail if the required attribute is undefined simply because the base config doesn't define it.
https://github.com/wildfly/wildfly/pull/9628 includes a workaround for this, but it's not ideal. We should look into how setExpressions works and change it from executing a bunch of individual write-attribute ops per resource to executing them all as steps in a single composite. That would remove any reason for leaving these attributes undefined. Both the base attribute and the required attribute would be set in the same composite.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-8083) WebMigrateOperation makes invalid assumption about web subsystem "describe" output ordering
by Brian Stansberry (JIRA)
Brian Stansberry created WFLY-8083:
--------------------------------------
Summary: WebMigrateOperation makes invalid assumption about web subsystem "describe" output ordering
Key: WFLY-8083
URL: https://issues.jboss.org/browse/WFLY-8083
Project: WildFly
Issue Type: Bug
Components: Web (Undertow)
Affects Versions: 10.1.0.Final
Reporter: Brian Stansberry
Assignee: Brian Stansberry
The WebMigrateOperation iterates over the operations produced by running 'describe' against the web subsystem, checking different operations and converting them. When it gets to a /subsystem=web/host=* op it processes that in its migrateVirtualHost method. But that method as part of its work checks all the other *already migrated* ops looking for path filters and the access log valve. If found it adds additional child resource add ops.
This is flawed because it assumes any add op for an access log valve or path filter will have already been created when migrateVirtualHost is run. That's not a valid assumption as there is nothing in the contract of the describe operation that guarantees such an order in its output. Work on WFCORE-2286 has revealed this.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (DROOLS-1432) Improve error messages when compiling models with errors
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1432?page=com.atlassian.jira.plugi... ]
Edson Tirelli updated DROOLS-1432:
----------------------------------
Summary: Improve error messages when compiling models with errors (was: Improve error messages when compiling modes with errors)
> Improve error messages when compiling models with errors
> --------------------------------------------------------
>
> Key: DROOLS-1432
> URL: https://issues.jboss.org/browse/DROOLS-1432
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.0.0.Beta6
> Reporter: Edson Tirelli
> Assignee: Edson Tirelli
> Fix For: 7.0.0.Final
>
> Attachments: car_damage_responsibility2.dmn
>
>
> When a model contains errors that prevent compilation, the engine should provide a better error message pointing to the specific error.
> At the moment, the attached model fails with a NPE and a message:
> {quote}Message [id=1, kieBase=defaultKieBase, level=ERROR, path=car_damage_responsibility2.dmn, line=-1, column=0 text=Unable to compile DMN model for the resource]{quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months