[JBoss JIRA] (WFCORE-2317) Nested attributes are not validated
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2317?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-2317:
----------------------------------------
Fix Version/s: 3.0.0.Beta5
Assignee: (was: Brian Stansberry)
I'm scheduling this but unassigning it. It would be nice to fix in 3.0.0 but not critical. I'm scheduling it so it stays on the radar screen.
> Nested attributes are not validated
> -----------------------------------
>
> Key: WFCORE-2317
> URL: https://issues.jboss.org/browse/WFCORE-2317
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha25
> Reporter: Michal Petrov
> Fix For: 3.0.0.Beta5
>
>
> Attributes of type Object do not have their inner attributes validated for e.g. "requires" and "alternatives".
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-2317) Nested attributes are not validated
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2317?page=com.atlassian.jira.plugi... ]
Brian Stansberry edited comment on WFCORE-2317 at 2/22/17 3:31 PM:
-------------------------------------------------------------------
ValidateModelStepHandler can deal with this while looping through the attributes by checking whether the AttributeDefinition is of type ObjectTypeAttributeDefinition, ObjectListAttributeDefinition or ObjectMapAttributeDefinition. For the latter two use the getValueType() method (needs to be public) to get the underlying ObjectTypeAttributeDefinition. Get to the "object type" ModelNode (either the attribute value itself, or elements in its list in the ObjectListAttributeDefinition case, or values in its map in the ObjectMapAttributeDefinition case) and perform the requires/alternatives validation on it using the ObjectTypeAttributeDefinition. The requires validation can be easier than is done with the root attribute, as there is no need for the "attemptReadMissingAttributeValueFromHandler" stuff, since the entire attribute value has already been read.
The logic should recurse, to handle cases where complex attributes have other complex types as fields.
Failure messages will be a bit more complex as the message should use the . and [0] formatted path to the offending field, rather than simply using the attribute name.
Not
WFCORExxx: attributename is invalid in combination with [b, c]
But rather
WFCORExxx: attributename[].a is invalid in combination with [b, c]
I believe the existing ControllerLogger methods to create the exceptions would still be usable; the only difference is the parameter values passed in.
was (Author: brian.stansberry):
ValidateModelStepHandler can deal with this while looping through the attributes by checking whether the AttributeDefinition is of type ObjectTypeAttributeDefinition, ObjectListAttributeDefinition or ObjectMapAttributeDefinition. For the latter two use the getValueType() method (needs to be public) to get the underlying ObjectTypeAttributeDefinition. Get to the "object type" ModelNode (either the attribute value itself, or elements in its list in the ObjectListAttributeDefinition case, or values in its map in the ObjectMapAttributeDefinition case) and perform the requires/alternatives validation on it using the ObjectTypeAttributeDefinition. The requires validation can be easier than is done with the root attribute, as there is no need for the "attemptReadMissingAttributeValueFromHandler" stuff, since the entire attribute value has already been read.
The logic should recurse, to handle cases where complex attributes have other complex types as fields.
Failure messages will be a bit more complex as the message should use the . and [0] formatted path to the offending field, rather than simply using the attribute name.
Not
WFCORExxx: attributename is invalid in combination with [b, c]
But rather
WFCORExxx: attributename[].a is invalid in combination with [b, c]
> Nested attributes are not validated
> -----------------------------------
>
> Key: WFCORE-2317
> URL: https://issues.jboss.org/browse/WFCORE-2317
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha25
> Reporter: Michal Petrov
> Assignee: Brian Stansberry
>
> Attributes of type Object do not have their inner attributes validated for e.g. "requires" and "alternatives".
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-2317) Nested attributes are not validated
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2317?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-2317:
------------------------------------------
ValidateModelStepHandler can deal with this while looping through the attributes by checking whether the AttributeDefinition is of type ObjectTypeAttributeDefinition, ObjectListAttributeDefinition or ObjectMapAttributeDefinition. For the latter two use the getValueType() method (needs to be public) to get the underlying ObjectTypeAttributeDefinition. Get to the "object type" ModelNode (either the attribute value itself, or elements in its list in the ObjectListAttributeDefinition case, or values in its map in the ObjectMapAttributeDefinition case) and perform the requires/alternatives validation on it using the ObjectTypeAttributeDefinition. The requires validation can be easier than is done with the root attribute, as there is no need for the "attemptReadMissingAttributeValueFromHandler" stuff, since the entire attribute value has already been read.
The logic should recurse, to handle cases where complex attributes have other complex types as fields.
Failure messages will be a bit more complex as the message should use the . and [0] formatted path to the offending field, rather than simply using the attribute name.
Not
WFCORExxx: attributename is invalid in combination with [b, c]
But rather
WFCORExxx: attributename[].a is invalid in combination with [b, c]
> Nested attributes are not validated
> -----------------------------------
>
> Key: WFCORE-2317
> URL: https://issues.jboss.org/browse/WFCORE-2317
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha25
> Reporter: Michal Petrov
> Assignee: Brian Stansberry
>
> Attributes of type Object do not have their inner attributes validated for e.g. "requires" and "alternatives".
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (DROOLS-1448) [XLS Decision Table] Integer values for Double attributes causes validation error
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1448?page=com.atlassian.jira.plugi... ]
Michael Anstis reassigned DROOLS-1448:
--------------------------------------
Assignee: Mario Fusco (was: Michael Anstis)
> [XLS Decision Table] Integer values for Double attributes causes validation error
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-1448
> URL: https://issues.jboss.org/browse/DROOLS-1448
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.0.0.Beta6
> Reporter: Jozef Marko
> Assignee: Mario Fusco
> Priority: Minor
> Labels: dtable_testday_preparation, qe-test-day, reported-by-qe
> Attachments: Driver.java, ExamplePolicyPricing.xls, Policy.java, Screenshot from 2017-02-02 10-22-21.png
>
>
> If the XLS decision contains Integer values for column ( attribute ) that is Double data type, then the XLS decision table is not validated successfully. After conversion to guided decision table is the table validated successfully.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (DROOLS-1448) [XLS Decision Table] Integer values for Double attributes causes validation error
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1448?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-1448:
----------------------------------------
The problem has nothing to do with the Workbench; compilation of the attached XLS file fails due to use of an {{int}} literal on a {{double}} field.
"Rule Compilation error The method setBasePrice(Double) in the type Policy is not applicable for the arguments (int)"
> [XLS Decision Table] Integer values for Double attributes causes validation error
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-1448
> URL: https://issues.jboss.org/browse/DROOLS-1448
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.0.0.Beta6
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: dtable_testday_preparation, qe-test-day, reported-by-qe
> Attachments: Driver.java, ExamplePolicyPricing.xls, Policy.java, Screenshot from 2017-02-02 10-22-21.png
>
>
> If the XLS decision contains Integer values for column ( attribute ) that is Double data type, then the XLS decision table is not validated successfully. After conversion to guided decision table is the table validated successfully.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (DROOLS-1448) [XLS Decision Table] Integer values for Double attributes causes validation error
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1448?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-2875 to DROOLS-1448:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-1448 (was: GUVNOR-2875)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Affects Version/s: 7.0.0.Beta6
(was: drools_7.0.0.Beta6)
> [XLS Decision Table] Integer values for Double attributes causes validation error
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-1448
> URL: https://issues.jboss.org/browse/DROOLS-1448
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.0.0.Beta6
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: dtable_testday_preparation, qe-test-day, reported-by-qe
> Attachments: Driver.java, ExamplePolicyPricing.xls, Policy.java, Screenshot from 2017-02-02 10-22-21.png
>
>
> If the XLS decision contains Integer values for column ( attribute ) that is Double data type, then the XLS decision table is not validated successfully. After conversion to guided decision table is the table validated successfully.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (AG-11) Create a simple web page
by Luis Barreiro (JIRA)
Luis Barreiro created AG-11:
-------------------------------
Summary: Create a simple web page
Key: AG-11
URL: https://issues.jboss.org/browse/AG-11
Project: Agroal
Issue Type: Task
Components: web
Affects Versions: 0.1
Reporter: Luis Barreiro
Assignee: Luis Barreiro
Fix For: 0.2
Using GitHub pages
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-7778) Remoting identity propagation does not work with Elytron
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7778?page=com.atlassian.jira.plugin.... ]
Jan Kalina updated WFLY-7778:
-----------------------------
Steps to Reproduce:
Tests: (after modification to use Elytron instead of legacy subystem: https://github.com/wildfly-security-incubator/wildfly/pull/56 )
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_BadPwd()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_TwoBeans()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth_BadPwd()
(and a lot of other, most of tests using EJB)
UPDATE:
https://github.com/wildfly-security-incubator/wildfly/pull/102 instead and following with -Delytron option:
org.jboss.as.test.integration.ejb.security.AuthenticationElytronTestCase.testAuthentication()
was:
Tests: (after modification to use Elytron instead of legacy subystem: https://github.com/wildfly-security-incubator/wildfly/pull/56 )
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_BadPwd()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_TwoBeans()
org.jboss.as.test.integration.ejb.security.AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth_BadPwd()
(and a lot of other, most of tests using EJB)
> Remoting identity propagation does not work with Elytron
> --------------------------------------------------------
>
> Key: WFLY-7778
> URL: https://issues.jboss.org/browse/WFLY-7778
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Critical
> Labels: elytron-legacy-test-fails
>
> Even througth succesful obtaining LoginContext, identity is not propagated in EJB call.
> Identity is unauthorized on server side.
> *Remoting does not work because it is not implemented yet* - this issue created primary for tests ignore issue reference.
> Often error message:
> {code:java}
> SaslException: Authentication failed: all available authentication mechanisms failed:
> JBOSS-LOCAL-USER: Server rejected authentication
> DIGEST-MD5: Server rejected authentication]
> at org.wildfly.naming.client.remote.RemoteNamingProvider.getPeerIdentityForNaming(RemoteNamingProvider.java:110)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months