February 2017 - jboss-jira - Jboss List Archives

[JBoss JIRA] (WFCORE-2217) ValidationStepHandler does not get triggered on boot in subsystem-/core-model tests

by Kabir Khan (JIRA)

[ https://issues.jboss.org/browse/WFCORE-2217?page=com.atlassian.jira.plugi... ] Kabir Khan updated WFCORE-2217: ------------------------------- Fix Version/s: 3.0.0.Beta3 (was: 3.0.0.Beta2) > ValidationStepHandler does not get triggered on boot in subsystem-/core-model tests > ----------------------------------------------------------------------------------- > > Key: WFCORE-2217 > URL: https://issues.jboss.org/browse/WFCORE-2217 > Project: WildFly Core > Issue Type: Component Upgrade > Components: Domain Management > Affects Versions: 3.0.0.Alpha16 > Reporter: Kabir Khan > Assignee: Brian Stansberry > Fix For: 3.0.0.Beta3, 4.0.0.Beta1 > > > During a normal server boot ValidationStepHandler gets called. But during a core-model-/subsystem tests it does not get called on boot. The issue is that in these tests bootOperations.postExtensionOps are null, so the if block at https://github.com/wildfly/wildfly-core/blob/3.0.0.Alpha19/controller/src... which contains the validation logic at https://github.com/wildfly/wildfly-core/blob/3.0.0.Alpha19/controller/src... does not get called. > The fix is quite simple: > {code} > diff --git a/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java b/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > index 4a6cc7c..d8e1911 100644 > --- a/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > +++ b/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > @@ -517,21 +517,21 @@ class ModelControllerImpl implements ModelController { > } > > resultAction = postExtContext.executeOperation(); > + } > > - if (!skipModelValidation && resultAction == OperationContext.ResultAction.KEEP && bootOperations.postExtensionOps != null) { > - //Get the modified resources from the initial operations and add to the resources to be validated by the post operations > - Set<PathAddress> validateAddresses = new HashSet<PathAddress>(); > - Resource root = managementModel.get().getRootResource(); > - addAllAddresses(managementModel.get().getRootResourceRegistration(), PathAddress.EMPTY_ADDRESS, root, validateAddresses); > - > - final AbstractOperationContext validateContext = new OperationContextImpl(operationID, POST_EXTENSION_BOOT_OPERATION, > - EMPTY_ADDRESS, this, processType, runningModeControl.getRunningMode(), > - contextFlags, handler, null, managementModel.get(), control, processState, auditLogger, > - bootingFlag.get(), hostServerGroupTracker, null, null, notificationSupport, false, > - extraValidationStepHandler, partialModel, securityIdentitySupplier); > - validateContext.addModifiedResourcesForModelValidation(validateAddresses); > - resultAction = validateContext.executeOperation(); > - } > + if (!skipModelValidation && resultAction == OperationContext.ResultAction.KEEP) { > + //Get the modified resources from the initial operations and add to the resources to be validated by the post operations > + Set<PathAddress> validateAddresses = new HashSet<PathAddress>(); > + Resource root = managementModel.get().getRootResource(); > + addAllAddresses(managementModel.get().getRootResourceRegistration(), PathAddress.EMPTY_ADDRESS, root, validateAddresses); > + > + final AbstractOperationContext validateContext = new OperationContextImpl(operationID, POST_EXTENSION_BOOT_OPERATION, > + EMPTY_ADDRESS, this, processType, runningModeControl.getRunningMode(), > + contextFlags, handler, null, managementModel.get(), control, processState, auditLogger, > + bootingFlag.get(), hostServerGroupTracker, null, null, notificationSupport, false, > + extraValidationStepHandler, partialModel, securityIdentitySupplier); > + validateContext.addModifiedResourcesForModelValidation(validateAddresses); > + resultAction = validateContext.executeOperation(); > } > > return resultAction == OperationContext.ResultAction.KEEP; > {code} > but changing this and trying to run the widlfly-core tests causes failures in the remoting subsystem and loads in the core-model-tests. There are bound to be more in the subsystems in full. > I'd hazard a guess and say that the subsystem tests are aiming for good coverage, and so might be setting stuff which would fail validation e.g. of Alternatives. > For core model tests it is complaining about things like missing management-xxx-versions in the model, default interfaces in socket binding groups and a lot of things like that. In a lot of cases the xml used in the tests uses minimum information to set up things for what is needed. WIP for the core model tests is: > {code} > diff --git a/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java b/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > index 4a6cc7c..d8e1911 100644 > --- a/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > +++ b/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java > @@ -517,21 +517,21 @@ class ModelControllerImpl implements ModelController { > } > > resultAction = postExtContext.executeOperation(); > + } > > - if (!skipModelValidation && resultAction == OperationContext.ResultAction.KEEP && bootOperations.postExtensionOps != null) { > - //Get the modified resources from the initial operations and add to the resources to be validated by the post operations > - Set<PathAddress> validateAddresses = new HashSet<PathAddress>(); > - Resource root = managementModel.get().getRootResource(); > - addAllAddresses(managementModel.get().getRootResourceRegistration(), PathAddress.EMPTY_ADDRESS, root, validateAddresses); > - > - final AbstractOperationContext validateContext = new OperationContextImpl(operationID, POST_EXTENSION_BOOT_OPERATION, > - EMPTY_ADDRESS, this, processType, runningModeControl.getRunningMode(), > - contextFlags, handler, null, managementModel.get(), control, processState, auditLogger, > - bootingFlag.get(), hostServerGroupTracker, null, null, notificationSupport, false, > - extraValidationStepHandler, partialModel, securityIdentitySupplier); > - validateContext.addModifiedResourcesForModelValidation(validateAddresses); > - resultAction = validateContext.executeOperation(); > - } > + if (!skipModelValidation && resultAction == OperationContext.ResultAction.KEEP) { > + //Get the modified resources from the initial operations and add to the resources to be validated by the post operations > + Set<PathAddress> validateAddresses = new HashSet<PathAddress>(); > + Resource root = managementModel.get().getRootResource(); > + addAllAddresses(managementModel.get().getRootResourceRegistration(), PathAddress.EMPTY_ADDRESS, root, validateAddresses); > + > + final AbstractOperationContext validateContext = new OperationContextImpl(operationID, POST_EXTENSION_BOOT_OPERATION, > + EMPTY_ADDRESS, this, processType, runningModeControl.getRunningMode(), > + contextFlags, handler, null, managementModel.get(), control, processState, auditLogger, > + bootingFlag.get(), hostServerGroupTracker, null, null, notificationSupport, false, > + extraValidationStepHandler, partialModel, securityIdentitySupplier); > + validateContext.addModifiedResourcesForModelValidation(validateAddresses); > + resultAction = validateContext.executeOperation(); > } > > return resultAction == OperationContext.ResultAction.KEEP; > {code} > So although the fix is simple, the fallout of this is quite big. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-2267) Delete all legacy code from CallbackHandlerService and SubjectSupplemental implementations

by Kabir Khan (JIRA)

[ https://issues.jboss.org/browse/WFCORE-2267?page=com.atlassian.jira.plugi... ] Kabir Khan updated WFCORE-2267: ------------------------------- Fix Version/s: 3.0.0.Beta3 (was: 3.0.0.Beta2) > Delete all legacy code from CallbackHandlerService and SubjectSupplemental implementations > ------------------------------------------------------------------------------------------ > > Key: WFCORE-2267 > URL: https://issues.jboss.org/browse/WFCORE-2267 > Project: WildFly Core > Issue Type: Task > Components: Domain Management, Security > Reporter: Darran Lofthouse > Assignee: Darran Lofthouse > Fix For: 3.0.0.Beta3 > > > Only the Elytron realms are now used. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8129) Upgrade to Narayana 5.5.2.Final (from 5.5.1.Final-redhat-1)

by Kabir Khan (JIRA)

[ https://issues.jboss.org/browse/WFLY-8129?page=com.atlassian.jira.plugin.... ] Kabir Khan deleted WFLY-8129: ----------------------------- > Upgrade to Narayana 5.5.2.Final (from 5.5.1.Final-redhat-1) > ----------------------------------------------------------- > > Key: WFLY-8129 > URL: https://issues.jboss.org/browse/WFLY-8129 > Project: WildFly > Issue Type: Component Upgrade > Reporter: Kabir Khan > Assignee: Tom Jenkinson > > https://issues.jboss.org/browse/JBTM-2848 was found during testing with the new EJB client and is included in this fix -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8127) Upgrade Narayana to 5.5.2.Final

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/WFLY-8127?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated WFLY-8127: -------------------------------- Description: Release notes: https://issues.jboss.org/projects/JBTM/versions/12333487 https://github.com/jbosstm/narayana/commits/5.5.2.Final https://github.com/jbosstm/narayana/compare/5.5.1.Final...5.5.2.Final was: Release notes: https://issues.jboss.org/projects/JBTM/versions/12333487 https://github.com/jbosstm/narayana/commits/5.5.2.Final > Upgrade Narayana to 5.5.2.Final > ------------------------------- > > Key: WFLY-8127 > URL: https://issues.jboss.org/browse/WFLY-8127 > Project: WildFly > Issue Type: Component Upgrade > Components: Transactions > Reporter: Tom Jenkinson > Assignee: Tom Jenkinson > > Release notes: https://issues.jboss.org/projects/JBTM/versions/12333487 > https://github.com/jbosstm/narayana/commits/5.5.2.Final > https://github.com/jbosstm/narayana/compare/5.5.1.Final...5.5.2.Final -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8129) Upgrade to Narayana 5.5.2.Final (from 5.5.1.Final-redhat-1)

by Kabir Khan (JIRA)

[ https://issues.jboss.org/browse/WFLY-8129?page=com.atlassian.jira.plugin.... ] Kabir Khan moved JBEAP-8861 to WFLY-8129: ----------------------------------------- Project: WildFly (was: JBoss Enterprise Application Platform) Key: WFLY-8129 (was: JBEAP-8861) Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1) Component/s: Transactions (was: Transactions) > Upgrade to Narayana 5.5.2.Final (from 5.5.1.Final-redhat-1) > ----------------------------------------------------------- > > Key: WFLY-8129 > URL: https://issues.jboss.org/browse/WFLY-8129 > Project: WildFly > Issue Type: Component Upgrade > Components: Transactions > Reporter: Kabir Khan > Assignee: Tom Jenkinson > > https://issues.jboss.org/browse/JBTM-2848 was found during testing with the new EJB client and is included in this fix -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-2076) Wrong options for auto-completion in realms of Elytron security-domain in CLI

by Jan Kalina (JIRA)

[ https://issues.jboss.org/browse/WFCORE-2076?page=com.atlassian.jira.plugi... ] Jan Kalina commented on WFCORE-2076: ------------------------------------ Already fixed in wildfly-core 3.0.0.Beta1. Can be closed. > Wrong options for auto-completion in realms of Elytron security-domain in CLI > ----------------------------------------------------------------------------- > > Key: WFCORE-2076 > URL: https://issues.jboss.org/browse/WFCORE-2076 > Project: WildFly Core > Issue Type: Bug > Components: Domain Management, Server > Affects Versions: 3.0.0.Alpha12 > Reporter: Ondrej Lukas > Assignee: Brian Stansberry > Labels: user_experience > Fix For: 3.0.0.Beta1 > > > Auto-completion for realm in realms of security-domain provides wrong options. In case when ldap-realm with name ldapName is defined in configuration then also option {{rity-realm.ldapName}} occurs in auto-completion options. I am not able to reproduce this issue with properties-realm. Take a look at Steps to Reproduce for more details. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-2076) Wrong options for auto-completion in realms of Elytron security-domain in CLI

by Jan Kalina (JIRA)

[ https://issues.jboss.org/browse/WFCORE-2076?page=com.atlassian.jira.plugi... ] Jan Kalina updated WFCORE-2076: ------------------------------- Fix Version/s: 3.0.0.Beta1 > Wrong options for auto-completion in realms of Elytron security-domain in CLI > ----------------------------------------------------------------------------- > > Key: WFCORE-2076 > URL: https://issues.jboss.org/browse/WFCORE-2076 > Project: WildFly Core > Issue Type: Bug > Components: Domain Management, Server > Affects Versions: 3.0.0.Alpha12 > Reporter: Ondrej Lukas > Assignee: Brian Stansberry > Labels: user_experience > Fix For: 3.0.0.Beta1 > > > Auto-completion for realm in realms of security-domain provides wrong options. In case when ldap-realm with name ldapName is defined in configuration then also option {{rity-realm.ldapName}} occurs in auto-completion options. I am not able to reproduce this issue with properties-realm. Take a look at Steps to Reproduce for more details. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1443) Improve effect of caching in ChainedProperties.

by Hans Lund (JIRA)

Hans Lund created DROOLS-1443: --------------------------------- Summary: Improve effect of caching in ChainedProperties. Key: DROOLS-1443 URL: https://issues.jboss.org/browse/DROOLS-1443 Project: Drools Issue Type: Enhancement Components: core engine Reporter: Hans Lund Assignee: Mario Fusco Priority: Minor The ChainedProperties utility has a caching setting that will cache the classpath discovery of property resource - but not the parsing of these resources. This utility is a hot spot for the initialization of runtime environments - caching the parsed properties instead of the resource url will improve runtime performance. Changing the caching strategy will make hot changes to classpath property resources impossible. File based property files could be made safe cacheable by investigating file metadata and only read if changed. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8070) Messaging subsystem passwords and credential-reference should be mutually exclusive

by Jeff Mesnil (JIRA)

[ https://issues.jboss.org/browse/WFLY-8070?page=com.atlassian.jira.plugin.... ] Jeff Mesnil reassigned WFLY-8070: --------------------------------- Assignee: Tomas Hofman (was: Jeff Mesnil) > Messaging subsystem passwords and credential-reference should be mutually exclusive > ----------------------------------------------------------------------------------- > > Key: WFLY-8070 > URL: https://issues.jboss.org/browse/WFLY-8070 > Project: WildFly > Issue Type: Bug > Components: JMS, Security > Reporter: Martin Choma > Assignee: Tomas Hofman > Labels: user_experience > > I don't see any useful use case when I want to configure password attribute in conjuction with credential-reference. > Please mark password attribute and credential-reference in management model as "alternatives". > alternatives – List of string – Indicates an exclusive relationship between attributes. If this attribute is defined, the other attributes listed in this descriptor's value should be undefined (even if their required descriptor says true; i.e. the presence of this attribute satisfies the requirement.) Default is undefined; i.e. this does not apply to most attributes. > It applies to: > * {bridge} > ** Attributes {{password}} and {{credential-reference}} should be mutually exclusive. > * {jms-bridge} > ** Attributes {{source-password}} and {{source-credential-reference}} should be mutually exclusive. > ** Attributes {{target-password}} and {{target-credential-reference}} should be mutually exclusive. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

[JBoss JIRA] (WFLY-8070) Messaging subsystem passwords and credential-reference should be mutually exclusive

by Tomas Hofman (JIRA)

[ https://issues.jboss.org/browse/WFLY-8070?page=com.atlassian.jira.plugin.... ] Tomas Hofman commented on WFLY-8070: ------------------------------------ [~jmesnil] I can take this over, if it's OK with you. > Messaging subsystem passwords and credential-reference should be mutually exclusive > ----------------------------------------------------------------------------------- > > Key: WFLY-8070 > URL: https://issues.jboss.org/browse/WFLY-8070 > Project: WildFly > Issue Type: Bug > Components: JMS, Security > Reporter: Martin Choma > Assignee: Jeff Mesnil > Labels: user_experience > > I don't see any useful use case when I want to configure password attribute in conjuction with credential-reference. > Please mark password attribute and credential-reference in management model as "alternatives". > alternatives – List of string – Indicates an exclusive relationship between attributes. If this attribute is defined, the other attributes listed in this descriptor's value should be undefined (even if their required descriptor says true; i.e. the presence of this attribute satisfies the requirement.) Default is undefined; i.e. this does not apply to most attributes. > It applies to: > * {bridge} > ** Attributes {{password}} and {{credential-reference}} should be mutually exclusive. > * {jms-bridge} > ** Attributes {{source-password}} and {{source-credential-reference}} should be mutually exclusive. > ** Attributes {{target-password}} and {{target-credential-reference}} should be mutually exclusive. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years, 2 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira February 2017