[JBoss JIRA] (JGRP-2168) JChannel(Collection<Protocol>) constructor clears protocol properties with non-default converter whose associated system property is not defined
by Paul Ferraro (JIRA)
Paul Ferraro created JGRP-2168:
----------------------------------
Summary: JChannel(Collection<Protocol>) constructor clears protocol properties with non-default converter whose associated system property is not defined
Key: JGRP-2168
URL: https://issues.jboss.org/browse/JGRP-2168
Project: JGroups
Issue Type: Bug
Affects Versions: 4.0.1, 3.6.13
Reporter: Paul Ferraro
Assignee: Bela Ban
WildFly 11 recently started using the new JChannel(Protocol...) constructor for creating channels. This has resulted in the inability to configure certain protocol properties, most notably, initial_hosts for TCPPING.
Because this constructor calls resolveAndAssignFields(...) with an empty map, if a property was explicitly set, and its associated system property does not exist, and that property uses a non-default converter, then it will have its value undefined (or, more specifically, set to whatever the converter does with a null value).
Additionally, if the assocated system property did exist, it would take precedence over an explicitly set value. I don't think that's a good idea.
Consider the following:
{code:java}
TCP transport = new TCP();
transport.setBindAddress(InetAddress.getLocalHost());
transport.setBindPort(9600);
TCPPING ping = new TCPPING();
ping.setInitialHosts(Collections.singletonList(new IpAddress(transport.getBindAddress(), transport.getBindPort())));
JChannel channel = new JChannel(transport, ping);
assert !ping.getInitialHosts().isEmpty() : "No initial hosts!";
{code}
Side note: new JChannel(Collection<Protocol>) should really be new JChannel(List<Protocol>), since the collection should be ordered.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (WFLY-8651) Undertow servlet 'check-interval' attribute not working
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-8651?page=com.atlassian.jira.plugin.... ]
Stuart Douglas moved JBEAP-10573 to WFLY-8651:
----------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-8651 (was: JBEAP-10573)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Web (Undertow)
(was: Web (Undertow))
Affects Version/s: (was: 7.0.0.CR1)
Release Notes Docs Status: (was: Not Yet Documented)
> Undertow servlet 'check-interval' attribute not working
> -------------------------------------------------------
>
> Key: WFLY-8651
> URL: https://issues.jboss.org/browse/WFLY-8651
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Reporter: Stuart Douglas
> Assignee: Stuart Douglas
>
> After the discussion in this Jira, this attribute should be marked as deprecated actually. Therefore there need to be done:
> # provide information that this attribute is deprecated in resource description in CLI for {{/subsystem=undertow/servlet-container=default/setting=jsp\[check-interval\]}} (since what version + reason)
> # provide such information also in our EAP7 documentation
> *As from discussion following text is irrelevant for now*
> Attribute
> {code}
> /subsystem=undertow/servlet-container=default/setting=jsp[check-interval]
> {code}
> of JSP servlet configuration seems not to be working - whatever is its value, any change to JSP file is propagated to EAP server right after the file change.
> Try following with various values set to {{check-interval}} attribute:
> # start EAP server
> # deploy any war with jsp file (e.g. attached [^simple-jsp.war]) as an exploded archive
> # perform request to {{localhost:8080/simple-jsp}} to see content
> # modify file {{EAP_HOME/standalone/deployments/simple-jsp.war/index.jsp}}
> # perform request again and see that change to file was directly propagated
> Expected behaviour is:
> - when {{check-interval}} is set to 0, then no check for JSP updates is performed at all
> - when {{check-interval}} is greather than 0 and {{developement}} is false, then regular check for JSP updates is provided each X seconds, where X is value of {{check-interval}} attribute
> In EAP6 this seems to be working just fine this way.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (LOGMGR-113) Create a better way to handle a TCP reconnect policy
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGMGR-113?page=com.atlassian.jira.plugin... ]
James Perkins updated LOGMGR-113:
---------------------------------
Fix Version/s: 2.1.0.Alpha2
(was: 2.1.0.Alpha1)
> Create a better way to handle a TCP reconnect policy
> ----------------------------------------------------
>
> Key: LOGMGR-113
> URL: https://issues.jboss.org/browse/LOGMGR-113
> Project: JBoss Log Manager
> Issue Type: Enhancement
> Reporter: James Perkins
> Fix For: 2.1.0.Alpha2
>
>
> The audit logger in WildFly uses it's own policy to reconnect a TCP connection for the {{SyslogHandler}}. The current {{org.jboss.logmanager.handlers.TcpOutputStream}} handles a reconnection on it's own unless a deprecated constructor is used. A way to set some kind of policy or enable the reconnection to be turned off should be added.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (LOGMGR-52) Add option to WriterHandler to collapse repeated messages
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGMGR-52?page=com.atlassian.jira.plugin.... ]
James Perkins updated LOGMGR-52:
--------------------------------
Fix Version/s: 2.1.0.Alpha2
(was: 2.1.0.Alpha1)
> Add option to WriterHandler to collapse repeated messages
> ---------------------------------------------------------
>
> Key: LOGMGR-52
> URL: https://issues.jboss.org/browse/LOGMGR-52
> Project: JBoss Log Manager
> Issue Type: Feature Request
> Reporter: David Lloyd
> Assignee: David Lloyd
> Fix For: 2.1.0.Alpha2
>
>
> The WriterHandler could have a time interval configured wherein a repeated message would be collapsed.
> The last message would be stored in a field for comparison along with a nanoTime tag (the timestamp on the message is not adequate because the clock can have skew or be reset completely at any time). If the current message string equals the last message string, and collapsing is enabled, then instead of logging the message, a count is incremented. If the current message is not equal, then the stored message is logged with a tag indicating the number of repeats (i18n?) and then the next submitted message is logged.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years