[JBoss JIRA] (DROOLS-3154) Minor UI improvements/bugfixes for Scenario
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3154?page=com.atlassian.jira.plugi... ]
Liz Clayton edited comment on DROOLS-3154 at 10/26/18 9:49 AM:
---------------------------------------------------------------
[~gabriolo] I discussed the items with [~danielezonca] and we agreed on this list of changes:
* Change “Index” header label to hash sign:
“#”
* Change “Description” header label to:
“Scenario description”
.
* Contextual menus: Remove “Scenario: Insert top/bottom row.”
* Contextual menus in headers: Remove "Scenario: Insert top/bottom row” and replace with only "Scenario: Insert row below”.
* Eliminate the possibility for the user to remove all scenario rows. If the user choices to delete the last remaining row:
- delete it, but replace it with an “empty” row.
was (Author: uxdlc):
[~gabriolo] I discussed the items with [~danielezonca] and we agreed on this list of changes:
* Change “Index” header label to hash sign:
“#”
* Change “Description” header label to:
“Scenario description”
.
* Contextual menus: Remove “Scenario: Insert top/bottom row.”
* Contextual menus in headers: Remove "Scenario: Insert top/bottom row” and replace with only "Scenario: Insert row below”.
* Eliminate the possibility for the user to remove all scenario rows. If the user choices to delete the last remaining row:
- delete it, but replace it with an “empty” row.
> Minor UI improvements/bugfixes for Scenario
> -------------------------------------------
>
> Key: DROOLS-3154
> URL: https://issues.jboss.org/browse/DROOLS-3154
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Daniele Zonca
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: UX-CSS
> Attachments: Screen Shot 2018-10-25 at 9.53.57 PM.png, test-editor-margin.png
>
>
> This item contains a list of general UI bugs to be fixed:
> -Use grey borders for all the grid and not only for the header- Fixed in DROOLS-2684
> -Add some padding to the cells of the grid- Fixed in DROOLS-2684
> Add some padding to right panel the tab titles
> -Remove scrolling bar from right panel- Fixed in DROOLS-3170
> Review expression editor component HTML/CSS (paddings, indents, etc)
> Review right panel padding (now it is hardcoded)
> Use text area inputs instead of text box for inline editing
> -Reduce the width of Index column- Fixed in DROOLS-3167
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3154) Minor UI improvements/bugfixes for Scenario
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3154?page=com.atlassian.jira.plugi... ]
Liz Clayton edited comment on DROOLS-3154 at 10/26/18 9:49 AM:
---------------------------------------------------------------
[~gabriolo] I discussed the items with [~danielezonca] and we agreed on this list of changes:
* Change “Index” header label to hash sign:
“#”
* Change “Description” header label to:
“Scenario description”
.
* Contextual menus: Remove “Scenario: Insert top/bottom row.”
* Contextual menus in headers: Remove "Scenario: Insert top/bottom row” and replace with only "Scenario: Insert row below”.
* Eliminate the possibility for the user to remove all scenario rows. If the user choices to delete the last remaining row:
- delete it, but replace it with an “empty” row.
was (Author: uxdlc):
[~gabriolo] I discussed the items with [~danielezonca] and we agreed on this list of changes:
* Change “Index” header label to hash sign:
“#”
* Change “Description” header label to:
“Scenario description”
* Contextual menus: Remove “Scenario: Insert top/bottom row.”
* Contextual menus in headers: Remove "Scenario: Insert top/bottom row” and replace with only "Scenario: Insert row below”.
* Eliminate the possibility for the user to remove all scenario rows. If the user choices to delete the last remaining row:
- delete it, but replace it with an “empty” row.
> Minor UI improvements/bugfixes for Scenario
> -------------------------------------------
>
> Key: DROOLS-3154
> URL: https://issues.jboss.org/browse/DROOLS-3154
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Daniele Zonca
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: UX-CSS
> Attachments: Screen Shot 2018-10-25 at 9.53.57 PM.png, test-editor-margin.png
>
>
> This item contains a list of general UI bugs to be fixed:
> -Use grey borders for all the grid and not only for the header- Fixed in DROOLS-2684
> -Add some padding to the cells of the grid- Fixed in DROOLS-2684
> Add some padding to right panel the tab titles
> -Remove scrolling bar from right panel- Fixed in DROOLS-3170
> Review expression editor component HTML/CSS (paddings, indents, etc)
> Review right panel padding (now it is hardcoded)
> Use text area inputs instead of text box for inline editing
> -Reduce the width of Index column- Fixed in DROOLS-3167
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3154) Minor UI improvements/bugfixes for Scenario
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3154?page=com.atlassian.jira.plugi... ]
Liz Clayton commented on DROOLS-3154:
-------------------------------------
[~gabriolo] I discussed the items with [~danielezonca] and we agreed on this list of changes:
* Change “Index” header label to hash sign:
“#”
* Change “Description” header label to:
“Scenario description”
* Contextual menus: Remove “Scenario: Insert top/bottom row.”
* Contextual menus in headers: Remove "Scenario: Insert top/bottom row” and replace with only "Scenario: Insert row below”.
* Eliminate the possibility for the user to remove all scenario rows. If the user choices to delete the last remaining row:
- delete it, but replace it with an “empty” row.
> Minor UI improvements/bugfixes for Scenario
> -------------------------------------------
>
> Key: DROOLS-3154
> URL: https://issues.jboss.org/browse/DROOLS-3154
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Daniele Zonca
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: UX-CSS
> Attachments: Screen Shot 2018-10-25 at 9.53.57 PM.png, test-editor-margin.png
>
>
> This item contains a list of general UI bugs to be fixed:
> -Use grey borders for all the grid and not only for the header- Fixed in DROOLS-2684
> -Add some padding to the cells of the grid- Fixed in DROOLS-2684
> Add some padding to right panel the tab titles
> -Remove scrolling bar from right panel- Fixed in DROOLS-3170
> Review expression editor component HTML/CSS (paddings, indents, etc)
> Review right panel padding (now it is hardcoded)
> Use text area inputs instead of text box for inline editing
> -Reduce the width of Index column- Fixed in DROOLS-3167
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3197) [DMN Designer] Edit multiple diagrams in parallel
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3197?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3197:
----------------------------------------
Cannot replicate with DROOLS-3143 merged and {{kie-drools-wb}} locally.
Sorry [~jomarko] I think I'm going to need some more detailed steps as to how to reproduce :-(
> [DMN Designer] Edit multiple diagrams in parallel
> -------------------------------------------------
>
> Key: DROOLS-3197
> URL: https://issues.jboss.org/browse/DROOLS-3197
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: drools-tools
> Attachments: unexpected-error.log
>
>
> Spotted during DROOLS-3143 review, however not sure if related.
> If multiple DMN diagrams are opened, there appears unexpected error dialog during modeling one of them. The error message attached.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3197) [DMN Designer] Edit multiple diagrams in parallel
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3197?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3197:
----------------------------------------
Cannot replicate with DROOLS-3143 merged locally and {{drools-wb-webapp}}... trying {{kie-drools-wb}} with DROOLS-3143.
> [DMN Designer] Edit multiple diagrams in parallel
> -------------------------------------------------
>
> Key: DROOLS-3197
> URL: https://issues.jboss.org/browse/DROOLS-3197
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: drools-tools
> Attachments: unexpected-error.log
>
>
> Spotted during DROOLS-3143 review, however not sure if related.
> If multiple DMN diagrams are opened, there appears unexpected error dialog during modeling one of them. The error message attached.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3184:
-------------------------------------
[~tari_manga] thanks for the updated PR, definitely the blocking issue (impossible save) is solved now. However it seems to me that still the waypoints of connections are stored in inappropriate way. I am attaching 4 models and analysis (see PR analysis link) how they differ in our designer and trisotech. Leaving the decision to you and [~manstis] as more senior engineers what to do next.
[^a1.dmn] [^a2.dmn] [^a3.dmn] [^a4.dmn]
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, a1.dmn, a2.dmn, a3.dmn, a4.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
> h2. Manual acceptance test
> - Save and reopen diagrams from sections below
> - Import to external tool diagrams form sections below
> h3. Nodes connected manually
> - Default magnet points
> - Explicit magnet points
> h3. Nodes connected automatically
> - Default magnet points
> - Explicit magnet points
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3184:
--------------------------------
Attachment: a4.dmn
a3.dmn
a2.dmn
a1.dmn
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, a1.dmn, a2.dmn, a3.dmn, a4.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
> h2. Manual acceptance test
> - Save and reopen diagrams from sections below
> - Import to external tool diagrams form sections below
> h3. Nodes connected manually
> - Default magnet points
> - Explicit magnet points
> h3. Nodes connected automatically
> - Default magnet points
> - Explicit magnet points
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3197) [DMN Designer] Edit multiple diagrams in parallel
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3197?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3197:
----------------------------------------
Cannot replicate with {{master}} (i.e. before DROOLS-3143 is merged) on {{drools-wb-webapp}}.
Will try with DROOLS-3143 merged locally and with {{kie-drools-wb}}.
> [DMN Designer] Edit multiple diagrams in parallel
> -------------------------------------------------
>
> Key: DROOLS-3197
> URL: https://issues.jboss.org/browse/DROOLS-3197
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: drools-tools
> Attachments: unexpected-error.log
>
>
> Spotted during DROOLS-3143 review, however not sure if related.
> If multiple DMN diagrams are opened, there appears unexpected error dialog during modeling one of them. The error message attached.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months