[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3184:
--------------------------------
Description:
The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
{code:xml}
<dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
<di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
<di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
</dmndi:DMNEdge>
{code}
However in our designer the edge has different waypoints:
!Screenshot from 2018-10-25 12-12-20.png|thumbnail!
In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
!image (2).png|thumbnail!
h2. Manual acceptance test
Save and reopen diagrams where:
h3. Nodes connected manually
- Default magnet points
- Explicit magnet points
h3. Nodes connected automatically
- Default magnet points
- Explicit magnet points
was:
The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
{code:xml}
<dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
<di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
<di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
</dmndi:DMNEdge>
{code}
However in our designer the edge has different waypoints:
!Screenshot from 2018-10-25 12-12-20.png|thumbnail!
In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
!image (2).png|thumbnail!
h2. Manual acceptance test
h3. Nodes connected manually
- Default magnet points
- Explicit magnet points
h3. Nodes connected automatically
- Default magnet points
- Explicit magnet points
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
> h2. Manual acceptance test
> Save and reopen diagrams where:
> h3. Nodes connected manually
> - Default magnet points
> - Explicit magnet points
> h3. Nodes connected automatically
> - Default magnet points
> - Explicit magnet points
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3186) [DMN Designer] Remove Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3186?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3186:
----------------------------------------
[~jomarko] Fixed. Thank-you for finding :-)
!DROOLS-3186 (fixed).png|thumbnail!
> [DMN Designer] Remove Shape BorderSize and Font BorderSize properties
> ---------------------------------------------------------------------
>
> Key: DROOLS-3186
> URL: https://issues.jboss.org/browse/DROOLS-3186
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: DROOLS-3186 (fixed).png, Screenshot from 2018-10-26 11-34-57.png, Screenshot from 2018-10-26 11-36-26.png
>
>
> {quote}
> Offical DMNDI (of spec DMNv1.2) has no support for Shape border size, Font border size. I will not persist this information.
> {quote}
> > Did you want these properties removed from the Editor?
> > I would say given the current deadlines the safest approach is to temporarily hide and disable them
> h2. Acceptance test
> - No node type has these properties (x)
> - Save and reopen (/)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3186) [DMN Designer] Remove Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3186?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3186:
-----------------------------------
Attachment: DROOLS-3186 (fixed).png
> [DMN Designer] Remove Shape BorderSize and Font BorderSize properties
> ---------------------------------------------------------------------
>
> Key: DROOLS-3186
> URL: https://issues.jboss.org/browse/DROOLS-3186
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: DROOLS-3186 (fixed).png, Screenshot from 2018-10-26 11-34-57.png, Screenshot from 2018-10-26 11-36-26.png
>
>
> {quote}
> Offical DMNDI (of spec DMNv1.2) has no support for Shape border size, Font border size. I will not persist this information.
> {quote}
> > Did you want these properties removed from the Editor?
> > I would say given the current deadlines the safest approach is to temporarily hide and disable them
> h2. Acceptance test
> - No node type has these properties (x)
> - Save and reopen (/)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3195) [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3195?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3195:
-----------------------------------
Priority: Optional (was: Major)
> [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-3195
> URL: https://issues.jboss.org/browse/DROOLS-3195
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Edson Tirelli
> Priority: Optional
> Labels: drools-tools
>
> Following https://issues.jboss.org/browse/DROOLS-3186 both "Shape BorderSize" and "Font BorderSize" properties were removed as they are not supported by the DMN1.2 DI format. However there was some discussion as to whether we should support them as extension elements in the XML we marshall.
> Well, IMO, if these properties are not part of the standard there's no real need to add support for them (it has little effect on the UI.. removal - and reinstatement - is trivial). However it has bigger ramifications on the backend code.
> I'm leaving the decision as to whether we want to support these properties as extensions with [~tirelli] and to a lessor extent [~tari_manga] :-)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3195) [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3195?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3195:
-----------------------------------
Tester: Jozef Marko
> [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-3195
> URL: https://issues.jboss.org/browse/DROOLS-3195
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Edson Tirelli
> Priority: Major
> Labels: drools-tools
>
> Following https://issues.jboss.org/browse/DROOLS-3186 both "Shape BorderSize" and "Font BorderSize" properties were removed as they are not supported by the DMN1.2 DI format. However there was some discussion as to whether we should support them as extension elements in the XML we marshall.
> Well, IMO, if these properties are not part of the standard there's no real need to add support for them (it has little effect on the UI.. removal - and reinstatement - is trivial). However it has bigger ramifications on the backend code.
> I'm leaving the decision as to whether we want to support these properties as extensions with [~tirelli] and to a lessor extent [~tari_manga] :-)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3195) [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3195?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3195:
-----------------------------------
Labels: drools-tools (was: )
> [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-3195
> URL: https://issues.jboss.org/browse/DROOLS-3195
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Edson Tirelli
> Priority: Major
> Labels: drools-tools
>
> Following https://issues.jboss.org/browse/DROOLS-3186 both "Shape BorderSize" and "Font BorderSize" properties were removed as they are not supported by the DMN1.2 DI format. However there was some discussion as to whether we should support them as extension elements in the XML we marshall.
> Well, IMO, if these properties are not part of the standard there's no real need to add support for them (it has little effect on the UI.. removal - and reinstatement - is trivial). However it has bigger ramifications on the backend code.
> I'm leaving the decision as to whether we want to support these properties as extensions with [~tirelli] and to a lessor extent [~tari_manga] :-)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3195) [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
by Michael Anstis (Jira)
Michael Anstis created DROOLS-3195:
--------------------------------------
Summary: [DMN Designer] [DMN Designer] Reinstate Shape BorderSize and Font BorderSize properties
Key: DROOLS-3195
URL: https://issues.jboss.org/browse/DROOLS-3195
Project: Drools
Issue Type: Feature Request
Components: DMN Editor
Reporter: Michael Anstis
Assignee: Edson Tirelli
Following https://issues.jboss.org/browse/DROOLS-3186 both "Shape BorderSize" and "Font BorderSize" properties were removed as they are not supported by the DMN1.2 DI format. However there was some discussion as to whether we should support them as extension elements in the XML we marshall.
Well, IMO, if these properties are not part of the standard there's no real need to add support for them (it has little effect on the UI.. removal - and reinstatement - is trivial). However it has bigger ramifications on the backend code.
I'm leaving the decision as to whether we want to support these properties as extensions with [~tirelli] and to a lessor extent [~tari_manga] :-)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3184:
-------------------------------------
[~tari_manga] no problem, just was not sure who to ask for marking me in PR.
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months