[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3184:
----------------------------------------
[~jomarko] Yes, this is the same as both [~karreiro] and I found.
It is caused when the User adds an additional node using the toolbox icons for the new node (as opposed to adding two nodes manually and then adding the connector). This is because when adding a connector automatically it is "fixed" to the source/parent shapes centre point. The connections' locations are relative to the shapes' centre point and (I have to assume that) when attached to the centre the connectors end-point is {{null}}. When adding the connector manually it is attached to the shapes left/right edge and the end-points non-{{null}} BUT *relative* to the shape's location.
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3151) [DMN Designer] Decision Table: Improve contrast of Input- and OutputClause columns
by Daniele Zonca (Jira)
[ https://issues.jboss.org/browse/DROOLS-3151?page=com.atlassian.jira.plugi... ]
Daniele Zonca commented on DROOLS-3151:
---------------------------------------
[~bdellasc]
Thanks for the proposal, I like it :)
I found a "bug" in the proposal: hex code for "Cell Error Outline" and "Cell Error BG" are the same but RGB codes are different. I think hex is wrong and RGB is correct so can you confirm that "Cell Error BG" is #FFE6E6? (I used an online RGB to Hex converter)
> [DMN Designer] Decision Table: Improve contrast of Input- and OutputClause columns
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-3151
> URL: https://issues.jboss.org/browse/DROOLS-3151
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.13.0.Final
> Reporter: Edson Tirelli
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools
> Fix For: 7.14.0.Final
>
> Attachments: DROOLS-3151-DMN.png, DROOLS-3151-GDT.png, GDT.png, dtable-column-colours.png
>
>
> [~tirelli] requested greater visual contrast between {{InputClause}} and {{OutputClause}} columns.
> {quote}
> this is way too subtle, to be honest... can we get colours that are a bit more distinguishable?
> {quote}
> See the attached screenshot.
> Additional note for clarity, goal is to: clearly differentiate between different blocks of columns (decision table: input column, output column plus possibly a third "general" type.)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3184:
--------------------------------
Attachment: error.log
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Jozef Marko edited comment on DROOLS-3184 at 10/26/18 4:30 AM:
---------------------------------------------------------------
Here is exception I am getting [^error.log]
was (Author: jomarko):
Here is exception I am getting http://pastebin.test.redhat.com/662858
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, error.log, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3184:
----------------------------------------
[~tari_manga] Yes and no.
You're checking the connection objects exist but then assume:
# Their locations ({{Point2D}} are non-null
# The locatations are absolute to the canvas.
In reality, on debugging, the locations of the connectors end-points can be null and if non-null are relative to the source/target shape.
So, when you convert the Stunner connector end-points to DMNDI you need to take the source/target shape location into account too.
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3184) [DMN Designer] Edge source and target WayPoints are same
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3184?page=com.atlassian.jira.plugi... ]
Michael Anstis edited comment on DROOLS-3184 at 10/26/18 4:24 AM:
------------------------------------------------------------------
[~tari_manga] Yes and no.
You're checking the connection objects exist but then assume:
# Their locations ({{Point2D}}) are non-null
# The locatations are absolute to the canvas.
In reality, on debugging, the locations of the connectors end-points can be null and if non-null are relative to the source/target shape.
So, when you convert the Stunner connector end-points to DMNDI you need to take the source/target shape location into account too.
was (Author: manstis):
[~tari_manga] Yes and no.
You're checking the connection objects exist but then assume:
# Their locations ({{Point2D}} are non-null
# The locatations are absolute to the canvas.
In reality, on debugging, the locations of the connectors end-points can be null and if non-null are relative to the source/target shape.
So, when you convert the Stunner connector end-points to DMNDI you need to take the source/target shape location into account too.
> [DMN Designer] Edge source and target WayPoints are same
> --------------------------------------------------------
>
> Key: DROOLS-3184
> URL: https://issues.jboss.org/browse/DROOLS-3184
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Matteo Mortari
> Priority: Blocker
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 12-12-20.png, a1.dmn, image (2).png
>
>
> The source of DMN model has same waypoint for edge source and target. If you open the attached [^a1.dmn] model, there will be:
> {code:xml}
> <dmndi:DMNEdge id="dmnedge-_594C4BE1-52D0-4009-9D4F-9960957539FB" dmnElementRef="_594C4BE1-52D0-4009-9D4F-9960957539FB">
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> <di:waypoint xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" x="50" y="25"/>
> </dmndi:DMNEdge>
> {code}
> However in our designer the edge has different waypoints:
> !Screenshot from 2018-10-25 12-12-20.png|thumbnail!
> In the external modeling tools, the edge is rendered according to real waypoints and this the edge is not visible:
> !image (2).png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3025) [DMN Designer] Data Types - Set a Data Type as a collection Data Type
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3025?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3025:
--------------------------------
Fix Version/s: 7.14.0.Final
> [DMN Designer] Data Types - Set a Data Type as a collection Data Type
> ---------------------------------------------------------------------
>
> Key: DROOLS-3025
> URL: https://issues.jboss.org/browse/DROOLS-3025
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Guilherme Carreiro
> Assignee: Guilherme Carreiro
> Priority: Major
> Labels: drools-tools
> Fix For: 7.14.0.Final
>
> Attachments: edit-mode-closed.png, interaction.gif
>
>
> - A Data Type must be set as a collection data type;
> - Interaction:
> !interaction.gif|thumbnail!
> - When edit mode is closed, it should show "✔ Yes" for a collection data type and none for a non-collection data type:
> !edit-mode-closed.png|thumbnail!
> - PatternFly base element for the switch button https://www.patternfly.org/pattern-library/widgets/#bootstrap-switch
> h2. Manual acceptance test
> - Construct top level item definition
> - Use in other structure as list
> - Build and deploy
> - Interact with kie-server, unable to check due to DROOLS-3110
> - Open in external designer (/)
> - Firefox, Chrome, Edge (/)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months