[JBoss JIRA] (WFWIP-124) java.lang.NumberFormatException: multiple points when accessing /metrics
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-124?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil resolved WFWIP-124.
-------------------------------
Resolution: Done
> java.lang.NumberFormatException: multiple points when accessing /metrics
> ------------------------------------------------------------------------
>
> Key: WFWIP-124
> URL: https://issues.jboss.org/browse/WFWIP-124
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Rostislav Svoboda
> Assignee: Jeff Mesnil
> Priority: Blocker
>
> When accessing http://127.0.0.1:9990/metrics I see {{java.lang.NumberFormatException: multiple points}}
> Using build from WFLY-10712_microprofile_metrics-smallrye branch.
> {code}
> 15:38:26,657 INFO [stdout] (management I/O-2) metricName = /socket-binding-group/standard-sockets/socket-binding/management-http.bound-address
> 15:38:26,661 ERROR [stderr] (management I/O-2) java.lang.NumberFormatException: multiple points
> 15:38:26,662 ERROR [stderr] (management I/O-2) at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1914)
> 15:38:26,662 ERROR [stderr] (management I/O-2) at java.base/jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
> 15:38:26,662 ERROR [stderr] (management I/O-2) at java.base/java.lang.Double.parseDouble(Double.java:543)
> 15:38:26,663 ERROR [stderr] (management I/O-2) at org.jboss.dmr@1.5.0.Final//org.jboss.dmr.StringModelValue.asDouble(StringModelValue.java:173)
> 15:38:26,663 ERROR [stderr] (management I/O-2) at org.jboss.dmr@1.5.0.Final//org.jboss.dmr.ModelNode.asDouble(ModelNode.java:405)
> 15:38:26,663 ERROR [stderr] (management I/O-2) at org.wildfly.extension.microprofile.metrics-smallrye@15.0.0.Alpha1-SNAPSHOT//org.wildfly.extension.microprofile.metrics.WildFlyMetricsRegistrationService$1.getValue(WildFlyMetricsRegistrationService.java:139)
> 15:38:26,664 ERROR [stderr] (management I/O-2) at org.wildfly.extension.microprofile.metrics-smallrye@15.0.0.Alpha1-SNAPSHOT//org.wildfly.extension.microprofile.metrics.WildFlyMetricsRegistrationService$1.getValue(WildFlyMetricsRegistrationService.java:129)
> 15:38:26,664 ERROR [stderr] (management I/O-2) at io.smallrye.metrics//io.smallrye.metrics.exporters.PrometheusExporter.createSimpleValueLine(PrometheusExporter.java:334)
> 15:38:26,664 ERROR [stderr] (management I/O-2) at io.smallrye.metrics//io.smallrye.metrics.exporters.PrometheusExporter.exposeEntries(PrometheusExporter.java:137)
> 15:38:26,664 ERROR [stderr] (management I/O-2) at io.smallrye.metrics//io.smallrye.metrics.exporters.PrometheusExporter.getEntriesForScope(PrometheusExporter.java:116)
> 15:38:26,665 ERROR [stderr] (management I/O-2) at io.smallrye.metrics//io.smallrye.metrics.exporters.PrometheusExporter.exportAllScopes(PrometheusExporter.java:85)
> 15:38:26,665 ERROR [stderr] (management I/O-2) at io.smallrye.metrics//io.smallrye.metrics.MetricsRequestHandler.handleRequest(MetricsRequestHandler.java:83)
> 15:38:26,666 ERROR [stderr] (management I/O-2) at org.wildfly.extension.microprofile.metrics-smallrye@15.0.0.Alpha1-SNAPSHOT//org.wildfly.extension.microprofile.metrics.MetricsContextService$1.handleRequest(MetricsContextService.java:82)
> 15:38:26,666 ERROR [stderr] (management I/O-2) at org.jboss.as.domain-http-interface@7.0.0.Alpha2//org.jboss.as.domain.http.server.security.RealmReadinessHandler.handleRequest(RealmReadinessHandler.java:51)
> 15:38:26,667 ERROR [stderr] (management I/O-2) at org.jboss.as.domain-http-interface@7.0.0.Alpha2//org.jboss.as.domain.http.server.security.ServerErrorReadinessHandler.handleRequest(ServerErrorReadinessHandler.java:35)
> 15:38:26,667 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.handlers.PathHandler.handleRequest(PathHandler.java:94)
> 15:38:26,667 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.handlers.ChannelUpgradeHandler.handleRequest(ChannelUpgradeHandler.java:211)
> 15:38:26,667 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.handlers.cache.CacheHandler.handleRequest(CacheHandler.java:92)
> 15:38:26,668 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.handlers.error.SimpleErrorPageHandler.handleRequest(SimpleErrorPageHandler.java:78)
> 15:38:26,668 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.handlers.CanonicalPathHandler.handleRequest(CanonicalPathHandler.java:49)
> 15:38:26,668 ERROR [stderr] (management I/O-2) at org.jboss.as.domain-http-interface@7.0.0.Alpha2//org.jboss.as.domain.http.server.ManagementHttpRequestHandler.handleRequest(ManagementHttpRequestHandler.java:57)
> 15:38:26,668 ERROR [stderr] (management I/O-2) at org.jboss.as.domain-http-interface@7.0.0.Alpha2//org.jboss.as.domain.http.server.cors.CorsHttpHandler.handleRequest(CorsHttpHandler.java:75)
> 15:38:26,669 ERROR [stderr] (management I/O-2) at org.jboss.as.domain-http-interface@7.0.0.Alpha2//org.jboss.as.domain.http.server.ManagementHttpServer$UpgradeFixHandler.handleRequest(ManagementHttpServer.java:662)
> 15:38:26,669 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.Connectors.executeRootHandler(Connectors.java:360)
> 15:38:26,669 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.protocol.http.HttpReadListener.handleEventWithNoRunningRequest(HttpReadListener.java:255)
> 15:38:26,670 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.protocol.http.HttpReadListener.handleEvent(HttpReadListener.java:136)
> 15:38:26,670 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:147)
> 15:38:26,670 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:93)
> 15:38:26,671 ERROR [stderr] (management I/O-2) at io.undertow.core@2.0.13.Final//io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:52)
> 15:38:26,671 ERROR [stderr] (management I/O-2) at org.jboss.xnio@3.6.5.Final//org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
> 15:38:26,671 ERROR [stderr] (management I/O-2) at org.jboss.xnio@3.6.5.Final//org.xnio.ChannelListeners$10.handleEvent(ChannelListeners.java:291)
> 15:38:26,671 ERROR [stderr] (management I/O-2) at org.jboss.xnio@3.6.5.Final//org.xnio.ChannelListeners$10.handleEvent(ChannelListeners.java:286)
> 15:38:26,672 ERROR [stderr] (management I/O-2) at org.jboss.xnio@3.6.5.Final//org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
> 15:38:26,672 ERROR [stderr] (management I/O-2) at org.jboss.xnio.nio@3.6.5.Final//org.xnio.nio.QueuedNioTcpServer$1.run(QueuedNioTcpServer.java:131)
> 15:38:26,672 ERROR [stderr] (management I/O-2) at org.jboss.xnio.nio@3.6.5.Final//org.xnio.nio.WorkerThread.safeRun(WorkerThread.java:612)
> 15:38:26,672 ERROR [stderr] (management I/O-2) at org.jboss.xnio.nio@3.6.5.Final//org.xnio.nio.WorkerThread.run(WorkerThread.java:479)
> {code}
> This happens with every hit of metrics endpoint, marking as Blocker. We need to have "clear" logs.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFWIP-126) MP metrics not enabled for HA profiles
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-126?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil resolved WFWIP-126.
-------------------------------
Resolution: Done
Fix in dev branch
> MP metrics not enabled for HA profiles
> --------------------------------------
>
> Key: WFWIP-126
> URL: https://issues.jboss.org/browse/WFWIP-126
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Rostislav Svoboda
> Assignee: Jeff Mesnil
> Priority: Blocker
>
> MP Metrics not enabled for HA profiles
> {code}
> grep 'org.wildfly.extension.microprofile.metrics-smallrye' dist/target/wildfly-15.0.0.Alpha1-SNAPSHOT/standalone/configuration/*.xml
> {code}
> MP Metrics enabled in:
> * standalone-full.xml
> * standalone.xml
> MP Metrics NOT enabled in:
> * standalone-ha.xml
> * standalone-full-ha.xml
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFWIP-128) Subsystem metrics names split in incorrect places
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-128?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil commented on WFWIP-128:
-----------------------------------
Fixed in smallrye-metrics by https://github.com/smallrye/smallrye-metrics/pull/17
> Subsystem metrics names split in incorrect places
> -------------------------------------------------
>
> Key: WFWIP-128
> URL: https://issues.jboss.org/browse/WFWIP-128
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Rostislav Svoboda
> Assignee: Jeff Mesnil
> Priority: Blocker
>
> Subsystem metrics names split (underscore) in incorrect places. So far I noticed these things in jgroups and messaging.
> Underscore is used in some attributes quite often, conversion of {{/}} to {{_}} adds some confusion.
> JGroups
> * jgroups_channel_ee_protocol_un_ic_as_t3 ...
> * jgroups_channel_ee_protocol_pbcast_gm_s_view ...
> * jgroups_channel_ee_protocol_fr_ag3_level ...
> * jgroups_channel_ee_protocol_fd_so_ck_id ...
> Messaging
> * jms_queue_dl_q ...
> {code}
> [standalone@localhost:10090 channel=ee] ls /subsystem=jgroups/channel=ee/protocol
> FD_ALL FRAG3 MFC UDP UNICAST3 pbcast.GMS pbcast.STABLE
> FD_SOCK MERGE3 PING UFC VERIFY_SUSPECT pbcast.NAKACK2
> [standalone@localhost:10090 channel=ee] ls /subsystem=jgroups/channel=ee/protocol=FD_SOCK
> after_creation_hook=undefined external_addr=undefined log_suspected_messages=true pingable_members=[rs]
> bind_addr=/127.0.0.1 external_port=0 members=(1) rs port_range=50
> cache_max_age=10000 get_cache_timeout=1000 node_crash_monitor_running=false sock_conn_timeout=1000
> cache_max_elements=200 id=2 num_suspect_events_generated=0 start_port=0
> client_bind_port=0 keep_alive=true num_suspected_members=0 stats=false
> client_bind_port_actual=0 level=undefined num_tries=3 suspect_msg_interval=5000
> ergonomics=true local_address=rs ping_dest=null suspected_members=[]
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFCORE-4193) Maven Wildfly plugin should be working with Java 9+
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4193?page=com.atlassian.jira.plugi... ]
James Perkins resolved WFCORE-4193.
-----------------------------------
Resolution: Done
I'm resolving this as done since the 2.0.0.Final version of the wildfly-maven-plugin was released.
> Maven Wildfly plugin should be working with Java 9+
> ---------------------------------------------------
>
> Key: WFCORE-4193
> URL: https://issues.jboss.org/browse/WFCORE-4193
> Project: WildFly Core
> Issue Type: Bug
> Reporter: Michal Jurc
> Assignee: James Perkins
> Priority: Blocker
> Labels: java11
>
> Without the workaround, the following error is thrown by JVM upon starting WildFly/JBoss CLI utilising the plugin:
> {code}21:35:19 [INFO] STANDALONE server is starting up.
> 21:35:20 org.jboss.modules.ModuleNotFoundException: java.se
> 21:35:20 at org.jboss.modules.Module.addPaths(Module.java:1266)
> 21:35:20 at org.jboss.modules.Module.link(Module.java:1622)
> 21:35:20 at org.jboss.modules.Module.relinkIfNecessary(Module.java:1650)
> 21:35:20 at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:296)
> 21:35:20 at org.jboss.modules.Main.main(Main.java:437){code}
> This is pretty cumbersome and a blocker to migrating application without change of configuration.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFCORE-4186) RBAC classification resources should not store default-xxx attribute values in the DMR model
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFCORE-4186?page=com.atlassian.jira.plugi... ]
Jeff Mesnil resolved WFCORE-4186.
---------------------------------
Fix Version/s: 7.0.0.Alpha5
Resolution: Done
> RBAC classification resources should not store default-xxx attribute values in the DMR model
> --------------------------------------------------------------------------------------------
>
> Key: WFCORE-4186
> URL: https://issues.jboss.org/browse/WFCORE-4186
> Project: WildFly Core
> Issue Type: Bug
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Minor
> Fix For: 7.0.0.Alpha5
>
>
> The RBAC classification resource are storing the values of the relevant default-requires-xxx attributes in the DMR model even though those are runtime-only attributes. The DMR value is unused in read-resource/read-attribute because the read handlers for the attribute don't read from DMR.
> Unless WFCORE-4185 is fixed these will get propogated to slave HCs when they connect though.
> Cleaning this up helps resolve WFCORE-4183 by removing irrelevant data that confuses domain mode transformer tests.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFWIP-127) Subsystem jgroups exposes 354 metrics, no way to expose subset of metrics
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-127?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil commented on WFWIP-127:
-----------------------------------
First, with the updated dev branch that excludes metrics without numeric types, jgroups metrics go from 354 to 180:
{code}
curl http://localhost:9990/metrics 2>/dev/null | grep -v TYPE | grep -v HELP | grep subsystem | cut -d_ -f 3 | sort | uniq -c
10 activemq
1 average
180 channel
1 controller
7 jberet
10 number
18 server
7 thread
5 worker
8 workmanager
{code}
2nd improvement specific to jgroups would be check that its statistics-enabled[1] attribute is working as expected. I would expect that the metrics attached to the channel resource have values only when the channel's statistics-enabled is true.
[~pferraro] Could you please confirm that this is the case?
However, I am not sure about exposing only a subset of a metrics for a given subsystem.
The steps to monitor metrics are:
1. query all metrics that are available
2. select the ones you are interested in from the monitoring tool and monitor only those.
Having a huge number of metrics is an UX issue for the monitoring tool. But I found that counter-intuitive to fix this UX issue by having the app server specifies which metrics are of interest to the monitoring tool.
[1] http://wildscribe.github.io/WildFly/14.0//subsystem/jgroups/channel/ee/in...
> Subsystem jgroups exposes 354 metrics, no way to expose subset of metrics
> -------------------------------------------------------------------------
>
> Key: WFWIP-127
> URL: https://issues.jboss.org/browse/WFWIP-127
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Rostislav Svoboda
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Subsystem jgroups exposes 354 metrics
> There is no way to expose subset of metrics for subsystem
> standalone.xml
> {code}
> curl http://localhost:10090/metrics 2>/dev/null | grep -v TYPE | grep -v HELP | wc -l
> 109
> curl http://localhost:10090/metrics 2>/dev/null | grep -v TYPE | grep -v HELP | grep subsystem | cut -d_ -f 3 | sort | uniq -c
> 7 batch
> 1 datasources
> 7 ejb3
> 6 io
> 8 jca
> 1 request
> 11 transactions
> 12 undertow
> {code}
> standalone-full-ha.xml
> {code}
> curl http://localhost:10090/metrics 2>/dev/null | grep -v TYPE | grep -v HELP | wc -l
> 497
> curl http://localhost:10090/metrics 2>/dev/null | grep -v TYPE | grep -v HELP | grep subsystem | cut -d_ -f 3 | sort | uniq -c
> 7 batch
> 1 datasources
> 7 ejb3
> 6 io
> 8 jca
> 354 jgroups
> 10 messaging
> 1 request
> 11 transactions
> 18 undertow
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months