[JBoss JIRA] (DROOLS-2392) [DMN Designer] Undo and Redo does not update user interface
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2392?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2392:
--------------------------------
Description:
Undo and consequent Redo of commands which manipulates context entries (basically all) for non trivial scenarios does not update user interface correctly.
In the steps for reproduce used AddRuleCommand, but generally it can be reproduced with any command.
was:Undo and consequent Redo of AddDecisionRule command for non trivial scenarios does not update user interface correctly.
> [DMN Designer] Undo and Redo does not update user interface
> -----------------------------------------------------------
>
> Key: DROOLS-2392
> URL: https://issues.jboss.org/browse/DROOLS-2392
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Attachments: Screenshot from 2018-03-16 10-38-41.png
>
>
> Undo and consequent Redo of commands which manipulates context entries (basically all) for non trivial scenarios does not update user interface correctly.
> In the steps for reproduce used AddRuleCommand, but generally it can be reproduced with any command.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (DROOLS-2301) Decision Table editor
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2301?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2301:
--------------------------------
Description:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
## DROOLS-2392
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
# Invoke menu when multiple cells selected (x)
## DROOLS-2393
was:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
## DROOLS-2392
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
# Invoke menu when multiple cells selected (x)
##
> Decision Table editor
> ---------------------
>
> Key: DROOLS-2301
> URL: https://issues.jboss.org/browse/DROOLS-2301
> Project: Drools
> Issue Type: Sub-task
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
>
> h1. Refactoring for "Decision Table" editor
> h2. Acceptance criteria:
> # Set table orientation (/)
> ## This should not be affected by the change of hit policy or table data
> # Change hit policy (/)
> ## Change should be visible in most left upper cell
> ## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
> # Clear decision table context entry clicking to any header cell (/)
> # Add rule (/)
> ## Above
> ### Clicking to existing row number
> ### Clicking to existing cell
> ## Below
> ### Clicking to existing row number
> ### Clicking to existing cell
> # Add input
> ## Before
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> ## After
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> # Add output
> ## Before
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> ## After
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> # Remove
> ## Input
> ## Output
> ## Rule
> # Output clauses should be collapsed to one name
> # Reorder
> ## Inputs separately
> ## Outputs separately
> ## inputs with outputs and vice versa shouldn't be allowed
> ## Description column should be prevented
> ## Rows of table
> # Change column width
> ## Input
> ## Output
> ## Description
> # Rename any input clause
> # Rename any output clause
> # Undo or Redo anything from this list (x)
> ## DROOLS-2392
> # Save and reopen in any moment
> # Use table as not most upper left context entry of decision
> # Invoke menu when multiple cells selected (x)
> ## DROOLS-2393
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (DROOLS-2392) [DMN Designer] Undo and Redo AddRuleCommand does not update user interface
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2392?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-2392:
----------------------------------------
Nice find [~jomarko] :-)
This is not caused by DROOLS-2301 but by the fourth undo going back to the "graph" screen.
When the first redo is executed and the User navigated back to the "grid" screen the widget is re-created with a new "UI model" that differs to that associated with the original commands. When the second (and third and fourth) redo is executed the rows are added back to the original "UI model" associated with the command and not the new model associated with the widget.
This JIRA affects ALL commands when the User navigates back to the "graph" screen.
> [DMN Designer] Undo and Redo AddRuleCommand does not update user interface
> --------------------------------------------------------------------------
>
> Key: DROOLS-2392
> URL: https://issues.jboss.org/browse/DROOLS-2392
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Attachments: Screenshot from 2018-03-16 10-38-41.png
>
>
> Undo and consequent Redo of AddDecisionRule command for non trivial scenarios does not update user interface correctly.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (DROOLS-2393) [DMN Designer] Not expected results of commands when multiple cells selected
by Jozef Marko (JIRA)
Jozef Marko created DROOLS-2393:
-----------------------------------
Summary: [DMN Designer] Not expected results of commands when multiple cells selected
Key: DROOLS-2393
URL: https://issues.jboss.org/browse/DROOLS-2393
Project: Drools
Issue Type: Bug
Components: DMN Editor
Affects Versions: 7.7.0.Final
Reporter: Jozef Marko
Assignee: Michael Anstis
Priority: Minor
When multiple cells of the decision table are selected, then the behavior of inline context menu can be confusing for the user.
Few scenarios:
# Select multiple cells, invoke context menu, select delete rule -> just one deleted
# Select multiple cells from different columns, invoke context menu, select delete -> just one column deleted
# Select both input and output cells, context menu entries are established according to the last click
# Select continuous block of cells, invoke context menu, selec insert rule below -> rule is not inserted below the most bottom cell of the block
# ...
Due to this, we should disable the context menu entries which could bring confusion for cases when multiple cells are selected
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (DROOLS-2301) Decision Table editor
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2301?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2301:
--------------------------------
Description:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
## DROOLS-2392
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
# Invoke menu when multiple cells selected (x)
##
was:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
## DROOLS-2392
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
> Decision Table editor
> ---------------------
>
> Key: DROOLS-2301
> URL: https://issues.jboss.org/browse/DROOLS-2301
> Project: Drools
> Issue Type: Sub-task
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
>
> h1. Refactoring for "Decision Table" editor
> h2. Acceptance criteria:
> # Set table orientation (/)
> ## This should not be affected by the change of hit policy or table data
> # Change hit policy (/)
> ## Change should be visible in most left upper cell
> ## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
> # Clear decision table context entry clicking to any header cell (/)
> # Add rule (/)
> ## Above
> ### Clicking to existing row number
> ### Clicking to existing cell
> ## Below
> ### Clicking to existing row number
> ### Clicking to existing cell
> # Add input
> ## Before
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> ## After
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> # Add output
> ## Before
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> ## After
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> # Remove
> ## Input
> ## Output
> ## Rule
> # Output clauses should be collapsed to one name
> # Reorder
> ## Inputs separately
> ## Outputs separately
> ## inputs with outputs and vice versa shouldn't be allowed
> ## Description column should be prevented
> ## Rows of table
> # Change column width
> ## Input
> ## Output
> ## Description
> # Rename any input clause
> # Rename any output clause
> # Undo or Redo anything from this list (x)
> ## DROOLS-2392
> # Save and reopen in any moment
> # Use table as not most upper left context entry of decision
> # Invoke menu when multiple cells selected (x)
> ##
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (DROOLS-2301) Decision Table editor
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2301?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2301:
--------------------------------
Description:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
## DROOLS-2392
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
was:
h1. Refactoring for "Decision Table" editor
h2. Acceptance criteria:
# Set table orientation (/)
## This should not be affected by the change of hit policy or table data
# Change hit policy (/)
## Change should be visible in most left upper cell
## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
# Clear decision table context entry clicking to any header cell (/)
# Add rule (/)
## Above
### Clicking to existing row number
### Clicking to existing cell
## Below
### Clicking to existing row number
### Clicking to existing cell
# Add input
## Before
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
## After
### Clicking to existing input
### Clicking to existing output shouldn't allow to add input
# Add output
## Before
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
## After
### Clicking to existing output
### Clicking to existing input shouldn't allow to add output
# Remove
## Input
## Output
## Rule
# Output clauses should be collapsed to one name
# Reorder
## Inputs separately
## Outputs separately
## inputs with outputs and vice versa shouldn't be allowed
## Description column should be prevented
## Rows of table
# Change column width
## Input
## Output
## Description
# Rename any input clause
# Rename any output clause
# Undo or Redo anything from this list (x)
##
# Save and reopen in any moment
# Use table as not most upper left context entry of decision
> Decision Table editor
> ---------------------
>
> Key: DROOLS-2301
> URL: https://issues.jboss.org/browse/DROOLS-2301
> Project: Drools
> Issue Type: Sub-task
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
>
> h1. Refactoring for "Decision Table" editor
> h2. Acceptance criteria:
> # Set table orientation (/)
> ## This should not be affected by the change of hit policy or table data
> # Change hit policy (/)
> ## Change should be visible in most left upper cell
> ## If {{COLLECT <function>}} was selected, then hit policy changed and then again {{COLLECT}} selected, then {{<function>}} should be same as previously
> # Clear decision table context entry clicking to any header cell (/)
> # Add rule (/)
> ## Above
> ### Clicking to existing row number
> ### Clicking to existing cell
> ## Below
> ### Clicking to existing row number
> ### Clicking to existing cell
> # Add input
> ## Before
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> ## After
> ### Clicking to existing input
> ### Clicking to existing output shouldn't allow to add input
> # Add output
> ## Before
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> ## After
> ### Clicking to existing output
> ### Clicking to existing input shouldn't allow to add output
> # Remove
> ## Input
> ## Output
> ## Rule
> # Output clauses should be collapsed to one name
> # Reorder
> ## Inputs separately
> ## Outputs separately
> ## inputs with outputs and vice versa shouldn't be allowed
> ## Description column should be prevented
> ## Rows of table
> # Change column width
> ## Input
> ## Output
> ## Description
> # Rename any input clause
> # Rename any output clause
> # Undo or Redo anything from this list (x)
> ## DROOLS-2392
> # Save and reopen in any moment
> # Use table as not most upper left context entry of decision
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months