April 2018 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-2465) [DMN Editor] Decision Navigator dock: Optimize the `ExpressionEditorChanged` event

by Guilherme Carreiro (JIRA)

Guilherme Carreiro created DROOLS-2465: ------------------------------------------ Summary: [DMN Editor] Decision Navigator dock: Optimize the `ExpressionEditorChanged` event Key: DROOLS-2465 URL: https://issues.jboss.org/browse/DROOLS-2465 Project: Drools Issue Type: Enhancement Reporter: Guilherme Carreiro Assignee: Guilherme Carreiro Priority: Minor The `ExpressionEditorChanged` it's being fired many times. Check the scenario: When the `DMNGridLayer.select(GridWidget)` method is called, it calls `BaseGridWidget.select()`. This will trigger the `ExpressionEditorChanged` X times, where X is the number of grids on the layer. This is not optimal. Check the same problem in the `deselect` method. See more [here|https://github.com/kiegroup/kie-wb-common/pull/1542#discussion_r1801...]. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2464) [DMN Editor] Decision Navigator dock: the arrows clickable should be clickable

by Guilherme Carreiro (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2464?page=com.atlassian.jira.plugi... ] Guilherme Carreiro updated DROOLS-2464: --------------------------------------- Priority: Minor (was: Major) > [DMN Editor] Decision Navigator dock: the arrows clickable should be clickable > ------------------------------------------------------------------------------ > > Key: DROOLS-2464 > URL: https://issues.jboss.org/browse/DROOLS-2464 > Project: Drools > Issue Type: Enhancement > Reporter: Guilherme Carreiro > Assignee: Guilherme Carreiro > Priority: Minor > > Only the node's icons are clickable, and the arrows should be clickable too. > See more [here|https://github.com/kiegroup/kie-wb-common/pull/1542#issuecomment-379...]. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2464) [DMN Editor] Decision Navigator dock: the arrows clickable should be clickable

by Guilherme Carreiro (JIRA)

Guilherme Carreiro created DROOLS-2464: ------------------------------------------ Summary: [DMN Editor] Decision Navigator dock: the arrows clickable should be clickable Key: DROOLS-2464 URL: https://issues.jboss.org/browse/DROOLS-2464 Project: Drools Issue Type: Enhancement Reporter: Guilherme Carreiro Assignee: Guilherme Carreiro Only the node's icons are clickable, and the arrows should be clickable too. See more [here|https://github.com/kiegroup/kie-wb-common/pull/1542#issuecomment-379...]. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2458) [DMN Designer] Error while removing connected decision

by Michael Anstis (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2458?page=com.atlassian.jira.plugi... ] Michael Anstis edited comment on DROOLS-2458 at 4/9/18 11:04 AM: ----------------------------------------------------------------- Stack trace is this:- {code} LgI_g$ (FormPropertiesWidget.java:150) TgI_g$ (FormPropertiesWidget.java:79) vhI_g$ (FormsCanvasSessionHandler.java:213) uhI_g$ (FormsCanvasSessionHandler.java:205) giI_g$ (FormsCanvasSessionHandler.java:256) TVF_g$ (AbstractCanvasHandler.java:363) qeG_g$ (DeleteCanvasConnectorCommand.java:51) <-- context.notifyCanvasElementUpdated(target) -- see below. peG_g$ (DeleteCanvasConnectorCommand.java:40) ... {code} The {{DeleteCanvasConnectorCommand}} above looks like this:- {code} public class DeleteCanvasConnectorCommand extends AbstractCanvasCommand { ... @Override public CommandResult<CanvasViolation> execute(final AbstractCanvasHandler context) { if (!checkShapeNotNull(context, candidate.getUUID())) { //it is already not present on canvas return buildResult(); } context.deregister(candidate); if (null != source) { context.notifyCanvasElementUpdated(source); } if (null != target) { context.notifyCanvasElementUpdated(target); <-- BUT target has been deleted. } return buildResult(); } {code} The applicable part of {{FormPropertiesWidget}} is:- {code} public class FormPropertiesWidget implements IsElement, FormPropertiesWidgetView.Presenter { ... private void show(final String graphUuid, final Element<? extends Definition<?>> element, final Command callback) { final String uuid = element.getUUID(); <-- element is null here. {code} So the issue is that the Properties Panel is trying to be updated for a non-existence node. was (Author: manstis): Stack trace is this:- {code} LgI_g$ (FormPropertiesWidget.java:150) TgI_g$ (FormPropertiesWidget.java:79) vhI_g$ (FormsCanvasSessionHandler.java:213) uhI_g$ (FormsCanvasSessionHandler.java:205) giI_g$ (FormsCanvasSessionHandler.java:256) TVF_g$ (AbstractCanvasHandler.java:363) qeG_g$ (DeleteCanvasConnectorCommand.java:51) <-- context.notifyCanvasElementUpdated(target) -- see below. peG_g$ (DeleteCanvasConnectorCommand.java:40) ... {code} The {{DeleteCanvasConnectorCommand}} above looks like this:- {code} public class DeleteCanvasConnectorCommand extends AbstractCanvasCommand { ... @Override public CommandResult<CanvasViolation> execute(final AbstractCanvasHandler context) { if (!checkShapeNotNull(context, candidate.getUUID())) { //it is already not present on canvas return buildResult(); } context.deregister(candidate); if (null != source) { context.notifyCanvasElementUpdated(source); } if (null != target) { context.notifyCanvasElementUpdated(target); <-- BUT target has been deleted. } return buildResult(); } {code} So the issue is that the Properties Panel is trying to be updated for a non-existence node. > [DMN Designer] Error while removing connected decision > ------------------------------------------------------ > > Key: DROOLS-2458 > URL: https://issues.jboss.org/browse/DROOLS-2458 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.8.0.Final > Reporter: Jozef Marko > Assignee: Roger Martínez > Priority: Critical > Fix For: 7.8.0.Final > > Attachments: Screenshot from 2018-04-06 14-41-28.png, Screenshot from 2018-04-06 14-42-45.png > > > If there are connected decisions, user is unable to delete them. Issue was found during JBPM-6777 review, however probably there is no relation. > h2. Acceptance test > Prepare DRG diagram with all combinations of connections, be sure all node types used, try to delete each node type in situation it is either source or target of connection. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2458) [DMN Designer] Error while removing connected decision

by Michael Anstis (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2458?page=com.atlassian.jira.plugi... ] Michael Anstis commented on DROOLS-2458: ---------------------------------------- [~roger600] [~jomarko] found this interesting issue (that I'd expect to affect BPMN2, DMN and CM and would be surprised has not been found already). When a User deletes one of two nodes linked together by a connector; an attempt is made to update the Properties (Form) Panel for the deleted node. IDK if you want to consider changing the command or asking [~pere.fernandez] to provide some default behaviour on Forms? > [DMN Designer] Error while removing connected decision > ------------------------------------------------------ > > Key: DROOLS-2458 > URL: https://issues.jboss.org/browse/DROOLS-2458 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.8.0.Final > Reporter: Jozef Marko > Assignee: Roger Martínez > Priority: Critical > Fix For: 7.8.0.Final > > Attachments: Screenshot from 2018-04-06 14-41-28.png, Screenshot from 2018-04-06 14-42-45.png > > > If there are connected decisions, user is unable to delete them. Issue was found during JBPM-6777 review, however probably there is no relation. > h2. Acceptance test > Prepare DRG diagram with all combinations of connections, be sure all node types used, try to delete each node type in situation it is either source or target of connection. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2458) [DMN Designer] Error while removing connected decision

by Michael Anstis (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2458?page=com.atlassian.jira.plugi... ] Michael Anstis reassigned DROOLS-2458: -------------------------------------- Assignee: Roger Martínez (was: Michael Anstis) > [DMN Designer] Error while removing connected decision > ------------------------------------------------------ > > Key: DROOLS-2458 > URL: https://issues.jboss.org/browse/DROOLS-2458 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.8.0.Final > Reporter: Jozef Marko > Assignee: Roger Martínez > Priority: Critical > Fix For: 7.8.0.Final > > Attachments: Screenshot from 2018-04-06 14-41-28.png, Screenshot from 2018-04-06 14-42-45.png > > > If there are connected decisions, user is unable to delete them. Issue was found during JBPM-6777 review, however probably there is no relation. > h2. Acceptance test > Prepare DRG diagram with all combinations of connections, be sure all node types used, try to delete each node type in situation it is either source or target of connection. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2458) [DMN Designer] Error while removing connected decision

by Michael Anstis (JIRA)

[ https://issues.jboss.org/browse/DROOLS-2458?page=com.atlassian.jira.plugi... ] Michael Anstis commented on DROOLS-2458: ---------------------------------------- Stack trace is this:- {code} LgI_g$ (FormPropertiesWidget.java:150) TgI_g$ (FormPropertiesWidget.java:79) vhI_g$ (FormsCanvasSessionHandler.java:213) uhI_g$ (FormsCanvasSessionHandler.java:205) giI_g$ (FormsCanvasSessionHandler.java:256) TVF_g$ (AbstractCanvasHandler.java:363) qeG_g$ (DeleteCanvasConnectorCommand.java:51) <-- context.notifyCanvasElementUpdated(target) -- see below. peG_g$ (DeleteCanvasConnectorCommand.java:40) ... {code} The {{DeleteCanvasConnectorCommand}} above looks like this:- {code} public class DeleteCanvasConnectorCommand extends AbstractCanvasCommand { ... @Override public CommandResult<CanvasViolation> execute(final AbstractCanvasHandler context) { if (!checkShapeNotNull(context, candidate.getUUID())) { //it is already not present on canvas return buildResult(); } context.deregister(candidate); if (null != source) { context.notifyCanvasElementUpdated(source); } if (null != target) { context.notifyCanvasElementUpdated(target); <-- BUT target has been deleted. } return buildResult(); } {code} So the issue is that the Properties Panel is trying to be updated for a non-existence node. > [DMN Designer] Error while removing connected decision > ------------------------------------------------------ > > Key: DROOLS-2458 > URL: https://issues.jboss.org/browse/DROOLS-2458 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.8.0.Final > Reporter: Jozef Marko > Assignee: Michael Anstis > Priority: Critical > Fix For: 7.8.0.Final > > Attachments: Screenshot from 2018-04-06 14-41-28.png, Screenshot from 2018-04-06 14-42-45.png > > > If there are connected decisions, user is unable to delete them. Issue was found during JBPM-6777 review, however probably there is no relation. > h2. Acceptance test > Prepare DRG diagram with all combinations of connections, be sure all node types used, try to delete each node type in situation it is either source or target of connection. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2463) CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException)

by Martin Cimbalek (JIRA)

Martin Cimbalek created DROOLS-2463: --------------------------------------- Summary: CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException) Key: DROOLS-2463 URL: https://issues.jboss.org/browse/DROOLS-2463 Project: Drools Issue Type: Bug Components: integration Affects Versions: 7.7.0.Final Environment: RHEL 7.4 || Fedora 27 IBM Java 1.8 ibm-java-x86_64-sdk-8.0.5.10 Reporter: Martin Cimbalek Assignee: Mario Fusco {{org.kie.camel.embedded.camel.component.CamelEndpointWith*}} tests fail with {{org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing}} with IBM JAVA 1.8 (ibm-java-x86_64-sdk-8.0.5.10) +List of tests failing:+ * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.testWorkingSetGlobalTestSessionSetAndGetGlobal * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testQuery * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcess * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testInsertElements * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionInsert * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcessInstanceSignalEvent * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionGetObject * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionRetractObject * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbXSDModelTest.testSessionInsert +Stacktrace (similar for other tests in fail):+ java.lang.IllegalStateException: org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing at javax.xml.validation.SchemaFactory.setFeature(Unknown Source) at com.sun.xml.bind.v2.util.XmlFactory.createSchemaFactory(XmlFactory.java:102) at com.sun.tools.xjc.reader.xmlschema.parser.SchemaConstraintChecker.check(SchemaConstraintChecker.java:86) at com.sun.tools.xjc.ModelLoader.loadXMLSchema(ModelLoader.java:360) at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:174) at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:119) at org.drools.compiler.runtime.pipeline.impl.DroolsJaxbHelperProviderImpl.addXsdModel(DroolsJaxbHelperProviderImpl.java:121) at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromXSD(KnowledgeBuilderImpl.java:918) at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder.lambda$static$2(CompositeKnowledgeBuilderImpl.java:283) at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder$$Lambda$21.000000002566C640.build(Unknown Source) at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResourceType(CompositeKnowledgeBuilderImpl.java:131) at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResources(CompositeKnowledgeBuilderImpl.java:121) at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.build(CompositeKnowledgeBuilderImpl.java:98) at org.drools.compiler.kie.builder.impl.AbstractKieProject.buildKnowledgePackages(AbstractKieProject.java:247) at org.drools.compiler.kie.builder.impl.AbstractKieProject.verify(AbstractKieProject.java:74) at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildKieProject(KieBuilderImpl.java:353) at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:265) at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:209) at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.registerKnowledgeRuntime(CamelEndpointWithJaxWrapperCollectionTest.java:139) at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.configureDroolsContext(CamelEndpointWithJaxWrapperCollectionTest.java:112) -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (WFLY-9521) Marshalling of org.wildfly.clustering.group.Node implementations is suboptimal

by Paul Ferraro (JIRA)

[ https://issues.jboss.org/browse/WFLY-9521?page=com.atlassian.jira.plugin.... ] Paul Ferraro updated WFLY-9521: ------------------------------- Summary: Marshalling of org.wildfly.clustering.group.Node implementations is suboptimal (was: Optimize marshalling of org.wildfly.clustering.group.Node implementations) > Marshalling of org.wildfly.clustering.group.Node implementations is suboptimal > ------------------------------------------------------------------------------ > > Key: WFLY-9521 > URL: https://issues.jboss.org/browse/WFLY-9521 > Project: WildFly > Issue Type: Bug > Components: Clustering > Affects Versions: 11.0.0.Final > Reporter: Paul Ferraro > Assignee: Paul Ferraro > > The Node implementations currently serialize: > * org.jgroups.Address > * The logical name (typically a host name) > * The socket binding address/port of its transport > This is overkill. The Node should only need to serialize enough information to reconstruct itself using a NodeFactory<Address>, which should only include: > * its Address > * something to minimally identify the NodeFactory<Address>, with which to use to reconstruct the Node, e.g. a group name -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

[JBoss JIRA] (WFLY-9521) Optimize marshalling of org.wildfly.clustering.group.Node implementations

by Paul Ferraro (JIRA)

[ https://issues.jboss.org/browse/WFLY-9521?page=com.atlassian.jira.plugin.... ] Paul Ferraro updated WFLY-9521: ------------------------------- Issue Type: Bug (was: Enhancement) > Optimize marshalling of org.wildfly.clustering.group.Node implementations > ------------------------------------------------------------------------- > > Key: WFLY-9521 > URL: https://issues.jboss.org/browse/WFLY-9521 > Project: WildFly > Issue Type: Bug > Components: Clustering > Affects Versions: 11.0.0.Final > Reporter: Paul Ferraro > Assignee: Paul Ferraro > > The Node implementations currently serialize: > * org.jgroups.Address > * The logical name (typically a host name) > * The socket binding address/port of its transport > This is overkill. The Node should only need to serialize enough information to reconstruct itself using a NodeFactory<Address>, which should only include: > * its Address > * something to minimally identify the NodeFactory<Address>, with which to use to reconstruct the Node, e.g. a group name -- This message was sent by Atlassian JIRA (v7.5.0#75005)

8 years, 3 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira April 2018