[JBoss JIRA] (WFLY-10615) Duplicate layer 'base' in integration/elytron testsuite
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-10615?page=com.atlassian.jira.plugin... ]
Jan Kalina commented on WFLY-10615:
-----------------------------------
The unwanted module.path is added because of {{addModuleDirs}} instead of {{setModuleDirs}} (which is probably more appropriate here) - following change is sufficient to fix issue above:
{code}
--- a/container-managed/src/main/java/org/jboss/as/arquillian/container/managed/ManagedDeployableContainer.java
+++ b/container-managed/src/main/java/org/jboss/as/arquillian/container/managed/ManagedDeployableContainer.java
@@ -87,7 +87,7 @@ public final class ManagedDeployableContainer extends CommonDeployableContainer<
String modulesPath = config.getModulePath();
if (modulesPath != null && !modulesPath.isEmpty()) {
- commandBuilder.addModuleDirs(modulesPath.split(Pattern.quote(File.pathSeparator)));
+ commandBuilder.setModuleDirs(modulesPath.split(Pattern.quote(File.pathSeparator)));
}
{code}
Will have to check whether it will not break some wildfly tests when will be time to run them all.
> Duplicate layer 'base' in integration/elytron testsuite
> -------------------------------------------------------
>
> Key: WFLY-10615
> URL: https://issues.jboss.org/browse/WFLY-10615
> Project: WildFly
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 13.0.0.Final
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Minor
>
> Testsuite wildfly/testsuite/integration/elytron has workarounded module path problem:
> {code}
> MSC000001: Failed to start service jboss.patching.manager: org.jboss.msc.service.StartException in service jboss.patching.manager: java.lang.IllegalStateException: Duplicate layer 'base'
> at org.jboss.as.patching.installation.InstallationManagerService.start(InstallationManagerService.java:106)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1736)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1698)
> at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1556)
> at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1378)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.IllegalStateException: Duplicate layer 'base'
> at org.jboss.as.patching.installation.LayersFactory$ProcessedLayers.addLayer(LayersFactory.java:305)
> at org.jboss.as.patching.installation.LayersFactory.processRoot(LayersFactory.java:182)
> at org.jboss.as.patching.installation.LayersFactory.process(LayersFactory.java:127)
> at org.jboss.as.patching.installation.LayersFactory.load(LayersFactory.java:86)
> at org.jboss.as.patching.installation.InstallationManagerImpl.<init>(InstallationManagerImpl.java:47)
> at org.jboss.as.patching.installation.InstallationManager.load(InstallationManager.java:185)
> at org.jboss.as.patching.installation.InstallationManagerService.load(InstallationManagerService.java:128)
> at org.jboss.as.patching.installation.InstallationManagerService.start(InstallationManagerService.java:63)
> ... 8 more
> {code}
> This is currently workarounded using following in pom.xml:
> {code}
> <!-- let's override the module.path parent configuration with dummy value, to avoid the "IllegalStateException: Duplicate layer 'base'" -->
> <module.path>foo</module.path>
> {code}
> But this prevent using `org.jboss.as.test.module.util.TestModule`, as it try to put created module into "foo", which fails - adding tests using custom modules requires removing this workaround.
> The reason is {{target/wildfly/modules}} is twice in {{module.path}} system property (when in InstallationManagerService):
> {code}
> /home/jkalina/work/wildfly/testsuite/integration/elytron/target/wildfly/modules:
> /home/jkalina/work/wildfly/testsuite/integration/elytron/target/wildfly/modules:
> /home/jkalina/work/wildfly/testsuite/integration/elytron/target/modules
> {code}
> Note: when reading {{module.path}} from the test (regardless RunAsClient is used or not), the value is correct:
> {code}
> /home/jkalina/work/wildfly/testsuite/integration/elytron/target/wildfly/modules:
> /home/jkalina/work/wildfly/testsuite/integration/elytron/target/modules
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (WFLY-10520) Add Hibernate ORM 5.3 compatibility transformer
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFLY-10520?page=com.atlassian.jira.plugin... ]
David Lloyd commented on WFLY-10520:
------------------------------------
An INFO or WARNING might be appropriate to log one time (maybe use {{\@Once}}) that the transformer is in use. The individual classes should definitely not be logging above DEBUG.
> Add Hibernate ORM 5.3 compatibility transformer
> -----------------------------------------------
>
> Key: WFLY-10520
> URL: https://issues.jboss.org/browse/WFLY-10520
> Project: WildFly
> Issue Type: Task
> Components: JPA / Hibernate
> Reporter: Gail Badner
> Assignee: Scott Marlow
> Fix For: 14.0.0.CR1
>
>
> A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods that are no longer compatible with 5.1.
> From https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-w...
> # Change call to org.hibernate.BasicQueryContract.getFlushMode() to instead call BasicQueryContract.getHibernateFlushMode().
> # Change call to org.hibernate.Session.getFlushMode, to instead call Session.getHibernateFlushMode()
> # Modify calls to org.hibernate.Query.getFirstResult() to convert returned int, to Integer result.
> # Modify calls to org.hibernate.Query.getMaxResults() to convert returned int, to Integer result, if returned int value is <= 0, null should be used, if Integer.MAX_VALUE is, the transformer should replace with null reference.
> # App References to Enum org.hibernate.FlushMode.NEVER (0) should be transformed to reference FlushMode.MANUAL (0) instead.
> # For call to org.hibernate.Query.setMaxResults(int), instead call org.hibernate.Query.setHibernateMaxResults(int) which will be added soon to ORM 5.3.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (LOGMGR-195) Create an SPI to allow sockets for the SocketHandler to be managed by the consumer
by James Perkins (JIRA)
James Perkins created LOGMGR-195:
------------------------------------
Summary: Create an SPI to allow sockets for the SocketHandler to be managed by the consumer
Key: LOGMGR-195
URL: https://issues.jboss.org/browse/LOGMGR-195
Project: JBoss Log Manager
Issue Type: Enhancement
Reporter: James Perkins
Assignee: James Perkins
Currently the {{SocketHandler}} allows a {{SocketFactory}} to be set to create TCP sockets. However UDP sockets are always created via {{new DatagramSocket()}}. In some cases, like WildFly Core, there may be a desire to allow the consumer to manage the creation of sockets.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (WFLY-10288) Remove ee8.preview.mode support
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFLY-10288?page=com.atlassian.jira.plugin... ]
James Perkins updated WFLY-10288:
---------------------------------
Description:
Once Java EE 8 compliant we need to remove the support for the {{ee8.preview.mode}} system property.
The following modules will need to be updated:
* {{javax.enterprise.api}}
* {{javax.validation.api}}
* -{{javax.json.bind.api}}-
* -{{javax.json.api}}-
* {{javax.annotation.api}}
* {{javax.servlet.api}}
* {{org.wildfly.bridge.servlet-api-bridge}} (needs to be removed)
* -{{org.eclipse.yasson}}-
* -{{org.glassfish.javax.json}}-
* {{javax.persistence.api}}
* {{javax.ws.rs.api}}
* {{javax.faces.api}}
* {{javax.mail.api}}
* {{javax.xml.bind.api}}
* {{org.wildfly.cdi-api-bridge}}
* {{org.jboss.resteasy.resteasy-json-binding-provider}}
* {{org.jboss.resteasy.resteasy-jaxrs}}
* {{org.hibernate.validator}}
* {{org.hibernate.validator.cdi}}
* {{org.hibernate}}
* {{com.sun.jsf-impl}}
The following configuration needs to be removed:
* {{./feature-pack/src/main/resources/configuration/standalone/template-ee8.xml}}
The Hibernate Search modules are currently duplicated:
* {{org.hibernate.search.*}} using "main" slot should be removed
* {{org.hibernate.search.*}} using "5.10" slot should be promoted to main
* Update usage of constants {{org.jboss.as.jpa.config.Configuration#PROVIDER_MODULE_HIBERNATE_SEARCH_EE8}}, PROVIDER_MODULE_HIBERNATE_SEARCH_EE7
The following source files should be updated:
* {{org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService.java}}
* {{org.wildfly.extension.undertow.deployment.WarMetaDataProcessor.java}}
Any solution for WFLY-10289 should be reverted.
The following documentation needs to be updated:
* {{./docs/src/main/asciidoc/Getting_Started_Guide.adoc}}
was:
Once Java EE 8 compliant we need to remove the support for the {{ee8.preview.mode}} system property.
The following modules will need to be updated:
* {{javax.enterprise.api}}
* {{javax.validation.api}}
* -{{javax.json.bind.api}}-
* -{{javax.json.api}}-
* {{javax.annotation.api}}
* {{javax.servlet.api}}
* {{org.wildfly.bridge.servlet-api-bridge}} (needs to be removed)
* {{org.eclipse.yasson}}
* {{org.glassfish.javax.json}}
* {{javax.persistence.api}}
* {{javax.ws.rs.api}}
* {{javax.faces.api}}
* {{javax.mail.api}}
* {{javax.xml.bind.api}}
* {{org.wildfly.cdi-api-bridge}}
* {{org.jboss.resteasy.resteasy-json-binding-provider}}
* {{org.jboss.resteasy.resteasy-jaxrs}}
* {{org.hibernate.validator}}
* {{org.hibernate.validator.cdi}}
* {{org.hibernate}}
* {{com.sun.jsf-impl}}
The following configuration needs to be removed:
* {{./feature-pack/src/main/resources/configuration/standalone/template-ee8.xml}}
The Hibernate Search modules are currently duplicated:
* {{org.hibernate.search.*}} using "main" slot should be removed
* {{org.hibernate.search.*}} using "5.10" slot should be promoted to main
* Update usage of constants {{org.jboss.as.jpa.config.Configuration#PROVIDER_MODULE_HIBERNATE_SEARCH_EE8}}, PROVIDER_MODULE_HIBERNATE_SEARCH_EE7
The following source files should be updated:
* {{org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService.java}}
* {{org.wildfly.extension.undertow.deployment.WarMetaDataProcessor.java}}
Any solution for WFLY-10289 should be reverted.
The following documentation needs to be updated:
* {{./docs/src/main/asciidoc/Getting_Started_Guide.adoc}}
> Remove ee8.preview.mode support
> -------------------------------
>
> Key: WFLY-10288
> URL: https://issues.jboss.org/browse/WFLY-10288
> Project: WildFly
> Issue Type: Sub-task
> Components: EE
> Reporter: James Perkins
>
> Once Java EE 8 compliant we need to remove the support for the {{ee8.preview.mode}} system property.
> The following modules will need to be updated:
> * {{javax.enterprise.api}}
> * {{javax.validation.api}}
> * -{{javax.json.bind.api}}-
> * -{{javax.json.api}}-
> * {{javax.annotation.api}}
> * {{javax.servlet.api}}
> * {{org.wildfly.bridge.servlet-api-bridge}} (needs to be removed)
> * -{{org.eclipse.yasson}}-
> * -{{org.glassfish.javax.json}}-
> * {{javax.persistence.api}}
> * {{javax.ws.rs.api}}
> * {{javax.faces.api}}
> * {{javax.mail.api}}
> * {{javax.xml.bind.api}}
> * {{org.wildfly.cdi-api-bridge}}
> * {{org.jboss.resteasy.resteasy-json-binding-provider}}
> * {{org.jboss.resteasy.resteasy-jaxrs}}
> * {{org.hibernate.validator}}
> * {{org.hibernate.validator.cdi}}
> * {{org.hibernate}}
> * {{com.sun.jsf-impl}}
> The following configuration needs to be removed:
> * {{./feature-pack/src/main/resources/configuration/standalone/template-ee8.xml}}
> The Hibernate Search modules are currently duplicated:
> * {{org.hibernate.search.*}} using "main" slot should be removed
> * {{org.hibernate.search.*}} using "5.10" slot should be promoted to main
> * Update usage of constants {{org.jboss.as.jpa.config.Configuration#PROVIDER_MODULE_HIBERNATE_SEARCH_EE8}}, PROVIDER_MODULE_HIBERNATE_SEARCH_EE7
> The following source files should be updated:
> * {{org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService.java}}
> * {{org.wildfly.extension.undertow.deployment.WarMetaDataProcessor.java}}
> Any solution for WFLY-10289 should be reverted.
> The following documentation needs to be updated:
> * {{./docs/src/main/asciidoc/Getting_Started_Guide.adoc}}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years