[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener
by Jan Stourac (JIRA)
[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ]
Jan Stourac commented on WFLY-11066:
------------------------------------
I've just checked that tests prepared for WFLY-11065 successfully passed when your fix is incorporated. I am gonna mark this jira as a duplicate of WFLY-11065 as that one has already JBEAP clone and also to have it all tracked on one place. Thanks! :)
> Incorrect >= 3.1 conditional in JspInitializationListener
> ---------------------------------------------------------
>
> Key: WFLY-11066
> URL: https://issues.jboss.org/browse/WFLY-11066
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Reporter: Peter Palaga
> Assignee: Peter Palaga
>
> In {{JspInitializationListener}} there is a comment saying
> {quote}
> if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.*
> {quote}
> However the conditional following the comment is not testing for "3.1 or higher":
> {code}
> if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) {
> {code}
> note that e.g. for 4.0 the expression is false
> To include 4.0, the expression should be something like
> {code}
> if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) {
> {code}
> [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener
by Jan Stourac (JIRA)
[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ]
Jan Stourac closed WFLY-11066.
------------------------------
Resolution: Duplicate Issue
> Incorrect >= 3.1 conditional in JspInitializationListener
> ---------------------------------------------------------
>
> Key: WFLY-11066
> URL: https://issues.jboss.org/browse/WFLY-11066
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Reporter: Peter Palaga
> Assignee: Peter Palaga
>
> In {{JspInitializationListener}} there is a comment saying
> {quote}
> if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.*
> {quote}
> However the conditional following the comment is not testing for "3.1 or higher":
> {code}
> if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) {
> {code}
> note that e.g. for 4.0 the expression is false
> To include 4.0, the expression should be something like
> {code}
> if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) {
> {code}
> [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-3034) Add possibility to import a cucumber feature file
by Daniele Zonca (JIRA)
Daniele Zonca created DROOLS-3034:
-------------------------------------
Summary: Add possibility to import a cucumber feature file
Key: DROOLS-3034
URL: https://issues.jboss.org/browse/DROOLS-3034
Project: Drools
Issue Type: Story
Components: Scenario Simulation and Testing
Reporter: Daniele Zonca
Assignee: Daniele Zonca
As user I would like to have the possibility to import an existing Cucumber feature file to create a test scenario
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener
by Peter Palaga (JIRA)
[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ]
Peter Palaga commented on WFLY-11066:
-------------------------------------
[~jstourac] what an accident! I found the issue when I browsed the code for other reasons. I have not attempted to assemble a reproducer. Yeah, it looks like the PR linked here could be a solution for WFLY-11065 :)
> Incorrect >= 3.1 conditional in JspInitializationListener
> ---------------------------------------------------------
>
> Key: WFLY-11066
> URL: https://issues.jboss.org/browse/WFLY-11066
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Reporter: Peter Palaga
> Assignee: Peter Palaga
>
> In {{JspInitializationListener}} there is a comment saying
> {quote}
> if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.*
> {quote}
> However the conditional following the comment is not testing for "3.1 or higher":
> {code}
> if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) {
> {code}
> note that e.g. for 4.0 the expression is false
> To include 4.0, the expression should be something like
> {code}
> if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) {
> {code}
> [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JGRP-2294) ForkProtocolStack ignores UnknownForkHandler for message batches
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2294?page=com.atlassian.jira.plugin.... ]
Bela Ban resolved JGRP-2294.
----------------------------
Resolution: Done
> ForkProtocolStack ignores UnknownForkHandler for message batches
> ----------------------------------------------------------------
>
> Key: JGRP-2294
> URL: https://issues.jboss.org/browse/JGRP-2294
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.13
> Reporter: Dan Berindei
> Assignee: Bela Ban
> Fix For: 4.0.15
>
>
> {{ForkProtocolStack.up(MessageBatch)}} discards messages if it doesn't the fork channel id isn't registered and they are part of a batch:
> {code:java}
> log.debug("fork-channel for id=%s not found; discarding message", fork_channel_id);
> {code}
> -I believe the check should also be enhanced to invoke the {{UnknownForkHandler}} if the {{ForkChannel}} is registered but is not yet connected. Otherwise messages that arrive after the {{ForkChannel}} registers itself in the constructor and before our {{JGroupsTransport}} registers itself as an {{UpHandler}} with the {{ForkChannel}} will also be discarded.-
> I misread the {{ForkChannel}} code, the registratioon in the {{ForkProtocolStack}} only happens in {{ForkChannel.connect()}}.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months