September 2018 - jboss-jira - Jboss List Archives

[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener

by Jan Stourac (JIRA)

[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ] Jan Stourac edited comment on WFLY-11066 at 9/25/18 6:51 AM: ------------------------------------------------------------- [~ppalaga], I believe this is connected WFLY-11065, right? Note that there is a [commit with test extension|https://github.com/jstourac/wildfly/commit/29e6fde75478a8245c7c... to cover this issue. was (Author: jstourac): [~ppalaga], I believe this is connected WFLY-11065, right? > Incorrect >= 3.1 conditional in JspInitializationListener > --------------------------------------------------------- > > Key: WFLY-11066 > URL: https://issues.jboss.org/browse/WFLY-11066 > Project: WildFly > Issue Type: Bug > Components: Web (Undertow) > Reporter: Peter Palaga > Assignee: Peter Palaga > > In {{JspInitializationListener}} there is a comment saying > {quote} > if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* > {quote} > However the conditional following the comment is not testing for "3.1 or higher": > {code} > if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) { > {code} > note that e.g. for 4.0 the expression is false > To include 4.0, the expression should be something like > {code} > if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { > {code} > [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883... -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener

by Jan Stourac (JIRA)

[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ] Jan Stourac edited comment on WFLY-11066 at 9/25/18 6:51 AM: ------------------------------------------------------------- [~ppalaga], I believe this is connected WFLY-11065, right? Note that there is a [commit with test extension|https://github.com/jstourac/wildfly/commit/29e6fde75478a8245c7c...] to cover this issue. was (Author: jstourac): [~ppalaga], I believe this is connected WFLY-11065, right? Note that there is a [commit with test extension|https://github.com/jstourac/wildfly/commit/29e6fde75478a8245c7c... to cover this issue. > Incorrect >= 3.1 conditional in JspInitializationListener > --------------------------------------------------------- > > Key: WFLY-11066 > URL: https://issues.jboss.org/browse/WFLY-11066 > Project: WildFly > Issue Type: Bug > Components: Web (Undertow) > Reporter: Peter Palaga > Assignee: Peter Palaga > > In {{JspInitializationListener}} there is a comment saying > {quote} > if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* > {quote} > However the conditional following the comment is not testing for "3.1 or higher": > {code} > if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) { > {code} > note that e.g. for 4.0 the expression is false > To include 4.0, the expression should be something like > {code} > if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { > {code} > [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883... -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener

by Jan Stourac (JIRA)

[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ] Jan Stourac commented on WFLY-11066: ------------------------------------ [~ppalaga], I believe this is connected WFLY-11065, right? > Incorrect >= 3.1 conditional in JspInitializationListener > --------------------------------------------------------- > > Key: WFLY-11066 > URL: https://issues.jboss.org/browse/WFLY-11066 > Project: WildFly > Issue Type: Bug > Components: Web (Undertow) > Reporter: Peter Palaga > Assignee: Peter Palaga > > In {{JspInitializationListener}} there is a comment saying > {quote} > if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* > {quote} > However the conditional following the comment is not testing for "3.1 or higher": > {code} > if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) { > {code} > note that e.g. for 4.0 the expression is false > To include 4.0, the expression should be something like > {code} > if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { > {code} > [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883... -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-3016) Keep column selectend on changed column type

by Gabriele Cardosi (JIRA)

[ https://issues.jboss.org/browse/DROOLS-3016?page=com.atlassian.jira.plugi... ] Gabriele Cardosi deleted DROOLS-3016: ------------------------------------- > Keep column selectend on changed column type > -------------------------------------------- > > Key: DROOLS-3016 > URL: https://issues.jboss.org/browse/DROOLS-3016 > Project: Drools > Issue Type: Bug > Reporter: Gabriele Cardosi > Assignee: Gabriele Cardosi > Priority: Minor > > After modification of a column type, the modified column "looks" deselected, but it is actually still active, and double clicking on a different property change its type. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (WFLY-10339) Broadcast/discovery-group resources have ambiguous requirement specs

by Rostislav Svoboda (JIRA)

[ https://issues.jboss.org/browse/WFLY-10339?page=com.atlassian.jira.plugin... ] Rostislav Svoboda commented on WFLY-10339: ------------------------------------------ About the naming of the attributes, I prefer to have jgroups or socket as suffix and not as prefix. Motivation: Users used to type broadcast<TAB> or discovery<TAB> in CLI will get intuitively proper suggestions. Otherwise they will be stuck a bit when finding proper resources {code} jgroups-broadcast-group ==> broadcast-group-jgroups jgroups-discovery-group ==> discovery-group-jgroups socket-broadcast-group ==> broadcast-group-socket socket-discovery-group ==> discovery-group-socket {code} > Broadcast/discovery-group resources have ambiguous requirement specs > -------------------------------------------------------------------- > > Key: WFLY-10339 > URL: https://issues.jboss.org/browse/WFLY-10339 > Project: WildFly > Issue Type: Bug > Components: JMS > Affects Versions: 12.0.0.Final > Reporter: Paul Ferraro > Assignee: Paul Ferraro > > Currently, the broadcast/discovery-group resources have messy requirement specs, as the capabilities that they require are dependent whether or not the jgroups-cluster attribute is defined. > I suggest splitting these resources into 2: > {code}/subsystem=messaging-activemq/server=*/jgroups-broadcast-group=*{code} > {code}/subsystem=messaging-activemq/server=*/jgroups-discovery-group=*{code} > which requires clustering capabilities > and > {code}/subsystem=messaging-activemq/server=*/socket-broadcast-group=*{code} > {code}/subsystem=messaging-activemq/server=*/socket-discovery-group=*{code} > which requires a socket-binding capability. > This results in clearer requirement specs - which helps simplify the introspection of this subsystem for provisioning purposes. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener

by Peter Palaga (JIRA)

[ https://issues.jboss.org/browse/WFLY-11066?page=com.atlassian.jira.plugin... ] Peter Palaga reassigned WFLY-11066: ----------------------------------- Assignee: Peter Palaga (was: Stuart Douglas) > Incorrect >= 3.1 conditional in JspInitializationListener > --------------------------------------------------------- > > Key: WFLY-11066 > URL: https://issues.jboss.org/browse/WFLY-11066 > Project: WildFly > Issue Type: Bug > Components: Web (Undertow) > Reporter: Peter Palaga > Assignee: Peter Palaga > > In {{JspInitializationListener}} there is a comment saying > {quote} > if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* > {quote} > However the conditional following the comment is not testing for "3.1 or higher": > {code} > if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) { > {code} > note that e.g. for 4.0 the expression is false > To include 4.0, the expression should be something like > {code} > if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { > {code} > [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883... -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (WFLY-11066) Incorrect >= 3.1 conditional in JspInitializationListener

by Peter Palaga (JIRA)

Peter Palaga created WFLY-11066: ----------------------------------- Summary: Incorrect >= 3.1 conditional in JspInitializationListener Key: WFLY-11066 URL: https://issues.jboss.org/browse/WFLY-11066 Project: WildFly Issue Type: Bug Components: Web (Undertow) Reporter: Peter Palaga Assignee: Stuart Douglas In {{JspInitializationListener}} there is a comment saying {quote} if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* {quote} However the conditional following the comment is not testing for "3.1 or higher": {code} if (servletContext.getEffectiveMajorVersion() >= 3 && servletContext.getEffectiveMinorVersion() >= 1) { {code} note that e.g. for 4.0 the expression is false To include 4.0, the expression should be something like {code} if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { {code} [1] https://github.com/wildfly/wildfly/blob/e8724d5e539ac26b402a5ad10ef3d9883... -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (ELY-1680) IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary

by Martin Choma (JIRA)

[ https://issues.jboss.org/browse/ELY-1680?page=com.atlassian.jira.plugin.s... ] Martin Choma updated ELY-1680: ------------------------------ Description: {code} [ERROR] testGetCertificateChainBinary(org.wildfly.security.ldap.KeyStoreSuiteChild) Time elapsed: 0.057 s <<< FAILURE! org.junit.ComparisonFailure: expected:<CN=[firefly_binary], OU=Elytron, O=Elyt...> but was:<CN=[localhost], OU=Elytron, O=Elyt...> at org.wildfly.security.ldap.KeyStoreSuiteChild.testGetCertificateChainBinary(KeyStoreSuiteChild.java:136) at org.wildfly.security.ldap.DirContextFactoryRule$1.evaluate(DirContextFactoryRule.java:218) {code} If I switch order of certificates in chain, then test passes. {code} diff --git a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java index d8095867a..cda635beb 100644 --- a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java +++ b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java @@ -133,8 +133,8 @@ public class KeyStoreSuiteChild { Certificate[] chain = keyStore.getCertificateChain("firefly_binary"); Assert.assertNotNull(chain); Assert.assertEquals(2, chain.length); - Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); - Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); } {code} For some reason I want able to debug code with -Dmaven.surefire.debug (Breakpoint was never hit) to find out which calls switch the order. was: [ERROR] testGetCertificateChainBinary(org.wildfly.security.ldap.KeyStoreSuiteChild) Time elapsed: 0.057 s <<< FAILURE! org.junit.ComparisonFailure: expected:<CN=[firefly_binary], OU=Elytron, O=Elyt...> but was:<CN=[localhost], OU=Elytron, O=Elyt...> at org.wildfly.security.ldap.KeyStoreSuiteChild.testGetCertificateChainBinary(KeyStoreSuiteChild.java:136) at org.wildfly.security.ldap.DirContextFactoryRule$1.evaluate(DirContextFactoryRule.java:218) If I switch order of certificates in chain, then test passes. {code} diff --git a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java index d8095867a..cda635beb 100644 --- a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java +++ b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java @@ -133,8 +133,8 @@ public class KeyStoreSuiteChild { Certificate[] chain = keyStore.getCertificateChain("firefly_binary"); Assert.assertNotNull(chain); Assert.assertEquals(2, chain.length); - Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); - Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); } {code} For some reason I want able to debug code with -Dmaven.surefire.debug (Breakpoint was never hit) to find out which calls switch the order. > IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary > ------------------------------------------------------------- > > Key: ELY-1680 > URL: https://issues.jboss.org/browse/ELY-1680 > Project: WildFly Elytron > Issue Type: Bug > Components: Testsuite > Affects Versions: 1.6.1.Final > Reporter: Martin Choma > > {code} > [ERROR] testGetCertificateChainBinary(org.wildfly.security.ldap.KeyStoreSuiteChild) Time elapsed: 0.057 s <<< FAILURE! > org.junit.ComparisonFailure: expected:<CN=[firefly_binary], OU=Elytron, O=Elyt...> but was:<CN=[localhost], OU=Elytron, O=Elyt...> > at org.wildfly.security.ldap.KeyStoreSuiteChild.testGetCertificateChainBinary(KeyStoreSuiteChild.java:136) > at org.wildfly.security.ldap.DirContextFactoryRule$1.evaluate(DirContextFactoryRule.java:218) > {code} > If I switch order of certificates in chain, then test passes. > {code} > diff --git a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java > index d8095867a..cda635beb 100644 > --- a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java > +++ b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java > @@ -133,8 +133,8 @@ public class KeyStoreSuiteChild { > Certificate[] chain = keyStore.getCertificateChain("firefly_binary"); > Assert.assertNotNull(chain); > Assert.assertEquals(2, chain.length); > - Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); > - Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); > + Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); > + Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); > } > {code} > For some reason I want able to debug code with -Dmaven.surefire.debug (Breakpoint was never hit) to find out which calls switch the order. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (ELY-1680) IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary

by Martin Choma (JIRA)

Martin Choma created ELY-1680: --------------------------------- Summary: IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary Key: ELY-1680 URL: https://issues.jboss.org/browse/ELY-1680 Project: WildFly Elytron Issue Type: Bug Components: Testsuite Affects Versions: 1.6.1.Final Reporter: Martin Choma [ERROR] testGetCertificateChainBinary(org.wildfly.security.ldap.KeyStoreSuiteChild) Time elapsed: 0.057 s <<< FAILURE! org.junit.ComparisonFailure: expected:<CN=[firefly_binary], OU=Elytron, O=Elyt...> but was:<CN=[localhost], OU=Elytron, O=Elyt...> at org.wildfly.security.ldap.KeyStoreSuiteChild.testGetCertificateChainBinary(KeyStoreSuiteChild.java:136) at org.wildfly.security.ldap.DirContextFactoryRule$1.evaluate(DirContextFactoryRule.java:218) If I switch order of certificates in chain, then test passes. {code} diff --git a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java index d8095867a..cda635beb 100644 --- a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java +++ b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java @@ -133,8 +133,8 @@ public class KeyStoreSuiteChild { Certificate[] chain = keyStore.getCertificateChain("firefly_binary"); Assert.assertNotNull(chain); Assert.assertEquals(2, chain.length); - Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); - Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString()); + Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString()); } {code} For some reason I want able to debug code with -Dmaven.surefire.debug (Breakpoint was never hit) to find out which calls switch the order. -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JGRP-2293) Graceful concurrent leaving of coordinator(s) leaves the cluster with stale views

by Radoslav Husar (JIRA)

[ https://issues.jboss.org/browse/JGRP-2293?page=com.atlassian.jira.plugin.... ] Radoslav Husar commented on JGRP-2293: -------------------------------------- Related to this problem of graceful leaving might be JGRP-2297 where a *single* coordinator leaving in a stack with {{ASYM_ENCRYPT}} leaves the cluster with inconsistent views. > Graceful concurrent leaving of coordinator(s) leaves the cluster with stale views > --------------------------------------------------------------------------------- > > Key: JGRP-2293 > URL: https://issues.jboss.org/browse/JGRP-2293 > Project: JGroups > Issue Type: Bug > Affects Versions: 4.0.14 > Reporter: Radoslav Husar > Assignee: Bela Ban > Priority: Critical > Fix For: 4.0.15 > > > JGroups does not handle concurrent leaving of nodes correctly. This is a typical use case in cloud environment when scaled down with an autoscaler/manually which we need to handle. > A simple test can be devised which fails first n (where n>1) nodes from a cluster, reproducer PR https://github.com/belaban/JGroups/pull/397 -- This message was sent by Atlassian JIRA (v7.5.0#75005)

7 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira September 2018