[JBoss JIRA] (DROOLS-4752) [DMN Designer] Code Completion - When users press Escape on suggestions the edit mode is closed
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4752?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4752:
--------------------------------
Description:
This bug was created by this comment: https://github.com/kiegroup/kie-wb-common/pull/3000#issuecomment-553442743
{quote}*Reported by Jozef:*
Once completions are shown, then pressing Escape hides them however cancel also edit mode of the cell, I am not sure what customers will think about this.
{quote}
Check with UX the expected behaviour, and implement the expected behaviour for the Escape key in the described case
The severity of the issue is higher if we follow this steps:
- Put some value into cell, confirm it == finish edit mode
- Edit the same cell, type new expression
- Very probably autocompletions will be shown
- However imagine you do not want to use any hint, so you press *Escape*
- Now the completions are hidden, however also edit mode was canceled and typed value was not stored
was:
This bug was created by this comment: https://github.com/kiegroup/kie-wb-common/pull/3000#issuecomment-553442743
{quote}*Reported by Jozef:*
Once completions are shown, then pressing Escape hides them however cancel also edit mode of the cell, I am not sure what customers will think about this.
{quote}
Check with UX the expected behaviour, and implement the expected behaviour for the Escape key in the described case
> [DMN Designer] Code Completion - When users press Escape on suggestions the edit mode is closed
> -----------------------------------------------------------------------------------------------
>
> Key: DROOLS-4752
> URL: https://issues.jboss.org/browse/DROOLS-4752
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Guilherme Gomes
> Priority: Major
> Labels: drools-tools
>
> This bug was created by this comment: https://github.com/kiegroup/kie-wb-common/pull/3000#issuecomment-553442743
> {quote}*Reported by Jozef:*
> Once completions are shown, then pressing Escape hides them however cancel also edit mode of the cell, I am not sure what customers will think about this.
> {quote}
> Check with UX the expected behaviour, and implement the expected behaviour for the Escape key in the described case
> The severity of the issue is higher if we follow this steps:
> - Put some value into cell, confirm it == finish edit mode
> - Edit the same cell, type new expression
> - Very probably autocompletions will be shown
> - However imagine you do not want to use any hint, so you press *Escape*
> - Now the completions are hidden, however also edit mode was canceled and typed value was not stored
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (WFLY-4244) Naming alias to datasource in deployment
by Katarina Hermanova (Jira)
[ https://issues.jboss.org/browse/WFLY-4244?page=com.atlassian.jira.plugin.... ]
Katarina Hermanova reassigned WFLY-4244:
----------------------------------------
Assignee: Katarina Hermanova
> Naming alias to datasource in deployment
> ----------------------------------------
>
> Key: WFLY-4244
> URL: https://issues.jboss.org/browse/WFLY-4244
> Project: WildFly
> Issue Type: Bug
> Components: Naming
> Affects Versions: 8.2.0.Final
> Reporter: Frank Denninger
> Assignee: Katarina Hermanova
> Priority: Minor
>
> Using a name alias to a datasource that is defined in the deployment (with a *-ds.xml in the .war) causes a npe when jpa tries to resolve that datasource with the alias.
> <lookup name="java:/de/datasource/sub" lookup="java:/de/datasource/main"/>
> When both the datasource and name-alias are defined in the standalone.xml it works as expected.
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (DROOLS-4750) DrlParser fails to parse str[endsWith] operator
by Alberto Fanjul Alonso (Jira)
[ https://issues.jboss.org/browse/DROOLS-4750?page=com.atlassian.jira.plugi... ]
Alberto Fanjul Alonso edited comment on DROOLS-4750 at 11/14/19 3:33 AM:
-------------------------------------------------------------------------
Hi [~mfusco] I didn't describe the case correctly. parsing drl rules is failing for me in current and old version of drools. I see a comment where it is supposed to work in 5.4.0 but I cannot test that . After move to 6.0.0 reproducer start to fail as codebase changed.
Trying to parse a Rule with DrlParser, normally it works,
{code:java}
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
{code}
but if you add a rule with str operator (str[endsWith] or similar) it fails.
{code:java}
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
{code}
After you run a test that builds a KieModule like `_04_buildNoStrWith` test on that reproducer DrlParser starts to work with those operators, you can see on `_05_parseStrWith` test that is run after that.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
was (Author: afanjula):
Hi [~mfusco] I didn't describe the case correctly.
Trying to parse a Rule with DrlParser, normally it works,
{code:java}
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
{code}
but if you add a rule with str operator (str[endsWith] or similar) it fails.
{code:java}
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
{code}
After you run a test that builds a KieModule like `_04_buildNoStrWith` test on that reproducer DrlParser starts to work with those operators, you can see on `_05_parseStrWith` test that is run after that.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
> DrlParser fails to parse str[endsWith] operator
> -----------------------------------------------
>
> Key: DROOLS-4750
> URL: https://issues.jboss.org/browse/DROOLS-4750
> Project: Drools
> Issue Type: Bug
> Reporter: Alberto Fanjul Alonso
> Assignee: Mario Fusco
> Priority: Major
> Attachments: str-with-reproducer.tar
>
>
> In documentation
> https://docs.jboss.org/drools/release/7.23.0.Final/drools-docs/html_singl...
> operator str[endsWith] is supposed to be supported, it it is not working.
> Fails with:
> {code:java}
> java.lang.Exception: Rule contains errors![[5,19]: [ERR 102] Line 5:19 mismatched input 'str' in rule "pnr first name end with"]
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest.parse(StrWithFailOnFirstCompilationErrorReproducerTest.java:58)
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest._03_parseStrWith(StrWithFailOnFirstCompilationErrorReproducerTest.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (DROOLS-4750) DrlParser fails to parse str[endsWith] operator
by Alberto Fanjul Alonso (Jira)
[ https://issues.jboss.org/browse/DROOLS-4750?page=com.atlassian.jira.plugi... ]
Alberto Fanjul Alonso edited comment on DROOLS-4750 at 11/14/19 3:30 AM:
-------------------------------------------------------------------------
Hi [~mfusco] I didn't describe the case correctly.
Trying to parse a Rule with DrlParser, normally it works,
{code:java}
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
{code}
but if you add a rule with str operator (str[endsWith] or similar) it fails.
{code:java}
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
{code}
After you run a test that builds a KieModule like `_04_buildNoStrWith` test on that reproducer DrlParser starts to work with those operators, you can see on `_05_parseStrWith` test that is run after that.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
was (Author: afanjula):
Hi [~mfusco] I didn't describe the case correctly.
Trying to parse a Rule with DrlParser, normally it works,
{code:java}
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
{code}
but if you add a rule with str operator (str[endsWith] or similar) it fails.
{code:java}
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
{code}
After you run a test that builds a KieModule like `_04_buildNoStrWith` DrlParser starts to work with those operators.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
> DrlParser fails to parse str[endsWith] operator
> -----------------------------------------------
>
> Key: DROOLS-4750
> URL: https://issues.jboss.org/browse/DROOLS-4750
> Project: Drools
> Issue Type: Bug
> Reporter: Alberto Fanjul Alonso
> Assignee: Mario Fusco
> Priority: Major
> Attachments: str-with-reproducer.tar
>
>
> In documentation
> https://docs.jboss.org/drools/release/7.23.0.Final/drools-docs/html_singl...
> operator str[endsWith] is supposed to be supported, it it is not working.
> Fails with:
> {code:java}
> java.lang.Exception: Rule contains errors![[5,19]: [ERR 102] Line 5:19 mismatched input 'str' in rule "pnr first name end with"]
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest.parse(StrWithFailOnFirstCompilationErrorReproducerTest.java:58)
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest._03_parseStrWith(StrWithFailOnFirstCompilationErrorReproducerTest.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (DROOLS-4750) DrlParser fails to parse str[endsWith] operator
by Alberto Fanjul Alonso (Jira)
[ https://issues.jboss.org/browse/DROOLS-4750?page=com.atlassian.jira.plugi... ]
Alberto Fanjul Alonso edited comment on DROOLS-4750 at 11/14/19 3:29 AM:
-------------------------------------------------------------------------
Hi [~mfusco] I didn't describe the case correctly.
Trying to parse a Rule with DrlParser, normally it works,
{code:java}
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
{code}
but if you add a rule with str operator (str[endsWith] or similar) it fails.
{code:drl}
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
{code}
After you run a test that builds a KieModule like `_04_buildNoStrWith` DrlParser starts to work with those operators.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
was (Author: afanjula):
Hi [~mfusco] I didn't describe the case correctly.
Trying to parse a Rule with DrlParser, normally it works,
```
package com.amadeus.pulse.mainruleset
rule rule1
when
s : String( )
then
insert (s);
end
```
but if you add a rule with str operator (str[endsWith] or similar) it fails.
```
package com.amadeus.pulse.mainruleset
rule rule2
when
s : String( this str[endsWith] "MAN" )
then
insert (s);
end
```
After you run a test that builds a KieModule like `_04_buildNoStrWith` DrlParser starts to work with those operators.
I can imagine that KieModule build do some kind of preprocessing of drl rules, and after that DrlParser do not fail.
I suppose is related with launching or enabling `StringConditionInspector` but cannot see how.
So this bug tries to setup the minimal steps to make DrlParser to parse correctly any existing drl rule.
> DrlParser fails to parse str[endsWith] operator
> -----------------------------------------------
>
> Key: DROOLS-4750
> URL: https://issues.jboss.org/browse/DROOLS-4750
> Project: Drools
> Issue Type: Bug
> Reporter: Alberto Fanjul Alonso
> Assignee: Mario Fusco
> Priority: Major
> Attachments: str-with-reproducer.tar
>
>
> In documentation
> https://docs.jboss.org/drools/release/7.23.0.Final/drools-docs/html_singl...
> operator str[endsWith] is supposed to be supported, it it is not working.
> Fails with:
> {code:java}
> java.lang.Exception: Rule contains errors![[5,19]: [ERR 102] Line 5:19 mismatched input 'str' in rule "pnr first name end with"]
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest.parse(StrWithFailOnFirstCompilationErrorReproducerTest.java:58)
> at com.amadeus.mdw.bzr.drools_reproducer.StrWithFailOnFirstCompilationErrorReproducerTest._03_parseStrWith(StrWithFailOnFirstCompilationErrorReproducerTest.java:74)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months