[JBoss JIRA] (WFCORE-4748) Expose the ability to add jboss-modules specific arguments
by James Perkins (Jira)
James Perkins created WFCORE-4748:
-------------------------------------
Summary: Expose the ability to add jboss-modules specific arguments
Key: WFCORE-4748
URL: https://issues.jboss.org/browse/WFCORE-4748
Project: WildFly Core
Issue Type: Enhancement
Components: Launcher, Scripts
Reporter: James Perkins
Assignee: James Perkins
Currently the scripts have an environment variable {{MODULE_OPTS}} which is used to enable the security manager for JBoss Modules. This variable is not currently allowed to be set yet in the {{*.conf}} files however we could expose it. The need for this comes from WFCORE-4674 where the fix will be to add JBoss Modules as an agent, then add {{-javaagent:some-agent.jar}} to the arguments for JBoss Modules.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (WFCORE-4674) Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4674?page=com.atlassian.jira.plugi... ]
James Perkins commented on WFCORE-4674:
---------------------------------------
The fix for this is going to be allowing jboss-modules to be loaded as an agent and loading other agents after the log manager has been configured. This means the log manager will no longer be required to be on the boot class path which is better all around.
> Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
> --------------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4674
> URL: https://issues.jboss.org/browse/WFCORE-4674
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: OpenShift, jdk11
>
> If the log manager is on the boot class path with Java 11, {{-Xbootclasspath/a:jboss-logmanager.jar}}, and a custom handler, formatter or filter is used the server will fail to boot as the log manager can't see the types in jboss-modules. This seems due to the fact that the log manager is on the boot class path and jboss-modules is on the system class path.
> Example exception:
> {code}
> Failed to read or configure the org.jboss.logmanager.LogManager
> java.lang.IllegalArgumentException: Failed to load module "org.jboss.logmanager" for formatter "JSON"
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:65)
> at org.jboss.logmanager.config.FormatterConfigurationImpl.<init>(FormatterConfigurationImpl.java:30)
> at org.jboss.logmanager.config.LogContextConfigurationImpl.addFormatterConfiguration(LogContextConfigurationImpl.java:172)
> at org.jboss.logmanager.PropertyConfigurator.configureFormatter(PropertyConfigurator.java:631)
> at org.jboss.logmanager.PropertyConfigurator.configureHandler(PropertyConfigurator.java:701)
> at org.jboss.logmanager.PropertyConfigurator.configureLogger(PropertyConfigurator.java:583)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:521)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:97)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:170)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:132)
> at java.util.logging.LogManager$3.run(LogManager.java:399)
> at java.util.logging.LogManager$3.run(LogManager.java:396)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.readPrimordialConfiguration(LogManager.java:396)
> at java.util.logging.LogManager.access$800(LogManager.java:145)
> at java.util.logging.LogManager$2.run(LogManager.java:345)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.ensureLogManagerInitialized(LogManager.java:338)
> at java.util.logging.LogManager.getLogManager(LogManager.java:378)
> at org.jboss.modules.Main.main(Main.java:523)
> Caused by: java.lang.NoClassDefFoundError: org/jboss/modules/ModuleLoader
> at org.jboss.logmanager.config.AbstractPropertyConfiguration$ModuleFinder.getClassLoader(AbstractPropertyConfiguration.java:556)
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:63)
> ... 19 more
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (LOGMGR-254) JDK11, Warning when starting WildFly with logmanager in bootclasspath
by James Perkins (Jira)
[ https://issues.jboss.org/browse/LOGMGR-254?page=com.atlassian.jira.plugin... ]
James Perkins commented on LOGMGR-254:
--------------------------------------
This will actually end up getting fixed by MODULES-393 as it will avoid the requirement for the log manager to be on the boot class path.
> JDK11, Warning when starting WildFly with logmanager in bootclasspath
> ---------------------------------------------------------------------
>
> Key: LOGMGR-254
> URL: https://issues.jboss.org/browse/LOGMGR-254
> Project: JBoss Log Manager
> Issue Type: Bug
> Reporter: Jean Francois Denise
> Assignee: James Perkins
> Priority: Major
>
> Using JDK11, add the following property when starting standalone.sh:
> {code}
> -Djboss.modules.system.pkgs=org.jboss.logmanager
> -Xbootclasspath/a:$JBOSS_HOME/modules/system/layers/base/org/jboss/logmanager/main/jboss-logmanager-2.1.10.Final.jar:$JBOSS_HOME/modules/system/layers/base/org/wildfly/common/main/wildfly-common-1.5.1.Final.jar
> -Djava.util.logging.manager=org.jboss.logmanager.LogManager -Dsun.util.logging.disableCallerCheck=true
> {code}
> You will notice the following warning:
> {code}
> May 15, 2019 4:49:11 PM java.lang.System$LoggerFinder lambda$accessProvider$0
> WARNING: Failed to instantiate LoggerFinder provider; Using default.
> {code}
> To display the root cause add:
> {{-Djdk.logger.finder.error=ERROR}}
> Changing the {{standalone.conf}} to the following should show the warning:
> {code}
> if [ "x$JBOSS_MODULES_SYSTEM_PKGS" = "x" ]; then
> JBOSS_MODULES_SYSTEM_PKGS="org.jboss.byteman"
> fi
> JBOSS_MODULES_SYSTEM_PKGS="org.jboss.logmanager,jdk.nashorn.api,com.sun.crypto.provider,$JBOSS_MODULES_SYSTEM_PKGS"
> if [ "x$JAVA_OPTS" = "x" ]; then
> JAVA_OPTS="-Xms64m -Xmx512m -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true"
> JAVA_OPTS="$JAVA_OPTS -Djboss.modules.system.pkgs=$JBOSS_MODULES_SYSTEM_PKGS -Djava.awt.headless=true"
> else
> echo "JAVA_OPTS already set in environment; overriding default settings with values: $JAVA_OPTS"
> fi
> BOOT_CP=()
> BOOT_CP=("$(find $JBOSS_HOME/modules -type f -name "jboss-logmanager-*.jar")")
> BOOT_CP+=("$(find $JBOSS_HOME/modules -type f -name "wildfly-common*.jar")")
> for f in $(find $JBOSS_HOME/modules -type f -name "javax.json-*.jar"); do
> BOOT_CP+=("$f")
> done
> x="-Xbootclasspath/a"
> for p in "${BOOT_CP[@]}"; do
> x+=":$p"
> done
> JAVA_OPTS="-Djava.util.logging.manager=org.jboss.logmanager.LogManager -Dsun.util.logging.disableCallerCheck=true $x $JAVA_OPTS"
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (WFCORE-4676) Upgrade jboss-modules from 1.9.1.Final to 1.10.0.Final
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4676?page=com.atlassian.jira.plugi... ]
James Perkins updated WFCORE-4676:
----------------------------------
Summary: Upgrade jboss-modules from 1.9.1.Final to 1.10.0.Final (was: Upgrade jboss-modules from 1.9.1.Final to 1.9.2.Final)
> Upgrade jboss-modules from 1.9.1.Final to 1.10.0.Final
> ------------------------------------------------------
>
> Key: WFCORE-4676
> URL: https://issues.jboss.org/browse/WFCORE-4676
> Project: WildFly Core
> Issue Type: Component Upgrade
> Components: Logging
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: OpenShift, jdk11
>
> Upgrade {{org.jboss.modules:jboss-lmodules}} from 1.9.1.Final to 1.9.2.Final.
> This is created as a critical issue as it can cause issues in OpenShift with Java 11 and custom handlers, formatters and as of WildFly 18/EAP CD18 filters.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (WFCORE-4676) Upgrade jboss-modules from 1.9.1.Final to 1.10.0.Final
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4676?page=com.atlassian.jira.plugi... ]
James Perkins updated WFCORE-4676:
----------------------------------
Description:
Upgrade {{org.jboss.modules:jboss-lmodules}} from 1.9.1.Final to 1.10.0.Final.
This is created as a critical issue as it can cause issues in OpenShift with Java 11 and custom handlers, formatters and as of WildFly 18/EAP CD18 filters.
was:
Upgrade {{org.jboss.modules:jboss-lmodules}} from 1.9.1.Final to 1.9.2.Final.
This is created as a critical issue as it can cause issues in OpenShift with Java 11 and custom handlers, formatters and as of WildFly 18/EAP CD18 filters.
> Upgrade jboss-modules from 1.9.1.Final to 1.10.0.Final
> ------------------------------------------------------
>
> Key: WFCORE-4676
> URL: https://issues.jboss.org/browse/WFCORE-4676
> Project: WildFly Core
> Issue Type: Component Upgrade
> Components: Logging
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: OpenShift, jdk11
>
> Upgrade {{org.jboss.modules:jboss-lmodules}} from 1.9.1.Final to 1.10.0.Final.
> This is created as a critical issue as it can cause issues in OpenShift with Java 11 and custom handlers, formatters and as of WildFly 18/EAP CD18 filters.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (LOGMGR-261) If a module is defined and the log manager is on boot class path the log manager will fail to configure
by James Perkins (Jira)
[ https://issues.jboss.org/browse/LOGMGR-261?page=com.atlassian.jira.plugin... ]
James Perkins closed LOGMGR-261.
--------------------------------
Resolution: Won't Fix
This is going to be fixed in JBoss Modules itself. See the fix for MODULES-393.
> If a module is defined and the log manager is on boot class path the log manager will fail to configure
> -------------------------------------------------------------------------------------------------------
>
> Key: LOGMGR-261
> URL: https://issues.jboss.org/browse/LOGMGR-261
> Project: JBoss Log Manager
> Issue Type: Bug
> Components: core
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: jdk11
>
> If the log manager is on the boot class path and a module is defined in the {{logging.properties}} or defined in the configuration API the log manager will fail to configure. This seems due to the fact that the log manager is on the boot class path and jboss-modules is on the system class path.
> Example exception:
> {code}
> Failed to read or configure the org.jboss.logmanager.LogManager
> java.lang.IllegalArgumentException: Failed to load module "org.jboss.logmanager" for formatter "JSON"
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:65)
> at org.jboss.logmanager.config.FormatterConfigurationImpl.<init>(FormatterConfigurationImpl.java:30)
> at org.jboss.logmanager.config.LogContextConfigurationImpl.addFormatterConfiguration(LogContextConfigurationImpl.java:172)
> at org.jboss.logmanager.PropertyConfigurator.configureFormatter(PropertyConfigurator.java:631)
> at org.jboss.logmanager.PropertyConfigurator.configureHandler(PropertyConfigurator.java:701)
> at org.jboss.logmanager.PropertyConfigurator.configureLogger(PropertyConfigurator.java:583)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:521)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:97)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:170)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:132)
> at java.util.logging.LogManager$3.run(LogManager.java:399)
> at java.util.logging.LogManager$3.run(LogManager.java:396)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.readPrimordialConfiguration(LogManager.java:396)
> at java.util.logging.LogManager.access$800(LogManager.java:145)
> at java.util.logging.LogManager$2.run(LogManager.java:345)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.ensureLogManagerInitialized(LogManager.java:338)
> at java.util.logging.LogManager.getLogManager(LogManager.java:378)
> at org.jboss.modules.Main.main(Main.java:523)
> Caused by: java.lang.NoClassDefFoundError: org/jboss/modules/ModuleLoader
> at org.jboss.logmanager.config.AbstractPropertyConfiguration$ModuleFinder.getClassLoader(AbstractPropertyConfiguration.java:556)
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:63)
> ... 19 more
> {code}
> The only real resolution to this will be to create some kind of {{ModuleFinder}} API in the log manager which allows something like jboss-modules to implement a version which knows how to log the modules.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (ELY-1905) Fix OCSP Tests which are failing
by Ashley Abdel-Sayed (Jira)
Ashley Abdel-Sayed created ELY-1905:
---------------------------------------
Summary: Fix OCSP Tests which are failing
Key: ELY-1905
URL: https://issues.jboss.org/browse/ELY-1905
Project: WildFly Elytron
Issue Type: Bug
Reporter: Ashley Abdel-Sayed
Assignee: Ashley Abdel-Sayed
Fix OCSP tests which are ignored because they were failing
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months
[JBoss JIRA] (ELY-1904) Ignore OCSP Tests failing
by Ashley Abdel-Sayed (Jira)
Ashley Abdel-Sayed created ELY-1904:
---------------------------------------
Summary: Ignore OCSP Tests failing
Key: ELY-1904
URL: https://issues.jboss.org/browse/ELY-1904
Project: WildFly Elytron
Issue Type: Bug
Components: Testsuite
Reporter: Ashley Abdel-Sayed
Assignee: Ashley Abdel-Sayed
Ignore OCSP tests failing
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 8 months