[JBoss JIRA] (DROOLS-2165) Upgrade revapi-maven-plugin from 0.9.4 to 0.9.5
by Michael Biarnes Kiefer (Jira)
[ https://issues.jboss.org/browse/DROOLS-2165?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer commented on DROOLS-2165:
------------------------------------------------
https://github.com/kiegroup/droolsjbpm-build-bootstrap/blob/master/pom.xm...
> Upgrade revapi-maven-plugin from 0.9.4 to 0.9.5
> -----------------------------------------------
>
> Key: DROOLS-2165
> URL: https://issues.jboss.org/browse/DROOLS-2165
> Project: Drools
> Issue Type: Task
> Components: build
> Reporter: Geoffrey De Smet
> Assignee: Michael Biarnes Kiefer
> Priority: Major
>
> It's a good thing to just do,
> but hopefully this message goes away on the jenkins job for drools:
> {code}
> 09:33:13 [INFO] ------------------------------------------------------------------------
> 09:33:13 [INFO] Building KIE :: Maven Archetypes 7.6.0-SNAPSHOT
> 09:33:13 [INFO] ------------------------------------------------------------------------
> 09:33:13 [WARNING] *****************************************************************
> 09:33:13 [WARNING] * Your build is requesting parallel execution, but project *
> 09:33:13 [WARNING] * contains the following plugin(s) that have goals not marked *
> 09:33:13 [WARNING] * as @threadSafe to support parallel building. *
> 09:33:13 [WARNING] * While this /may/ work fine, please look for plugin updates *
> 09:33:13 [WARNING] * and/or request plugins be made thread-safe. *
> 09:33:13 [WARNING] * If reporting an issue, report it against the plugin in *
> 09:33:13 [WARNING] * question, not against maven-core *
> 09:33:13 [WARNING] *****************************************************************
> 09:33:13 [WARNING] The following plugins are not marked @threadSafe in KIE :: Public API:
> 09:33:13 [WARNING] org.revapi:revapi-maven-plugin:0.9.4
> 09:33:13 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
> 09:33:13 [WARNING] *****************************************************************
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-2165) Upgrade revapi-maven-plugin from 0.9.4 to 0.9.5
by Michael Biarnes Kiefer (Jira)
[ https://issues.jboss.org/browse/DROOLS-2165?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer closed DROOLS-2165.
------------------------------------------
Resolution: Done
> Upgrade revapi-maven-plugin from 0.9.4 to 0.9.5
> -----------------------------------------------
>
> Key: DROOLS-2165
> URL: https://issues.jboss.org/browse/DROOLS-2165
> Project: Drools
> Issue Type: Task
> Components: build
> Reporter: Geoffrey De Smet
> Assignee: Michael Biarnes Kiefer
> Priority: Major
>
> It's a good thing to just do,
> but hopefully this message goes away on the jenkins job for drools:
> {code}
> 09:33:13 [INFO] ------------------------------------------------------------------------
> 09:33:13 [INFO] Building KIE :: Maven Archetypes 7.6.0-SNAPSHOT
> 09:33:13 [INFO] ------------------------------------------------------------------------
> 09:33:13 [WARNING] *****************************************************************
> 09:33:13 [WARNING] * Your build is requesting parallel execution, but project *
> 09:33:13 [WARNING] * contains the following plugin(s) that have goals not marked *
> 09:33:13 [WARNING] * as @threadSafe to support parallel building. *
> 09:33:13 [WARNING] * While this /may/ work fine, please look for plugin updates *
> 09:33:13 [WARNING] * and/or request plugins be made thread-safe. *
> 09:33:13 [WARNING] * If reporting an issue, report it against the plugin in *
> 09:33:13 [WARNING] * question, not against maven-core *
> 09:33:13 [WARNING] *****************************************************************
> 09:33:13 [WARNING] The following plugins are not marked @threadSafe in KIE :: Public API:
> 09:33:13 [WARNING] org.revapi:revapi-maven-plugin:0.9.4
> 09:33:13 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
> 09:33:13 [WARNING] *****************************************************************
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi updated DROOLS-4358:
--------------------------------------
Git Pull Request: https://github.com/kiegroup/drools/pull/2475
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInCellsTest.zip, multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi edited comment on DROOLS-4358 at 7/25/19 11:28 PM:
---------------------------------------------------------------------
Attached multilinesInCellsTest.zip which tests variations of this issue (run 'mvn test'). SpreadsheetCompiler generates DRL like this:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",\nage >= 20)
then
modify($fact){
setAge(30),
setName(xxxx");
}
System.out.println("okay");\nSystem.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
Expected DRL is:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",age >= 20)
then
modify($fact){
setAge(30),
setName("ssss\nxxxx");
}
System.out.println("okay");System.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
was (Author: tkobayashi):
Attached multilinesInConditionTest.zip which tests variations of this issue (run 'mvn test'). SpreadsheetCompiler generates DRL like this:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",\nage >= 20)
then
modify($fact){
setAge(30),
setName(xxxx");
}
System.out.println("okay");\nSystem.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
Expected DRL is:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",age >= 20)
then
modify($fact){
setAge(30),
setName("ssss\nxxxx");
}
System.out.println("okay");System.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInCellsTest.zip, multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi edited comment on DROOLS-4358 at 7/25/19 11:27 PM:
---------------------------------------------------------------------
If I correctly understand, the current implementation escapes all newlines in Cell values regardless of LHS/RHS.
If it's difficult to implement "escape newlines only in literal String", one idea is to introduce an option like EscapeNewLines (disabled by default) so that we can minimize the impact to ordinary users.
was (Author: tkobayashi):
If I correctly understand, the current implementation escapes all newlines in Cell values.
If it's difficult to implement "escape newlines only in literal String", one idea is to introduce an option like EscapeNewLines (disabled by default) so that we can minimize the impact to ordinary users.
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInCellsTest.zip, multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months