[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi commented on DROOLS-4358:
-------------------------------------------
Attached multilinesInConditionTest.zip which tests variations of this issue (run 'mvn test'). SpreadsheetCompiler generates DRL like this:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",\nage >= 20)
then
modify($fact){
setAge(30),
setName(xxxx");
}
System.out.println("okay");\nSystem.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
Expected DRL is:
{noformat}
package com.redhat.example.business;
//generated from Decision Table
import org.drools.decisiontable.Person;
// rule values at C12, header at C7
rule "multiple lines in action_12"
no-loop true
when
$fact:Person(name == "John",age >= 20)
then
modify($fact){
setAge(30),
setName("ssss\nxxxx");
}
System.out.println("okay");System.out.println("great");
System.out.println(" ** " +drools.getRule().getName() + ", $fact = " + $fact);
end
{noformat}
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInCellsTest.zip, multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi updated DROOLS-4358:
--------------------------------------
Attachment: multilinesInCellsTest.zip
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInCellsTest.zip, multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4358) line separators in CONDITION column in spreadsheet are escaped
by Toshiya Kobayashi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4358?page=com.atlassian.jira.plugi... ]
Toshiya Kobayashi commented on DROOLS-4358:
-------------------------------------------
If I correctly understand, the current implementation escapes all newlines in Cell values.
If it's difficult to implement "escape newlines only in literal String", one idea is to introduce an option like EscapeNewLines (disabled by default) so that we can minimize the impact to ordinary users.
> line separators in CONDITION column in spreadsheet are escaped
> ---------------------------------------------------------------
>
> Key: DROOLS-4358
> URL: https://issues.jboss.org/browse/DROOLS-4358
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.24.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: multilinesInConditionTest.zip
>
>
> If there are several lines in a cell of CONDITION(LHS), line separators are escaped, and results in build failure.
> Output from SpredSheetCompiler:
> {noformat}
> rule "multiple lines in action_12"
> when
> $fact:Person(name == "John",\nage >= 20)
> then
> ...
> end
> {noformat}
> Error when building:
> {noformat}
> java.lang.AssertionError: [7,30]: [ERR 101] Line 7:30 no viable alternative at input '\' in rule "multiple lines in action_12"
> [0,0]: Parser returned a null Package
> {noformat}
> Escaping should be done only for literal String?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4270) Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-4270?page=com.atlassian.jira.plugi... ]
Brian Dellascio edited comment on DROOLS-4270 at 7/25/19 7:00 PM:
------------------------------------------------------------------
[~uxdlc] Updated the mocks to just reflect the default PF search:
* [Marvel mocks|https://marvelapp.com/1gh777i6]
* [PF3 implemented example|https://www.patternfly.org/v3/pattern-library/forms-and-controls/...]
Changes made:
* Use standard search icon
* Collapse/reveal widget as PatternFly does, using a pop-over
* The icon resides in the same place as the previous icon, but the widget is a popover, so it appears below the icon, not in that white space like it was in the first draft
* Added blue glow to text input field
* Default PF widget treatment. White on white. I nixed the yellow because it just gets covered by the blue glow treatment anyway.
* Highlight text color is still gold, which is the PF default
* Table cell highlight - I'm awaiting a screen capture you requested of what has been implemented so far by [~karreiro], then I can move from there.
was (Author: bdellasc):
[~uxdlc] Updated the mocks to just reflect the default PF search:
* [Marvel mocks|https://marvelapp.com/1gh777i6]
* [PF3 implemented example|https://www.patternfly.org/v3/pattern-library/forms-and-controls/...]
Changes made:
* Use standard search icon
* Collapse/reveal widget as PatternFly does, using a pop-over
* The icon resides in the same place as the previous icon, but the widget is a popover, so it appears below the icon, not in that white space like it was in the first draft
* Added blue glow to text input field
* Default PF widget treatment. White on white. I nixed the yellow because it just gets covered by the blue glow treatment anyway.
* Highlight text color is still gold, which is the PF default
* Table cell highlight - I'm awaiting a screen capture of what has been implemented so far by [~karreiro], then I can move from there.
> Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
> -------------------------------------------------------------------
>
> Key: DROOLS-4270
> URL: https://issues.jboss.org/browse/DROOLS-4270
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Affects Versions: 7.23.0.Final
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: Example.png, Screen Shot 2019-05-30 at 5.14.30 PM.png
>
>
> As a user of the proposed 7.5 GDT/DMN "Find" feature, when I submit text using the find tool, I need to see the results visually highlighting in the respective canvas area.
> Find is a local search that could be performed in these areas of the application:
> * Guided Decision Table editor (tables) - text strings within "Data cells"
> * DMN graph- text strings within canvas nodes.
> * DMN boxed expressions (logic) - text strings within "Data cells"
> Requirements
> * Colors, etc for partial and whole text strings will need to be highlighted is required.
> * General recommendations regarding the usability and appearance for highlighting entire table cells and nodes.
> * Visual styles for the above if recommended.
> Considerations
> * Will not be able to leverage browser controls for Find.
> * Visual design should take into consideration the visual treatments that will be applied within these jiras: https://issues.jboss.org/browse/DROOLS-3953 and https://issues.jboss.org/browse/DROOLS-4258.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4270) Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-4270?page=com.atlassian.jira.plugi... ]
Brian Dellascio commented on DROOLS-4270:
-----------------------------------------
[~uxdlc] Updated the mocks to just reflect the default PF search:
* [Marvel|https://marvelapp.com/1gh777i6]
* [PF3 implemented example|https://www.patternfly.org/v3/pattern-library/forms-and-controls/...]
Changes made:
* Use standard search icon
* Collapse/reveal widget as PatternFly does, using a pop-over
* The icon resides in the same place as the previous icon, but the widget is a popover, so it appears below the icon, not in that white space like it was in the first draft
* Added blue glow to text input field
* Default PF widget treatment. White on white. I nixed the yellow because it just gets covered by the blue glow treatment anyway.
* Highlight text color is still gold, which is the PF default
* Table cell highlight - I'm awaiting a screen capture of what has been implemented so far by [~karreiro], then I can move from there.
> Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
> -------------------------------------------------------------------
>
> Key: DROOLS-4270
> URL: https://issues.jboss.org/browse/DROOLS-4270
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Affects Versions: 7.23.0.Final
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: Example.png, Screen Shot 2019-05-30 at 5.14.30 PM.png
>
>
> As a user of the proposed 7.5 GDT/DMN "Find" feature, when I submit text using the find tool, I need to see the results visually highlighting in the respective canvas area.
> Find is a local search that could be performed in these areas of the application:
> * Guided Decision Table editor (tables) - text strings within "Data cells"
> * DMN graph- text strings within canvas nodes.
> * DMN boxed expressions (logic) - text strings within "Data cells"
> Requirements
> * Colors, etc for partial and whole text strings will need to be highlighted is required.
> * General recommendations regarding the usability and appearance for highlighting entire table cells and nodes.
> * Visual styles for the above if recommended.
> Considerations
> * Will not be able to leverage browser controls for Find.
> * Visual design should take into consideration the visual treatments that will be applied within these jiras: https://issues.jboss.org/browse/DROOLS-3953 and https://issues.jboss.org/browse/DROOLS-4258.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (DROOLS-4270) Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-4270?page=com.atlassian.jira.plugi... ]
Brian Dellascio edited comment on DROOLS-4270 at 7/25/19 6:59 PM:
------------------------------------------------------------------
[~uxdlc] Updated the mocks to just reflect the default PF search:
* [Marvel mocks|https://marvelapp.com/1gh777i6]
* [PF3 implemented example|https://www.patternfly.org/v3/pattern-library/forms-and-controls/...]
Changes made:
* Use standard search icon
* Collapse/reveal widget as PatternFly does, using a pop-over
* The icon resides in the same place as the previous icon, but the widget is a popover, so it appears below the icon, not in that white space like it was in the first draft
* Added blue glow to text input field
* Default PF widget treatment. White on white. I nixed the yellow because it just gets covered by the blue glow treatment anyway.
* Highlight text color is still gold, which is the PF default
* Table cell highlight - I'm awaiting a screen capture of what has been implemented so far by [~karreiro], then I can move from there.
was (Author: bdellasc):
[~uxdlc] Updated the mocks to just reflect the default PF search:
* [Marvel|https://marvelapp.com/1gh777i6]
* [PF3 implemented example|https://www.patternfly.org/v3/pattern-library/forms-and-controls/...]
Changes made:
* Use standard search icon
* Collapse/reveal widget as PatternFly does, using a pop-over
* The icon resides in the same place as the previous icon, but the widget is a popover, so it appears below the icon, not in that white space like it was in the first draft
* Added blue glow to text input field
* Default PF widget treatment. White on white. I nixed the yellow because it just gets covered by the blue glow treatment anyway.
* Highlight text color is still gold, which is the PF default
* Table cell highlight - I'm awaiting a screen capture of what has been implemented so far by [~karreiro], then I can move from there.
> Visual design: Highlighting treatment for GDST/DMN 7.5 Find results
> -------------------------------------------------------------------
>
> Key: DROOLS-4270
> URL: https://issues.jboss.org/browse/DROOLS-4270
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Affects Versions: 7.23.0.Final
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: Example.png, Screen Shot 2019-05-30 at 5.14.30 PM.png
>
>
> As a user of the proposed 7.5 GDT/DMN "Find" feature, when I submit text using the find tool, I need to see the results visually highlighting in the respective canvas area.
> Find is a local search that could be performed in these areas of the application:
> * Guided Decision Table editor (tables) - text strings within "Data cells"
> * DMN graph- text strings within canvas nodes.
> * DMN boxed expressions (logic) - text strings within "Data cells"
> Requirements
> * Colors, etc for partial and whole text strings will need to be highlighted is required.
> * General recommendations regarding the usability and appearance for highlighting entire table cells and nodes.
> * Visual styles for the above if recommended.
> Considerations
> * Will not be able to leverage browser controls for Find.
> * Visual design should take into consideration the visual treatments that will be applied within these jiras: https://issues.jboss.org/browse/DROOLS-3953 and https://issues.jboss.org/browse/DROOLS-4258.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (WFLY-5286) Provide CLI operation which returns used journal type - NIOxASYNCIO
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-5286?page=com.atlassian.jira.plugin.... ]
Brian Stansberry updated WFLY-5286:
-----------------------------------
Issue Type: Feature Request (was: Enhancement)
> Provide CLI operation which returns used journal type - NIOxASYNCIO
> -------------------------------------------------------------------
>
> Key: WFLY-5286
> URL: https://issues.jboss.org/browse/WFLY-5286
> Project: WildFly
> Issue Type: Feature Request
> Components: JMS
> Affects Versions: 10.0.0.Beta2
> Reporter: Miroslav Novak
> Assignee: Jeff Mesnil
> Priority: Major
>
> There is no way to get information which journal type is used using CLI as attribute journal-type provides only information which journal type is configured but not which one is actually used in runtime because Artemis falls back to NIO journal type if AIO natives are not located. New operation or attribute should be provided.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (WFLY-12275) Add Documentation for Enhanced Audit Logging - RFC support and Configuring Reconnects
by Justin Cook (Jira)
[ https://issues.jboss.org/browse/WFLY-12275?page=com.atlassian.jira.plugin... ]
Justin Cook updated WFLY-12275:
-------------------------------
Description:
Currently, Audit Logging in Elytron does not have the same capabilities as Legacy Security. This task is to enhance Elytron Audit Logging to have support for RFC5424/RFC3164 and add the additional ability to configure reconnect attempts.
was:
This RFE for Enhanced Audit Logging in WildFly Elytron is for:
* RFC5424 Support
* RFC3164 Support
* Reliability vs Speed Customization
> Add Documentation for Enhanced Audit Logging - RFC support and Configuring Reconnects
> -------------------------------------------------------------------------------------
>
> Key: WFLY-12275
> URL: https://issues.jboss.org/browse/WFLY-12275
> Project: WildFly
> Issue Type: Feature Request
> Components: Security
> Reporter: Justin Cook
> Assignee: Justin Cook
> Priority: Major
> Labels: EAP-CD18
> Fix For: 18.0.0.Beta1
>
>
> Currently, Audit Logging in Elytron does not have the same capabilities as Legacy Security. This task is to enhance Elytron Audit Logging to have support for RFC5424/RFC3164 and add the additional ability to configure reconnect attempts.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (WFCORE-4394) Enhanced Audit Logging - RFC support and Configuring Reconnects
by Justin Cook (Jira)
[ https://issues.jboss.org/browse/WFCORE-4394?page=com.atlassian.jira.plugi... ]
Justin Cook updated WFCORE-4394:
--------------------------------
Description:
Currently, Audit Logging in Elytron does not have the same capabilities as Legacy Security. This task is to enhance Elytron Audit Logging to have support for RFC5424/RFC3164 and add the additional ability to configure reconnect attempts.
was:
This RFE for Enhanced Audit Logging in WildFly Elytron is for:
* RFC5424 Support
* RFC3164 Support
* Reliability vs Speed Customization
> Enhanced Audit Logging - RFC support and Configuring Reconnects
> ---------------------------------------------------------------
>
> Key: WFCORE-4394
> URL: https://issues.jboss.org/browse/WFCORE-4394
> Project: WildFly Core
> Issue Type: Feature Request
> Components: Security
> Reporter: Justin Cook
> Assignee: Justin Cook
> Priority: Major
> Labels: affects-model
> Fix For: 10.0.0.Beta3
>
>
> Currently, Audit Logging in Elytron does not have the same capabilities as Legacy Security. This task is to enhance Elytron Audit Logging to have support for RFC5424/RFC3164 and add the additional ability to configure reconnect attempts.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months