[Red Hat JIRA] (DROOLS-5729) Reorganize drools unit tests
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5729?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5729:
-----------------------------------
Sprint: 2020 Week 43-45 (from Okt 19), 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 43-45 (from Okt 19), 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30))
> Reorganize drools unit tests
> ----------------------------
>
> Key: DROOLS-5729
> URL: https://issues.redhat.com/browse/DROOLS-5729
> Project: Drools
> Issue Type: Story
> Components: core engine
> Affects Versions: 7.44.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> Motivation: The motivation is to increase test coverage. For example, unit tests which exist under drools-mvel are not tested against executable-model. "Which module is suitable for the unit test?" depends on each test so we may occasionally need to discuss. But basically drools-test-coverage is a good place for DRL based tests because drools-test-coverage may have all dependencies so is flexible to test with any configurations (e.g. alpha compiler network).
> Goals: Increase test coverage. More stable product.
> Impact: During this work, we may find new bugs (because of increased tests). Will need to fix them one-by-one as separated JIRAs.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5848) CallMethod with ActionFieldFunctions does not compile
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5848?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5848:
-----------------------------------
Sprint: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30))
> CallMethod with ActionFieldFunctions does not compile
> ------------------------------------------------------
>
> Key: DROOLS-5848
> URL: https://issues.redhat.com/browse/DROOLS-5848
> Project: Drools
> Issue Type: Bug
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools
>
> [DROOLS-3893] [Guided Decision Table] Call method on is not generated - Red Hat Issue Tracker
>
> The DROOLS-3893 needs an additional fix for Call methods setups where the CallMethod uses ActionFieldFunctions.
> The problem appears when there is ActionCallMethod in a BRL before Set or Update column that is not BRL. The two columns use the same fact variable, so when searching by name the ActionCallMethod is found and we try to append the set/update to that. We should just ignore the call.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5879) Optional newline handling in MVEL parser
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5879?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5879:
-----------------------------------
Sprint: 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 49-51 (from Nov 30))
> Optional newline handling in MVEL parser
> -----------------------------------------
>
> Key: DROOLS-5879
> URL: https://issues.redhat.com/browse/DROOLS-5879
> Project: Drools
> Issue Type: Enhancement
> Components: core engine
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Minor
> Labels: drools-core
>
> MVEL parser explicitly handles newlines so that statements can be terminated automatically without semicolons.
> However, in some situations this is not necessary. For instance, while parsing constraints, newlines should be treated as non-significant whitespace.
> We add support to a new lexer state, that can be switched at run-time (parser instantiation time), to allow for whitespace to be fully ignored, newlines included.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5762) DRLX Research Spike
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5762?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5762:
-----------------------------------
Sprint: 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 49-51 (from Nov 30))
> DRLX Research Spike
> -------------------
>
> Key: DROOLS-5762
> URL: https://issues.redhat.com/browse/DROOLS-5762
> Project: Drools
> Issue Type: Story
> Components: core engine
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Create a revised version of the DRLX language, i.e. a revised DRL language for rules definition, with less edge cases, and a slightly different syntax.
> Spec design will follow. This story is meant to deliver a small, first version of the language, just to kick off the project.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (ELY-2062) Unexpected order of security-manager permission checks on Eclipse OpenJ9 VM AdoptOpenJDK 11
by Marek Kopecky (Jira)
[ https://issues.redhat.com/browse/ELY-2062?page=com.atlassian.jira.plugin.... ]
Marek Kopecky updated ELY-2062:
-------------------------------
Description:
[AlternateSecurityManagerTest|https://github.com/wildfly-security/wildfly-...] fails on Eclipse OpenJ9 VM AdoptOpenJDK 11 because of unexpected order of security-manager permission checks.
Stacktrace:
{noformat}
testDoPrivilegedWithParameter_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.05 sec <<< FAILURE!
java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoPrivilegedWithParameter_WithContext(AlternateSecurityManagerTest.java:314)
testDoChecked_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/> but was:<file:/home/mkopecky/.m2/repository/junit/junit/4.13.1/junit-4.13.1.jar>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoChecked_WithContext(AlternateSecurityManagerTest.java:268)
testDoUnchecked_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/.m2/repository/junit/junit/4.13.1/junit-4.13.1.jar> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoUnchecked_WithContext(AlternateSecurityManagerTest.java:210)
testDoUnchecked(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoUnchecked(AlternateSecurityManagerTest.java:187)
testDoPrivilegedWithParameter(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoPrivilegedWithParameter(AlternateSecurityManagerTest.java:291)
testGetPropertyPrivileged(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: Our CodeSource expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/.m2/repository/org/wildfly/security/wildfly-elytron-security-manager-action/1.14.1.CR1-SNAPSHOT/wildfly-elytron-security-manager-action-1.14.1.CR1-SNAPSHOT.jar>
at org.wildfly.security.manager.AlternateSecurityManagerTest.testGetPropertyPrivileged(AlternateSecurityManagerTest.java:161)
{noformat}
was:[AlternateSecurityManagerTest|https://github.com/wildfly-security/wil... fails on Eclipse OpenJ9 VM AdoptOpenJDK 11 because of unexpected order of security-manager permission checks.
> Unexpected order of security-manager permission checks on Eclipse OpenJ9 VM AdoptOpenJDK 11
> -------------------------------------------------------------------------------------------
>
> Key: ELY-2062
> URL: https://issues.redhat.com/browse/ELY-2062
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Marek Kopecky
> Assignee: Darran Lofthouse
> Priority: Major
>
> [AlternateSecurityManagerTest|https://github.com/wildfly-security/wildfly-...] fails on Eclipse OpenJ9 VM AdoptOpenJDK 11 because of unexpected order of security-manager permission checks.
> Stacktrace:
> {noformat}
> testDoPrivilegedWithParameter_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.05 sec <<< FAILURE!
> java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoPrivilegedWithParameter_WithContext(AlternateSecurityManagerTest.java:314)
> testDoChecked_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0 sec <<< FAILURE!
> java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/> but was:<file:/home/mkopecky/.m2/repository/junit/junit/4.13.1/junit-4.13.1.jar>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoChecked_WithContext(AlternateSecurityManagerTest.java:268)
> testDoUnchecked_WithContext(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
> java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/.m2/repository/junit/junit/4.13.1/junit-4.13.1.jar> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoUnchecked_WithContext(AlternateSecurityManagerTest.java:210)
> testDoUnchecked(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
> java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoUnchecked(AlternateSecurityManagerTest.java:187)
> testDoPrivilegedWithParameter(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
> java.lang.AssertionError: Matching CodeSource Location expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/classes/>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testDoPrivilegedWithParameter(AlternateSecurityManagerTest.java:291)
> testGetPropertyPrivileged(org.wildfly.security.manager.AlternateSecurityManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
> java.lang.AssertionError: Our CodeSource expected:<file:/home/mkopecky/playground/elytron/1.x/manager/base/target/test-classes/> but was:<file:/home/mkopecky/.m2/repository/org/wildfly/security/wildfly-elytron-security-manager-action/1.14.1.CR1-SNAPSHOT/wildfly-elytron-security-manager-action-1.14.1.CR1-SNAPSHOT.jar>
> at org.wildfly.security.manager.AlternateSecurityManagerTest.testGetPropertyPrivileged(AlternateSecurityManagerTest.java:161)
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5913) [DMN Designer] Improving UX when Decision Table is relying on not updated data.
by Donato Marrazzo (Jira)
[ https://issues.redhat.com/browse/DROOLS-5913?page=com.atlassian.jira.plug... ]
Donato Marrazzo commented on DROOLS-5913:
-----------------------------------------
I believe that this use case would be almost address when this issue will be addressed:
https://issues.redhat.com/browse/BAPL-1562
In fact, the key aspect is that the decision table headers (input and output expressions) are FEEL expressions.
When users add a new column, they will get intellisense suggestions to set correctly the expression to variable field (e.g. "Vehicle.field").
Regarding the second issue, I believe that it can be addressed by a proper FEEL expression validation that underlines the wrong expression.
Maybe the final resolution would be a complex refactoring feature that is able to keep references between the Data Models and their usage in the FEEL expressions.
> [DMN Designer] Improving UX when Decision Table is relying on not updated data.
> --------------------------------------------------------------------------------
>
> Key: DROOLS-5913
> URL: https://issues.redhat.com/browse/DROOLS-5913
> Project: Drools
> Issue Type: Enhancement
> Reporter: Yeser Amer
> Assignee: Guilherme Gomes
> Priority: Major
>
> We should find a way to improve User Experience in the case a Decision Table is relying on Data Type which was modified by the user.
> Original Message:
> {noformat}
> TL;DR a modification of an Object (aka Structure) in the Data Model does not get reflected in the DMN Model.
> Maybe someone can point out the error in the following scenario.
> (1) Using the DMN editor in BC RHPAM.7.9 I defined the "Ve" Object (aka Structure) and the "Ve_data1" simple variable in the Data Model as custom data types
> (2) "Ve", named as "Vehicle", was used as data input to a DMN model and a decision was defined backed by a decision table
> (3) when the decision table was first created the columns for the "Vehicle" attributes were created as individual columns.
> (4) Modified the "Ve" structure by removing some attributes
> (5) The deleted attributes are still available in the decision table.
> I have two issues in this scenario.
> (I1) Step (3). By creating the columns as individual columns of the "Vehicle" variable in the decision table any sense between them belonging to the "Ve" structure is lost. Furthermore the decision table allows for changing the data type of the columns despite the fact that these belong(?) to the "Ve" object.
> (I2) Step (5). I was expecting that by modifying the columns in the data structure that change would be visible in the decision table as well. Yes, a warning is generated, but it is cryptic, lost in a table full of equally cryptic messages and no visual indication of the actual problem in the decision table. I can check the messages and find out what is going on, but explaining this to my customer proved to be quite a challenge.
> We are still targeting DMN to business analysts I presume.
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months