[JBoss JIRA] (DROOLS-5131) [DMN Designer] Boxed List support
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5131?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5131:
-----------------------------------
Description:
Errors when importing DMN model including the Boxed List semantic
{{PreviewDiagramScreenActivity failed in OPEN: java.lang.RuntimeException: CDI Event exception: CommandType=CDIEvent, BeanType=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent, BeanReference=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent@cc23, FromClient=1 sent to [unavailable]}}
We are lacking the support for "Boxed List" semantic, as described page 107 here : https://www.omg.org/spec/DMN/1.2/PDF
See page 149, "10.5.4 List metamodel"
The boxed list are represented by separate grid, similar to the Relation grid, however there is single column and no header cell. Other cells can be literal expressions or contexts.
was:
Errors when importing DMN model including the Boxed List semantic
{{PreviewDiagramScreenActivity failed in OPEN: java.lang.RuntimeException: CDI Event exception: CommandType=CDIEvent, BeanType=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent, BeanReference=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent@cc23, FromClient=1 sent to [unavailable]}}
We are lacking the support for "Boxed List" semantic, as described page 107 here : https://www.omg.org/spec/DMN/1.2/PDF
The boxed list are represented by separate grid, similar to the Relation grid, however there is single column and no header cell. Other cells can be literal expressions or contexts.
> [DMN Designer] Boxed List support
> ---------------------------------
>
> Key: DROOLS-5131
> URL: https://issues.redhat.com/browse/DROOLS-5131
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.34.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Critical
> Labels: drools-tools
>
> Errors when importing DMN model including the Boxed List semantic
> {{PreviewDiagramScreenActivity failed in OPEN: java.lang.RuntimeException: CDI Event exception: CommandType=CDIEvent, BeanType=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent, BeanReference=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent@cc23, FromClient=1 sent to [unavailable]}}
> We are lacking the support for "Boxed List" semantic, as described page 107 here : https://www.omg.org/spec/DMN/1.2/PDF
> See page 149, "10.5.4 List metamodel"
> The boxed list are represented by separate grid, similar to the Relation grid, however there is single column and no header cell. Other cells can be literal expressions or contexts.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (WFLY-13147) Deployment slowdown after WFLY upgrade (DeploymentArchive handling)
by Christoph Winter (Jira)
[ https://issues.redhat.com/browse/WFLY-13147?page=com.atlassian.jira.plugi... ]
Christoph Winter commented on WFLY-13147:
-----------------------------------------
Hi [~manovotn], are there any news on this issue respectively any objections to the fixes provided?
KR Christoph
> Deployment slowdown after WFLY upgrade (DeploymentArchive handling)
> -------------------------------------------------------------------
>
> Key: WFLY-13147
> URL: https://issues.redhat.com/browse/WFLY-13147
> Project: WildFly
> Issue Type: Bug
> Components: CDI / Weld
> Affects Versions: 17.0.1.Final
> Reporter: Christoph Winter
> Assignee: Matěj Novotný
> Priority: Major
> Attachments: Screenshot from 2020-02-24 16-23-53.png, Screenshot from 2020-02-24 16-24-32.png
>
>
> Our team upgraded our application (>205 modules) from WFLY 8.2.1 to WFLY 17.0.1 we experienced a noticeable slowdown during the deployment process (3min vs. 6min)
> A colleague found out that the following classes seem to cause the lag during dependency resolution since dependencies are processed multiple times:
> * weld/subsystem/src/main/java/org/jboss/as/weld/deployment/BeanDeploymentArchiveImpl.java
> * weld/subsystem/src/main/java/org/jboss/as/weld/deployment/processors/ExternalBeanArchiveProcessor.java
> and came up with the following workarounds that should fix the issues
> {noformat}
> diff --git a/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/BeanDeploymentArchiveImpl.java b/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/BeanDeploymentArchiveImpl.java
> index 521f47cc7d..1b4d7e8b4c 100644
> --- a/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/BeanDeploymentArchiveImpl.java
> +++ b/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/BeanDeploymentArchiveImpl.java
> @@ -246,7 +246,12 @@ public class BeanDeploymentArchiveImpl implements WildFlyBeanDeploymentArchive {
> if (moduleDependency.getIdentifier().equals(that.getModule().getIdentifier())) {
> return true;
> }
> + }
> + }
> + for (DependencySpec dependency : module.getDependencies()) {
> + if (dependency instanceof ModuleDependencySpec) {
> + ModuleDependencySpec moduleDependency = (ModuleDependencySpec) dependency;
> // moduleDependency might be an alias - try to load it to get lined module
> Module module = loadModule(moduleDependency);
> if (module != null && module.getIdentifier().equals(that.getModule().getIdentifier())) {
> {noformat}
> as well as
> {noformat}
> diff --git a/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/processors/ExternalBeanArchiveProcessor.java b/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/processors/ExternalBeanArchiveProcessor.java
> index da6e0bfcaf..1b539bba4e 100644
> --- a/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/processors/ExternalBeanArchiveProcessor.java
> +++ b/weld/subsystem/src/main/java/org/jboss/as/weld/deployment/processors/ExternalBeanArchiveProcessor.java
> @@ -162,6 +162,12 @@ public class ExternalBeanArchiveProcessor implements DeploymentUnitProcessor {
> return;
> }
> for (DependencySpec dep : module.getDependencies()) {
> + if (!(dep instanceof ModuleDependencySpec)) {
> + continue;
> + }
> + if (deploymentUnits.stream().anyMatch(d -> (((ModuleDependencySpec)dep).getName()).endsWith(d.getName()))) {
> + continue;
> + }
> final Module dependency = loadModuleDependency(dep);
> if (dependency == null) {
> continue;{noformat}
> The fixes should prevent dependencies from being processed multiple times, however, the latter should be improved.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-5132) DMN Drools TCK runner updates
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5132?page=com.atlassian.jira.plug... ]
Matteo Mortari commented on DROOLS-5132:
----------------------------------------
CRITERIA FOR RESOLVING THIS JIRA: the commit generated with https://github.com/kiegroup/drools/pull/2806 will have been REVERTED.
> DMN Drools TCK runner updates
> -----------------------------
>
> Key: DROOLS-5132
> URL: https://issues.redhat.com/browse/DROOLS-5132
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Priority: Major
>
> Activities on upstream DMN TCK is on hold as no meetings are being held -> no PRs merged on DMN TCK repo.
> Hence this PR is pending: https://github.com/dmn-tck/tck/pull/360
> In that branch/PR, I am aligning with the original TCK intention that "errorResult" flag is an hint, but cannot be enforced, over the runners.
> Example, in case
> * the result from a DMN expression evaluation is null,
> * the TCK expect a null,
> * IFF TCK did not flagged as "errorResult", we no longer just fail simply because the Drools DMN engine reported an error (which was not indicated by the TCK test).
> https://github.com/dmn-tck/tck/pull/360/files#diff-49ce6a21913fba22bc06e7...
> Before, if the Drools DMN engine raised an error, but the TCK did not indicated as "errorResult" we were reporting a failure, even if the actual value was consistent with the expected one!
> Now is aligned as explained.
> Naturally, I've in parallel raised already PR to TCK to fix the test and to provide the proper "errorResult" hint. (https://github.com/dmn-tck/tck/pull/359)
> Once the DMN-TCK-upstream PR for the Drools TCK runner is merged, https://github.com/dmn-tck/tck/pull/360 this can be reverted.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-5132) DMN Drools TCK runner updates
by Matteo Mortari (Jira)
Matteo Mortari created DROOLS-5132:
--------------------------------------
Summary: DMN Drools TCK runner updates
Key: DROOLS-5132
URL: https://issues.redhat.com/browse/DROOLS-5132
Project: Drools
Issue Type: Task
Components: dmn engine
Reporter: Matteo Mortari
Assignee: Matteo Mortari
Activities on upstream DMN TCK is on hold as no meetings are being held -> no PRs merged on DMN TCK repo.
Hence this PR is pending: https://github.com/dmn-tck/tck/pull/360
In that branch/PR, I am aligning with the original TCK intention that "errorResult" flag is an hint, but cannot be enforced, over the runners.
Example, in case
* the result from a DMN expression evaluation is null,
* the TCK expect a null,
* IFF TCK did not flagged as "errorResult", we no longer just fail simply because the Drools DMN engine reported an error (which was not indicated by the TCK test).
https://github.com/dmn-tck/tck/pull/360/files#diff-49ce6a21913fba22bc06e7...
Before, if the Drools DMN engine raised an error, but the TCK did not indicated as "errorResult" we were reporting a failure, even if the actual value was consistent with the expected one!
Now is aligned as explained.
Naturally, I've in parallel raised already PR to TCK to fix the test and to provide the proper "errorResult" hint. (https://github.com/dmn-tck/tck/pull/359)
Once the DMN-TCK-upstream PR for the Drools TCK runner is merged, https://github.com/dmn-tck/tck/pull/360 this can be reverted.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-5131) [DMN Designer] Boxed List support
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5131?page=com.atlassian.jira.plug... ]
Michael Anstis moved RHDM-1284 to DROOLS-5131:
----------------------------------------------
Project: Drools (was: Red Hat Decision Manager)
Key: DROOLS-5131 (was: RHDM-1284)
Issue Type: Enhancement (was: Bug)
Workflow: GIT Pull Request workflow (was: CDW with docs v1)
Docs QE Status: NEW
Component/s: DMN Editor
(was: Decision Central)
(was: DMN)
Steps to Reproduce: (was: Use {{fraud-scoring.dmn}} file attached to reproduce.
D)
Affects Version/s: 7.34.0.Final
(was: 7.6.0.GA)
QE Status: NEW
> [DMN Designer] Boxed List support
> ---------------------------------
>
> Key: DROOLS-5131
> URL: https://issues.redhat.com/browse/DROOLS-5131
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.34.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Critical
> Labels: drools-tools
>
> Errors when importing DMN model including the Boxed List semantic
> {{PreviewDiagramScreenActivity failed in OPEN: java.lang.RuntimeException: CDI Event exception: CommandType=CDIEvent, BeanType=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent, BeanReference=org.kie.workbench.common.stunner.core.client.canvas.event.registration.CanvasElementAddedEvent@cc23, FromClient=1 sent to [unavailable]}}
> We are lacking the support for "Boxed List" semantic, as described page 107 here : https://www.omg.org/spec/DMN/1.2/PDF
> The boxed list are represented by separate grid, similar to the Relation grid, however there is single column and no header cell. Other cells can be literal expressions or contexts.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-5130) Externalize org.drools.compiler.commons.jci.compilers.NativeJavaCompiler
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-5130:
----------------------------------------
Summary: Externalize org.drools.compiler.commons.jci.compilers.NativeJavaCompiler
Key: DROOLS-5130
URL: https://issues.redhat.com/browse/DROOLS-5130
Project: Drools
Issue Type: Task
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
NativeJavaCompiler is a utility class the may be used by different client code, unrelated to anything drools-specific and by itsel.
Currently it is defined inside the drools-compiler module that, in turns, brings in a series of unneeded dependencies for such class itself.
Moving such class (and the other strictly-needed classes) will make it re-usable without unwanted dependencies.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-5129) Clean up kie-wb-common-dmn dependencies
by Jozef Marko (Jira)
Jozef Marko created DROOLS-5129:
-----------------------------------
Summary: Clean up kie-wb-common-dmn dependencies
Key: DROOLS-5129
URL: https://issues.redhat.com/browse/DROOLS-5129
Project: Drools
Issue Type: Task
Reporter: Jozef Marko
Assignee: Jozef Marko
During KOGITO-1014 review unused dependencies in modules below were found.
- kie-wb-common-dmn-project-client
- kie-wb-common-dmn-webapp-kogito-common
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months