[JBoss JIRA] (DROOLS-5268) DMN Editor smart complete suggesting DRG not in scope
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5268?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-5268:
--------------------------------
Affects Version/s: 7.37.0.Final
> DMN Editor smart complete suggesting DRG not in scope
> -----------------------------------------------------
>
> Key: DROOLS-5268
> URL: https://issues.redhat.com/browse/DROOLS-5268
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.37.0.Final
> Reporter: Matteo Mortari
> Assignee: Guilherme Gomes
> Priority: Critical
> Labels: drools-tools
> Attachments: image-2020-04-23-12-24-56-551.png, image-2020-04-23-12-25-35-386.png
>
>
> In a DRG such as:
> !image-2020-04-23-12-24-56-551.png|thumbnail!
> the smartcomplete is suggesting symbols not in scope of the specific DRGElement:
> !image-2020-04-23-12-25-35-386.png|thumbnail!
> in my perspective this is quite dangerous, as it could very easily lead the user to write a wrong FEEL expression.
> 1. Please consider suggesting only "variables" in scope of the DRG/DRGElement
> 2. Please consider if suggesting types is really necessary
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (DROOLS-5268) DMN Editor smart complete suggesting DRG not in scope
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5268?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-5268:
--------------------------------
Labels: drools-tools (was: )
> DMN Editor smart complete suggesting DRG not in scope
> -----------------------------------------------------
>
> Key: DROOLS-5268
> URL: https://issues.redhat.com/browse/DROOLS-5268
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.37.0.Final
> Reporter: Matteo Mortari
> Assignee: Guilherme Gomes
> Priority: Critical
> Labels: drools-tools
> Attachments: image-2020-04-23-12-24-56-551.png, image-2020-04-23-12-25-35-386.png
>
>
> In a DRG such as:
> !image-2020-04-23-12-24-56-551.png|thumbnail!
> the smartcomplete is suggesting symbols not in scope of the specific DRGElement:
> !image-2020-04-23-12-25-35-386.png|thumbnail!
> in my perspective this is quite dangerous, as it could very easily lead the user to write a wrong FEEL expression.
> 1. Please consider suggesting only "variables" in scope of the DRG/DRGElement
> 2. Please consider if suggesting types is really necessary
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (DROOLS-5268) DMN Editor smart complete suggesting DRG not in scope
by Matteo Mortari (Jira)
Matteo Mortari created DROOLS-5268:
--------------------------------------
Summary: DMN Editor smart complete suggesting DRG not in scope
Key: DROOLS-5268
URL: https://issues.redhat.com/browse/DROOLS-5268
Project: Drools
Issue Type: Bug
Components: DMN Editor
Reporter: Matteo Mortari
Assignee: Guilherme Gomes
Attachments: image-2020-04-23-12-24-56-551.png, image-2020-04-23-12-25-35-386.png
In a DRG such as:
!image-2020-04-23-12-24-56-551.png|thumbnail!
the smartcomplete is suggesting symbols not in scope of the specific DRGElement:
!image-2020-04-23-12-25-35-386.png|thumbnail!
in my perspective this is quite dangerous, as it could very easily lead the user to write a wrong FEEL expression.
1. Please consider suggesting only "variables" in scope of the DRG/DRGElement
2. Please consider if suggesting types is really necessary
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (DROOLS-5267) [Test Scenario Editor] Wrong test result status if rules have not been fired
by Toni Rikkola (Jira)
Toni Rikkola created DROOLS-5267:
------------------------------------
Summary: [Test Scenario Editor] Wrong test result status if rules have not been fired
Key: DROOLS-5267
URL: https://issues.redhat.com/browse/DROOLS-5267
Project: Drools
Issue Type: Bug
Components: Test Scenarios Editor
Affects Versions: 7.36.0.Final
Reporter: Toni Rikkola
Assignee: Yeser Amer
Defect: If user create a list - typed fact and puts it to the Test Scenario test passes but coverage is 0.
This feature implemented other way in legacy test scenario.
Root case :
We removed initialization of the list by default .
Previously when you have been adding a fact to legacy test scenario - it was automatically initializing so in the end you got in GIVEN list with one empty element
Now If you add a list fact you are free to left it empty or initialize it with at least one element.
In that case if there was no rules fired we need to show a warning and mark the test as FAILED.
Workaround: put in GIVEN section for the list at least one empty element
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFLY-13003) Support the SameSite cookie attribute
by Jan Stourac (Jira)
[ https://issues.redhat.com/browse/WFLY-13003?page=com.atlassian.jira.plugi... ]
Jan Stourac commented on WFLY-13003:
------------------------------------
Just for the reference - PR with simple integration tests into WildFly TS: https://github.com/wildfly/wildfly/pull/13237/files.
> Support the SameSite cookie attribute
> -------------------------------------
>
> Key: WFLY-13003
> URL: https://issues.redhat.com/browse/WFLY-13003
> Project: WildFly
> Issue Type: Feature Request
> Components: Web (Undertow)
> Reporter: Stuart Douglas
> Assignee: Flavia Rainone
> Priority: Major
> Fix For: 19.1.0.Final, 20.0.0.Beta1
>
>
> Chrome 80 is going to significantly change how cookies are handled, as per this notice at [1], with a bit of an explanation of what the same site attribute means at [2].
> At the moment the Servlet specification has no way of setting this particular attribute, and it is not possible to configure it via container specific configuration in WildFly at present (it can only be done by writing some Undertow specific code).
> I propose we add a same-site-cookie-attribute predicated handler to undertow, which takes an optional cookie name regex, and the value for the attribute to set.
> This would allow users to configure the SameSite attribute based on cookie name, and also potentially based on any other attributes including user agent, as it sounds like some browsers may have bugs that means this might need to be set on a per user agent basis.
> [1] https://www.chromestatus.com/feature/5088147346030592
> [2] https://web.dev/samesite-cookies-explained/
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFWIP-311) OpenShift XP image doubled its size to 2GB compared to 7.3.0.GA 1GB
by Jeff Mesnil (Jira)
[ https://issues.redhat.com/browse/WFWIP-311?page=com.atlassian.jira.plugin... ]
Jeff Mesnil commented on WFWIP-311:
-----------------------------------
I don't think it explains the difference in size but the comparison has too many variables
* The XP image is on JDK8 / RHEL7
* the EAP 7.3 and CD19 images are on JDK11 / RHEL8
* The XP image will be bigger than the EAP 7.3 images as it contains additional bits for the MicroProfile extensions (but this will not double its size).
I don't think there is anything specifically relevant to the XP images. It seems more related to the 7.3.1 codebase / image generation.
Once we have test builds for EAP 7.3.1 images, we will be able to locate more accurately the source of this size increase and make sure we address it.
> OpenShift XP image doubled its size to 2GB compared to 7.3.0.GA 1GB
> -------------------------------------------------------------------
>
> Key: WFWIP-311
> URL: https://issues.redhat.com/browse/WFWIP-311
> Project: WildFly WIP
> Issue Type: Bug
> Components: OpenShift
> Reporter: Martin Choma
> Assignee: Jeff Mesnil
> Priority: Major
> Attachments: Screenshot from 2020-04-23 06-56-37.png
>
>
> I have started to play with OpenShift XP image {{docker-registry.upshift.redhat.com/kwills/eap-xp1-openjdk8-openshift-rhel7:EAP7-1484}} and I have noticed it is nearly 2GB big. Used to be 0.92 GB for 7.3.0.GA or CD19.
> Also strange is there is much more layers compared to several layers in previous releases
> From dive output it seems every bash command result in own layer. Dive is reporting 624MB of waste space.
> !Screenshot from 2020-04-23 06-56-37.png|thumbnail!
> I am setting priority just to major because it is not official image yet. But if this will be the case of official image as well, I will raise priority. In OCP 4 there is no image/layer cache so image must be "downloaded" for each build from registry into pod.
> [1]
> {code}
> docker-registry.upshift.redhat.com/kwills/eap-xp1-openjdk8-openshift-rhel... 1.93 GB
> registry-proxy.engineering.redhat.com/rh-osbs/jboss-eap-7-eap73-openjdk11... 920 MB
> registry-proxy.engineering.redhat.com/rh-osbs/jboss-eap-7-tech-preview-ea... 921 MB
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (WFLY-12969) Include Openshift Instructions in EAP non-CD Quickstarts READMEs
by Eduardo Martins (Jira)
[ https://issues.redhat.com/browse/WFLY-12969?page=com.atlassian.jira.plugi... ]
Eduardo Martins updated WFLY-12969:
-----------------------------------
Git Pull Request: https://github.com/wildfly/wildfly-proposals/pull/280, https://github.com/wildfly/quickstart/pull/410 (was: https://github.com/wildfly/wildfly-proposals/pull/280)
> Include Openshift Instructions in EAP non-CD Quickstarts READMEs
> ----------------------------------------------------------------
>
> Key: WFLY-12969
> URL: https://issues.redhat.com/browse/WFLY-12969
> Project: WildFly
> Issue Type: Feature Request
> Components: Quickstarts
> Reporter: Eduardo Martins
> Assignee: Eduardo Martins
> Priority: Major
> Attachments: app-client-eap-noncd-README.html, app-client-wfly-README.html, batch-processing-eap-cd-README.html, batch-processing-eap-noncd-README.html, batch-processing-wfly-README.html, parent-eap-cd-README.html, parent-eap-noncd-README.html, parent-wfly-README.html
>
>
> Currently QS readmes include the openshift instructions only for CD releases. QS that run on Openshift (those included in CD releases) should contain openshift instructions for non-CD releases too, as the openshift image is released.
> For example helloworld QS, which is also included in CD release:
> https://raw.githubusercontent.com/wildfly/quickstart/master/helloworld/RE...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years