[jboss-jira] [JBoss JIRA] (WFLY-12674) Introduce wildfly.jpa.skipquerydetach property to enhance deferDetach extension

[ https://issues.jboss.org/browse/WFLY-12674?page=com.atlassian.jira.plugin... ] Scott Marlow updated WFLY-12674: -------------------------------- Description: Introduce wildfly.jpa.skipquerydetach that defaults to false (to wrap query objects with detacher that clears query results when obtained) but could be set to true, for JBoss AS 5/6 compatibility. This could of been part of [WFLY-3674] but was overlooked. An example of setting wildfly.jpa.skipquerydetach to true, so that the various query detacher will not be used (e.g. underlying query is returned instead of instance of QueryNonTxInvocationDetacher/TypedQueryNonTxInvocationDetacher/StoredProcedureQueryNonTxInvocationDetacher wrapper): {code} <property name="wildfly.jpa.skipquerydetach" value="true" /> {code} The below reference notes are more for background information but provide the explanation of why the AS5/6 way of detaching loaded entities changed later, to ensure the returned results from Query objects, are detached, instead of the current persistence context at the time of creating the query object, as per feedback below from JPA lead Linda DeMichiel. [From related JPA expert group discussion|https://download.oracle.com/javaee-archive/jpa-spec.java.net/u...]: {code} OK, sure + "... or query invocation" {code} Note that we missed Linda's response of "... or query invocation" in the JPA spec update, as the JPA 2.2 spec today states: {quote} 7.6.2 Container-managed Transaction-scoped Persistence Context The application can obtain a container-managed entity manager with transaction-scoped persistence context by injection or direct lookup in the JNDI namespace. The persistence context type for the entity manager is defaulted or defined as PersistenceContextType.TRANSACTION. A new persistence context begins when the container-managed entity manager is invoked [84] in the scope of an active JTA transaction, and there is no current persistence context already associated with the JTA transaction. The persistence context is created and then associated with the JTA transaction. This association of the persistence context with the JTA transaction is independent of the synchronization type of the persistence context and whether the persistence context has been joined to the transaction. {quote} [Some related AS5/6 JPA container code.|https://anonsvn.jboss.org/repos/jbossas/projects/jpa/trunk/impl/src...] which simply cleared the persistence context as we were creating a new Query, for example see: {code} public Query createQuery(String ejbqlString) { EntityManager em = getEntityManager(); detachEntitiesIfNoTx(em); return em.createQuery(ejbqlString); } {code} Also of reference, is from issue description [WFLY-3674]: {quote} For compatibility with earlier JBoss application server versions (5.0/6.0), add an extension that allows the persistence context to last until the referencing persistence context is closed. For example, in a session method that has no active JTA transaction, entities returned, will not cleared from the persistence context, until the session method completes. This extension is only introduced to allow compatibility with older application server versions. {quote} was: Introduce wildfly.jpa.skipquerydetach that defaults to false but could be set to true, for JBoss AS 5/6 compatibility. This really should of been part of [WFLY-3674] but was overlooked. An example of setting wildfly.jpa.skipquerydetach to true, so that the various query detacher will not be used (e.g. underlying query is returned instead of instance of QueryNonTxInvocationDetacher/TypedQueryNonTxInvocationDetacher/StoredProcedureQueryNonTxInvocationDetacher wrapper): {code} <property name="wildfly.jpa.skipquerydetach" value="true" /> {code} The below reference notes are more for background information but provide the explanation of why the AS5/6 way of detaching loaded entities changed later, to ensure the returned results from Query objects, are detached, instead of the current persistence context at the time of creating the query object, as per feedback below from JPA lead Linda DeMichiel. [From related JPA expert group discussion|https://download.oracle.com/javaee-archive/jpa-spec.java.net/u...]: {code} OK, sure + "... or query invocation" {code} Note that we missed Linda's response of "... or query invocation" in the JPA spec update, as the JPA 2.2 spec today states: {quote} 7.6.2 Container-managed Transaction-scoped Persistence Context The application can obtain a container-managed entity manager with transaction-scoped persistence context by injection or direct lookup in the JNDI namespace. The persistence context type for the entity manager is defaulted or defined as PersistenceContextType.TRANSACTION. A new persistence context begins when the container-managed entity manager is invoked [84] in the scope of an active JTA transaction, and there is no current persistence context already associated with the JTA transaction. The persistence context is created and then associated with the JTA transaction. This association of the persistence context with the JTA transaction is independent of the synchronization type of the persistence context and whether the persistence context has been joined to the transaction. {quote} [Some related AS5/6 JPA container code.|https://anonsvn.jboss.org/repos/jbossas/projects/jpa/trunk/impl/src...] which simply cleared the persistence context as we were creating a new Query, for example see: {code} public Query createQuery(String ejbqlString) { EntityManager em = getEntityManager(); detachEntitiesIfNoTx(em); return em.createQuery(ejbqlString); } {code} Also of reference, is from issue description [WFLY-3674]: {quote} For compatibility with earlier JBoss application server versions (5.0/6.0), add an extension that allows the persistence context to last until the referencing persistence context is closed. For example, in a session method that has no active JTA transaction, entities returned, will not cleared from the persistence context, until the session method completes. This extension is only introduced to allow compatibility with older application server versions. {quote} -- This message was sent by Atlassian Jira (v7.13.8#713008)