[jboss-jira] [JBoss JIRA] Resolved: (JBAS-7495) TestManagedConnection GlobalXID is broken

TestManagedConnection GlobalXID is broken ----------------------------------------- Key: JBAS-7495 URL: https://jira.jboss.org/jira/browse/JBAS-7495 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: Test Suite Affects Versions: JBossAS-6.0.0.M1 Reporter: Jonathan Halliday Assignee: Shelly McGowan Fix For: JBossAS-6.0.0.M2 org.jboss.test.jca.adapter.TestManagedConnection uses the GlobalXID class to wrap Xids. Setting aside that this is largely unnecessary abstraction, the implementation of GlobalXID is wrong. It converts a byte[] to a String, an activity which has undefined results where the byte[] contains arbitrary data that does not necessarily map to valid code points in the default charset. In particular, it can cause non-equal Xids to result in equal GlobalXIDs, which breaks the test. Having all methods on GlobalXID delegate to a wrapped Xid is better, or just remove the GlobalXID abstraction completely.