[
http://jira.jboss.com/jira/browse/JBRULES-1254?page=all ]
Michael Neale closed JBRULES-1254.
----------------------------------
Resolution: Rejected
Maybe I am mistaken - but the repository and brms both use log4j classes directly, not
sl4j - so can't do this quite yet.
So if we want, we could switch to sl4j. But if I spend more then 2 seconds a week thinking
about logging my head explodes. I hate it all, and may just remove all logging whatsoever
;)
drools-repository/jbrms should not force log4j and slf4j-log4j12 (it
should be test scoped), only slf4j-api
-----------------------------------------------------------------------------------------------------------
Key: JBRULES-1254
URL:
http://jira.jboss.com/jira/browse/JBRULES-1254
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-brms
Affects Versions: 4.0.1
Reporter: Geoffrey De Smet
Assigned To: Michael Neale
Fix For: FUTURE
log4j and slf4j-log4j12 should be test scoped, because only for the tests they are
needed, but users can choose their logging implementation themselves.
In examples you'll probably want to make them runtime scoped.
slf4j-api is a direct compile time dependency, although currently it's retrieved as a
"pseudo transitive dependency" through slf4j-log4j12 which explains why it
currently compiles anyway.
See drools-repository/pom.xml where I 've commented what I propose to change:
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<scope>test</scope>
</dependency>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira