[jboss-jira] [JBoss JIRA] (JBCLUSTER-42) First deploy after joining a cluster is not farmed

First deploy after joining a cluster is not farmed -------------------------------------------------- Key: JBCLUSTER-42 URL: https://issues.jboss.org/browse/JBCLUSTER-42 Project: JBoss Clustering Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: Q2Y5 Environment: Jboss 4.0.2 final, Java 1.5.0_02 Reporter: Gabriele Garuglieri Assignee: Scott Marlow Fix For: Q2Y5 Time Spent: 3 hours Remaining Estimate: 0 minutes There a problem in org.jboss.ha.framework.server.FarmMemberService that shows during service startup. It happens with the following scenario. 1- server starts up and joins the cluster, /farm applications are pulled from remote node. 2- farmDeploy() is called for the applications, remotelyDeployed gets filled with their names 3- scanner thread is started and begins calling deploy() for each application 4- by chance, deploy() executes while service status is still STARTING so it call super.deploy() and applications are deployed but their names are not removed from remotelyDeployed 5- you remove application from /farm and farmUndeploy() is invoked. 6- you put again application in /farm, deploy() is called, super.deploy() is called, BUT remotelyDeployed is still dirty from the preceding deploy so farmDeploy() is not invoked and the application won't get farmed Then everything cleans up and for subsequent deploy/undeploy works correctly. I tested the solution proposed by Scott Marlow Novell to move the clearing of "remotelyDeployed" flag before the "getState() == STARTING" test and it looks to be working.