[jboss-jira] [JBoss JIRA] Resolved: (JBMESSAGING-1809) Fix closed connection check in ClientSocketWrapper

Fix closed connection check in ClientSocketWrapper -------------------------------------------------- Key: JBMESSAGING-1809 URL: https://jira.jboss.org/browse/JBMESSAGING-1809 Project: JBoss Messaging Issue Type: Bug Affects Versions: 1.4.0.SP3.CP10, 1.4.6.GA.SP1 Reporter: Ron Sigal Assignee: Howard Gao Fix For: 1.4.0.SP3.CP11, 1.4.7.GA Attachments: ClientSocketWrapper.java Two problems have turned up in the closed connection checking mechanisms: 1. A regression in the default connection checking mechanism entered in JBMESSAGING-1737 "Update ClienSocketWrapper": When an instance of org.jboss.jms.client.remoting.ServerSocketWrapper closes, it writes a single org.jboss.jms.client.remoting.ClientSocketWrapper.CLOSING byte, and, prior to JBMESSAGING-1737, ClientSocketWrapper checked for the presence of >0 available bytes. However, I created a new version of ClientSocketWrapper for JBMESSAGING, based on the Remoting version of ClientSocketWrapper, and the Remoting version uses two CLOSING bytes. I accidentally included the the test for > 1 bytes. 2. The original closed connection checking mechanism, which is enabled by setting the parameter "socket.check_connection" to "true", sends a round trip byte, with value 1, from the client to the server and back. Now, Remoting uses 254 for ClientSocketWrapper.CLOSING, but, for some reason, I defined ClientSocketWrapper.CLOSING to be 1 in JBossMessaging. The 1 written by ServerSocketWrapper upon closing can be mistaken for the return of a 1 byte if the original connection checking mechanism is turned on, and a defunct connection can appear to be alive.