[jboss-jira] [JBoss JIRA] (WFLY-10448) Obsolete java options -d32, -d64 in jdk-10 affect scripts domain.sh, standalone.sh, appclient.sh

[ https://issues.jboss.org/browse/WFLY-10448?page=com.atlassian.jira.plugin... ] Brian Stansberry edited comment on WFLY-10448 at 5/24/18 6:14 PM: ------------------------------------------------------------------ AIUI, any -d32 or -d64 would only come from user supplied $JAVA_OPTS. And the presence of that in $JAVA_OPTS is going to prevent the server starting, which is fine, the user should be informed if they are providing useless params. So, the script missing out on including a -server doesn't matter much. Adding a -d32 in domain.conf and running domain.sh I get: {code} $ dist/target/wildfly-13.0.0.Beta2-SNAPSHOT/bin/domain.sh ========================================================================= JBoss Bootstrap Environment JBOSS_HOME: /Users/bstansberry/dev/wildfly/wildfly/dist/target/wildfly-13.0.0.Beta2-SNAPSHOT JAVA: /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/bin/java JAVA_OPTS: -d32 -Xms64m -Xmx512m -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=org.jboss.byteman -Djava.awt.headless=true ========================================================================= Error: This Java instance does not support a 32-bit JVM. Please install the desired version. {code} In standalone.sh it's a bit different as there's this crufty stuff: {code} elif $darwin && [ "x$SERVER_SET" = "x" ]; then # Use 32-bit on Mac, unless server has been specified or the user opts are incompatible "$JAVA" -d32 $JAVA_OPTS -version > /dev/null 2>&1 && PREPEND_JAVA_OPTS="-d32" && JVM_OPTVERSION="-d32" fi {code} There we're trying 'java -d32 -version' regardless of what the user says. It doesn't seem to break anything (in fact that call failing 'works', as it results as intended in not trying to pass -d32 in the java call that launches the server.) OT: in 2018 this logic trying to force Macs to use -client and -d32 seems really crufty and not worth the complexity. Note also that standalone.sh doesn't actively prevent -server for Macs the way domain.sh and appclient.sh do. Semi-OT: In the script snippet in the description I see two smelly things: 1) HAS_HOTSPOT=`"$JAVA" $JVM_OPTVERSION -version 2>&1 | $GREP -i HotSpot` That '-version' is redundant as JVM_OPTVERSION already has -version in it. The JVM doesn't seem to mind the duplicate though, at least Hotspot doesn't. 2) The last block is pointless as JVM_OPTVERSION is not used after it: {code} else JVM_OPTVERSION="-server $JVM_OPTVERSION" fi {code} was (Author: brian.stansberry): AIUI, any -d32 or -d64 would only come from user supplied $JAVA_OPTS. And the presence of that in $JAVA_OPTS is going to prevent the server starting, which is fine, the user should be informed if they are providing useless params. So, the script missing out on including a -server doesn't matter much. Adding a -d32 in domain.conf and running domain.sh I get: {code} $ dist/target/wildfly-13.0.0.Beta2-SNAPSHOT/bin/domain.sh ========================================================================= JBoss Bootstrap Environment JBOSS_HOME: /Users/bstansberry/dev/wildfly/wildfly/dist/target/wildfly-13.0.0.Beta2-SNAPSHOT JAVA: /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/bin/java JAVA_OPTS: -d32 -Xms64m -Xmx512m -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=org.jboss.byteman -Djava.awt.headless=true ========================================================================= Error: This Java instance does not support a 32-bit JVM. Please install the desired version. {code} In standalone.sh it's a bit different as there's this crufty stuff: {code} elif $darwin && [ "x$SERVER_SET" = "x" ]; then # Use 32-bit on Mac, unless server has been specified or the user opts are incompatible "$JAVA" -d32 $JAVA_OPTS -version > /dev/null 2>&1 && PREPEND_JAVA_OPTS="-d32" && JVM_OPTVERSION="-d32" fi {code} There we're trying 'java -d32 -version' regardless of what the user says. It doesn't seem to break anything (in fact that calling failing 'works', as it results in not trying to pass -d32 in the java call that launches the server.) OT: in 2018 this logic trying to force Macs to use -client and -d32 seems really crufty and not worth the complexity. Note also that standalone.sh doesn't actively prevent -server for Macs the way domain.sh and appclient.sh do. Semi-OT: In the script snippet in the description I see two smelly things: 1) HAS_HOTSPOT=`"$JAVA" $JVM_OPTVERSION -version 2>&1 | $GREP -i HotSpot` That '-version' is redundant as JVM_OPTVERSION already has -version in it. The JVM doesn't seem to mind the duplicate though, at least Hotspot doesn't. 2) The last block is pointless as JVM_OPTVERSION is not used after it: {code} else JVM_OPTVERSION="-server $JVM_OPTVERSION" fi {code} -- This message was sent by Atlassian JIRA (v7.5.0#75005)