[jboss-jira] [JBoss JIRA] (WFLY-12054) Intermittent failures in WebsocketApplicationScopedTestCase
Brian Stansberry created WFLY-12054:
---------------------------------------
Summary: Intermittent failures in WebsocketApplicationScopedTestCase
Key: WFLY-12054
URL: https://issues.jboss.org/browse/WFLY-12054
Project: WildFly
Issue Type: Bug
Components: CDI / Weld, Test Suite
Reporter: Brian Stansberry
Assignee: Marek Marusic
https://ci.wildfly.org/project.html?projectId=WF_PullRequest&buildTyp...
Problem is this:
{code}
try (Session session =
ContainerProvider.getWebSocketContainer().connectToServer(Client.class, uriUser1)) {
//Wait until the client is initialized e.q. the OnOpen is executed
Thread.sleep(10);
Assert.assertTrue(queues.size() > 0);
{code}
That kind of pattern of a short sleep followed by an assert is not reliable.
This should loop checking periodically and only fail after an appropriate amount of time
has passed. Unless that amount of time is relevant to what's being tested it should be
a long time, 20 secs min, with TimeoutUtil.adjust used.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)