11 a.m.
[
https://jira.jboss.org/jira/browse/JBBOOT-86?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger commented on JBBOOT-86:
-------------------------------------------
This "JBBOOT86-2.patch" is good. :)
Leaves form:
JBOSS_HOME URL:
file:/home/alrubinger/business/jboss/wc/jbossas/projects/bootstrap/trunk/impl-as/target/tests-classes/jbossas/
Bootstrap: JBOSS_HOME/server/default/conf/bootstrap.xml
Common Base: JBOSS_HOME/common/
Common Library: JBOSS_HOME/common/lib/
Server Name: default
Server Base: JBOSS_HOME/server/
Server Library: JBOSS_HOME/server/default/lib/
Server Config: JBOSS_HOME/server/default/conf/
Server Home: JBOSS_HOME/server/default/
Server Data: JBOSS_HOME/server/default/data
Server Log: JBOSS_HOME/server/default/log
Server Temp: JBOSS_HOME/server/default/tmp
Some minor notes:
1) Let's prepend a "$" to the cut path, make into "$JBOSS_HOME"
2) Can "getPath" be something a bit more descriptive?
"getRelativePath(String base,URL actual )" perhaps?
3) The "/" in "getPath" should be File.separatorChar so we're not
OS-specific
...then we'll have Ray do the honors of a commit. Just put "JBBOOT-86"
somewhere in the commit message.
Reduce logging noise by making file/urls' relative
--------------------------------------------------
Key: JBBOOT-86
URL: https://jira.jboss.org/jira/browse/JBBOOT-86
Project: JBoss Bootstrap
Issue Type: Feature Request
Reporter: Max Rydahl Andersen
Assignee: Andrew Lee Rubinger
Attachments: JBBOOT86-2.patch, JBBOOT86.patch
> In some effort to address frequent user feedback that our logging is difficult to
weed through, I'm considering changing the server info dump to something like:
>
> 12:02:08,263 INFO [JBossASServerImpl] Server Configuration:
>
> Bootstrap URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/conf/bootstrap.xml
> JBOSS_HOME URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/
> Common Base URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/common/
> Common Library URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/common/lib/
> Server Name: default
> Server Base URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/
> Server Library URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/lib/
> Server Config URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/conf/
> Server Home URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/
> Server Data URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/data
> Server Log URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/log/
> Server Temp URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/server/default/tmp
>
> Do we like the additional whitespace to separate this stuff out from the rest?
We've done a similar thing in EJB3 where we print out the target JNDI names.
>
> Ultimately we should probably look at each INFO statement on AS boot and decide if
it should really be there or not.
Any chance you could print these as *relative* locations to i.e. current working
directory or HOME_URL instead of full canonical names which is very redundant and hard to
read ?
i.e., using JBOSS_HOME_URL as base:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/
12:02:08,263 INFO [JBossASServerImpl] Server Configuration:
JBOSS_HOME URL:
file:/home/alrubinger/business/jboss/wc/jbossas/branches/Branch_5_x_BootstrapLegacyRemoval/build/output/jboss-5.1.0.GA/
Bootstrap: server/default/conf/bootstrap.xml
Common Base: common/
Common Library: common/lib/
Server Name: default
Server Base: server/
Server Library: server/default/lib/
Server Config: default/conf/
Server Home: server/default/
Server Data: server/default/data
Server Log: default/log/
Server Temp: default/tmp
Note, that I removed the redundant URL for those that aren't necessarily full
url's when printed like this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira