[jboss-jira] [JBoss JIRA] Commented: (JBAS-7661) Integrate JBoss OSGi in AS distribution

[ https://jira.jboss.org/jira/browse/JBAS-7661?page=com.atlassian.jira.plug... ] Thomas Diesler commented on JBAS-7661: -------------------------------------- FYI, here a transcript of the chat that I had with Dimitris Friday 09 April 2010 ... [12:38:37] Thomas Diesler: The discussion is however relevant for the upcoming M3 release. ;-) [12:45:25] Thomas Diesler: the beauty about smoke-tests is that folks actually run them often [12:45:45] Dimitris Andreadis: i know, but your test target will also show up in hudson runs [12:45:45] Thomas Diesler: thats why I wanted osgi coverage in there out of the box ... [12:46:28] Thomas Diesler: again, whats your concern against osgi being part of 'all'? is it just boot time? [12:46:42] Dimitris Andreadis: yea, boot time ... [12:51:20] Dimitris Andreadis: I think the 'osgi' config is a good first step to show that "we do OSGi", too. And we can take it from there depending on user interest. [12:53:59] Thomas Diesler: my main concern with that approach is that other services i.e. ejb3, web, hornetq, etc. would not work as expected when a user installs jbosgi using the installer. Because there is no test coverage that tests these services with osgi in place. [12:54:07] Thomas Diesler: Here is a prime example http://community.jboss.org/thread/150453?tstart=0 [12:54:54] Thomas Diesler: Simple EJB3 SLSB breaks when osgi is installed [12:55:13] Thomas Diesler: Issues like this I'd like to see in the AS hudson run [12:55:37] Thomas Diesler: which I would not if its (only) in a separate profile [12:55:53] Dimitris Andreadis: but we could test for that with your custom osgi-test config, no? [12:57:01] Thomas Diesler: only if we run all-tests against an 'all+osgi' configuration [12:57:18] Thomas Diesler: I claim taht it would be better to make osgi part of all [12:57:35] Thomas Diesler: so that all test coverage must work with osgi in place [12:58:01] Dimitris Andreadis: i see your point [13:04:34] Thomas Diesler: Here is another example: https://jira.jboss.org/jira/browse/JBAS-7909 [13:04:51] Thomas Diesler: the 'default' profile would not even boot with osgi in place [13:05:17] Thomas Diesler: because the AOP subsystems makes certain assumptions that osgi bundle deployments do not sattisfy [13:05:59] Thomas Diesler: stuff like this I'd like to catch early before I want to ship osgi as part of AS [13:06:07] Dimitris Andreadis: in that case the only way to satisfy everybody is to copy over osgi for all tests and remove it afterwards. [13:06:20] Dimitris Andreadis: i.e. make all-test a custom config [13:06:38] Thomas Diesler: that would work ... [13:07:47] Dimitris Andreadis: maybe you can throw the idea/reasoning on the dev-list thread [13:08:26] Thomas Diesler: sure, let me add the boot time delta [13:08:38] Dimitris Andreadis: yes, thats imporant [13:19:17] Thomas Diesler: on my machine I get 'all' config boot times of osgi excluded: ~ 1:17min osgi included: ~ 1:37min This is an increase of ca. 29% [13:19:50] Dimitris Andreadis: 1:17 is a lot already ... [13:28:05] Dimitris Andreadis: all+osgi: 1:02 [13:29:52] Dimitris Andreadis: all-osgi: 49 [13:30:33] Dimitris Andreadis: +26.5% [13:31:26] Thomas Diesler: same result [13:31:31] Thomas Diesler: so what do you say? [13:33:13] Dimitris Andreadis: do the isolated testing anyway (custom config with smoke tests + osgi tests anyway) and discuss if we should alter the all testing [13:33:36] Thomas Diesler: ok -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira