[
https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugi...
]
Michael Anstis edited comment on DROOLS-4724 at 12/4/19 9:13 AM:
-----------------------------------------------------------------
[~jomarko] So IMO there are some inconsistencies.
[~tari_manga] Please see my
[
comment|https://issues.jboss.org/browse/DROOLS-4724?focusedCommentId=1382...]
above showing the current state of expression usage with different nodes/boxed
expressions. The places where I stated the expression is optional follows your analysis
of the XSD in previous
[
comments|https://issues.jboss.org/browse/DROOLS-4724?focusedCommentId=138...].
i.e. the XSD shows expression has a minimum occurrence of 0 on the types I list.
So, given your previous comments [~tari_manga] did you want to make the validation of
missing expression always return WARNINGs?
At the moment for Binding and BKM ERRORs are returned (BKM has an ERROR from validation
but a WARNING from KieBuilder).
was (Author: manstis):
[~jomarko] So IMO there are some inconsistencies.
[~tari_manga] Please see my
[
comment|https://issues.jboss.org/browse/DROOLS-4724?focusedCommentId=1382...]
above showing the current state of expression usage with different nodes/boxed
expressions.
The places where I stated the expression is optional follows your analysis of the XSD in
previous
[
comments|https://issues.jboss.org/browse/DROOLS-4724?focusedCommentId=138...].
i.e. the XSD shows expression has a minimum occurrence of 0 on the types I list.
So, given your previous comments [~tari_manga] did you want to make the validation of
missing expression always return WARNINGs?
At the moment for Binding and BKM ERRORs are returned (BKM has an ERROR from validation
but a WARNING from KieBuilder).
[DMN Designer] Do not default to a LiteralExpression when no
expression is defined
----------------------------------------------------------------------------------
Key: DROOLS-4724
URL:
https://issues.jboss.org/browse/DROOLS-4724
Project: Drools
Issue Type: Enhancement
Components: DMN Editor
Reporter: Matteo Mortari
Assignee: Michael Anstis
Priority: Major
Labels: drools-tools
Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log,
image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn,
save-context.webm, screenshot-1.png, screenshot-2.png
Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user
did not provide an expression for an element.
However Error message is reported anyway to the user:
!image-2019-11-04-19-39-01-113.png|thumbnail!
This also as the (imho undesired) side-effect that if the user was to re-open later that
file, instead of a empty element, it would be a blank LiteralExpression
!image-2019-11-04-19-40-27-201.png|thumbnail!
so the current behavior is not consistent across re-open of the editor.
Let's revert this default.
The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did
not provide an expression for the element.
Once this change is applied from the f/e side, I am happy to be involved in order to
assess which of the messages reported by the Validator or the Compiler are causing issue
to the WB (if any).
Currently, the DMN Compiler will throw 1 Warning.
Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
Currently, the DMN Validator schema check is not reporting any XSD violation.
h2. Manual acceptance test
Try to save default / empty
h3. Business Central
- Decision node
- BKM node
- Cleared Function
- Context entry
- Invocation
h3. Kogito
- Decision node
- BKM node
- Cleared Function
- Context entry
- Invocation
--
This message was sent by Atlassian Jira
(v7.13.8#713008)