[jboss-jira] [JBoss JIRA] Updated: (JBAS-5524) EAR isolation requires jboss-app.xml

EAR isolation requires jboss-app.xml ------------------------------------ Key: JBAS-5524 URL: http://jira.jboss.com/jira/browse/JBAS-5524 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: JBossAS-5.0.0.Beta4 Reporter: Alexey Loubyansky Assigned To: Alexey Loubyansky Fix For: JBossAS-5.0.0.CR1 Setting "isolated" to true in ear-deployer-beans.xml on JBossAppParsingDeployer will not make EARs isolated unless they include at least an empty jboss-app.xml. The bug is in the logic of JBossAppParsingDeployer.createMetaData(). The following patch would fix it @@ -152,6 +149,8 @@ if(specMetaData == null && metaData == null) return; + LoaderRepositoryConfig loaderCfg = null; + // If there no JBossMetaData was created from a jboss-app.xml, create one if (metaData == null) { @@ -160,12 +159,6 @@ else { LoaderRepositoryMetaData lrmd = metaData.getLoaderRepository(); - LoaderRepositoryConfig loaderCfg = null; - if (loaderCfg == null && isolated) - { - // If no config was given and isolation is on, create an isolated config - loaderCfg = initLoaderRepository(metaData, unit); - } if (lrmd != null) { loaderCfg = new LoaderRepositoryConfig(); @@ -189,10 +182,18 @@ loaderCfg.repositoryConfig = config.getConfig(); } } - // Add the loader repository config - if (loaderCfg != null) - unit.addAttachment(LoaderRepositoryConfig.class, loaderCfg); } + + if (loaderCfg == null && isolated) + { + // If no config was given and isolation is on, create an isolated config + loaderCfg = initLoaderRepository(metaData, unit); + } + + // Add the loader repository config + if (loaderCfg != null) + unit.addAttachment(LoaderRepositoryConfig.class, loaderCfg);