]
Chao Wang commented on WFCORE-3576:
-----------------------------------
For the existing subsystems and their DeploymentUnitProcessor, it's required.
Otherwise, deployment is skipped if deployment type can't be recognized e.g.
[
]
I believe this "skip" is by design as it always gives other
DeploymentUnitProcessor a chance to parse the deployment file.
For any possible Extension and its own implementation of DeploymentUnitProcessor, this is
not mandatory.
deployment is not accessible in runtime when deployed with
runtime-name not using .war extension
------------------------------------------------------------------------------------------------
Key: WFCORE-3576
URL:
https://issues.jboss.org/browse/WFCORE-3576
Project: WildFly Core
Issue Type: Enhancement
Components: Deployment Scanner, Domain Management
Affects Versions: 4.0.0.Alpha9
Reporter: Jan Stourac
Assignee: Chao Wang
According to the folowing [
blog-post|https://developer.jboss.org/thread/221251], when
using custom --name or --runtime-name for deployment, the file extension (.war, .jar,
.ear,...) need to be included so server can distinguish type of deployment somehow.
Currently there is no such check - when I try to deploy any .war app using either
web-console or CLI with my custom '\-\-runtime-name' and/or '\-\-name'
without .war suffix, server does not complain anyhow:
{code}
deploy --runtime-name=alice --name=bob /tmp/eve.war
{code}
Message in server log:
{code}
17:30:48,469 INFO [org.jboss.as.server.deployment] (MSC service thread 1-3) WFLYSRV0027:
Starting deployment of "bob" (runtime-name: "alice")
17:30:48,499 INFO [org.jboss.as.server] (management-handler-thread - 6) WFLYSRV0010:
Deployed "bob" (runtime-name : "alice")
{code}
Although, when I try to access content of the war app via URL, I get only {{404 Not
found}} HTTP response. Also I cannot see any deployment content when browsing via CLI:
{code}
/deployment=bob/subsystem=undertow/...
{code}
Even when I raise logging level to DEBUG, I can see no suspicious messages that deployed
app has not been completely deployed.
If such suffix is required, we need to inform user about it. We need to update
description text for '\-\-name' and '\-\-runtime-name' atributes of deploy
command in CLI (see {{deploy --help}}). Also when no such suffix is provided (and/or we
fail to distinguish type of deployment in a different way) we need to print error message
that deploy operation was not completely successful so customer is aware of it right-away.