]
Scott Marlow commented on WFLY-10520:
-------------------------------------
[~gbadner] I fetched your changes locally and see the results that you mention. I did ask
a question on the pr.
Regarding moving the handling of setFirstResult( -1 ), to the migration guide, if
#setHibernateFirstResult cannot handle the negative value, we should definitely document
that negative values should not be passed to setFirstResult anymore.
Add Hibernate ORM 5.3 compatibility transformer
-----------------------------------------------
Key: WFLY-10520
URL:
https://issues.jboss.org/browse/WFLY-10520
Project: WildFly
Issue Type: Task
Components: JPA / Hibernate
Reporter: Gail Badner
Assignee: Scott Marlow
Fix For: 14.0.0.CR1
A compatibility transformer needs to be added to address Hibernate ORM 5.3 API methods
that are no longer compatible with 5.1.
From
https://docs.google.com/document/d/1cAVBdeQXQfpTwH0f_GKSahh_gRd7bKI6kII-w...
# Change call to org.hibernate.BasicQueryContract.getFlushMode() to instead call
BasicQueryContract.getHibernateFlushMode().
# Change call to org.hibernate.Session.getFlushMode, to instead call
Session.getHibernateFlushMode()
# Modify calls to org.hibernate.Query.getFirstResult() to convert returned int, to
Integer result.
# Modify calls to org.hibernate.Query.getMaxResults() to convert returned int, to Integer
result, if returned int value is <= 0, null should be used, if Integer.MAX_VALUE is,
the transformer should replace with null reference.
# App References to Enum org.hibernate.FlushMode.NEVER (0) should be transformed to
reference FlushMode.MANUAL (0) instead.
# For call to org.hibernate.Query.setMaxResults(int), instead call
org.hibernate.Query.setHibernateMaxResults(int) which will be added soon to ORM 5.3.