[jboss-jira] [JBoss JIRA] Commented: (JBAS-7224) Main.ServerConfigUtil.fixRemoteAddressProperty() ignores defaultValue
[
https://jira.jboss.org/jira/browse/JBAS-7224?page=com.atlassian.jira.plug...
]
Andrew Lee Rubinger commented on JBAS-7224:
-------------------------------------------
Against trunk:
[alr@localhost trunk]$ grep -R 'fixRemoteAddressProperty' .
Binary file ./main/target/classes/org/jboss/Main$ServerConfigUtil.class matches
Binary file ./main/target/classes/org/jboss/Main.class matches
./main/src/main/org/jboss/Main.java:
ServerConfigUtil.fixRemoteAddressProperty("java.rmi.server.hostname",
defaultAddress);
./main/src/main/org/jboss/Main.java:
ServerConfigUtil.fixRemoteAddressProperty("jgroups.bind_addr", defaultAddress);
./main/src/main/org/jboss/Main.java:
ServerConfigUtil.fixRemoteAddressProperty("bind.address", null);
./main/src/main/org/jboss/Main.java: public static void
fixRemoteAddressProperty(String systemPropertyName,
Main.ServerConfigUtil.fixRemoteAddressProperty() ignores
defaultValue
---------------------------------------------------------------------
Key: JBAS-7224
URL: https://jira.jboss.org/jira/browse/JBAS-7224
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: System service
Reporter: Dimitris Andreadis
Assignee: Andrew Lee Rubinger
Fix For: JBossAS-5.2.0.Beta1
I was looking why the server didn't not boot cleanly after the change in the parent
issue and it turns out it triggers a bug in
Main.ServerConfigUtil.fixRemoteAddressProperty.
public static void fixRemoteAddressProperty(String systemPropertyName,
String defaultValue)
{
String old = System.getProperty(systemPropertyName);
if (old == null)
{
if (defaultValue != null)
{
String fixed = fixRemoteAddress(old); <<< HERE should be
'defaultValue' instead
System.setProperty(systemPropertyName, fixed);
}
}
else
{
String fixed = fixRemoteAddress(old);
System.setProperty(systemPropertyName, fixed);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira