[jboss-jira] [JBoss JIRA] Closed: (JBRULES-1653) NPE when updating an existing RuleBase with new rules

NPE when updating an existing RuleBase with new rules ----------------------------------------------------- Key: JBRULES-1653 URL: http://jira.jboss.com/jira/browse/JBRULES-1653 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: Drl Parser/Builder Affects Versions: 5.0.0-M1 Reporter: Roel Adriaensens Assigned To: Mark Proctor Attachments: test.zip Steps to reproduce: - create RuleBase, create Reader for .drl file, create Package with PackageBuilder and add it to the ruleBase - now get the Package from the RuleBase, create a PackageBuilder with it, add extra rules to it from another .drl file (rules that didn't exist before), create the package and add it again to the RuleBase. This results in a NPE being thrown: java.lang.NullPointerException at org.drools.reteoo.ReteooBuilder.removeRule(ReteooBuilder.java:240) at org.drools.reteoo.ReteooRuleBase.removeRule(ReteooRuleBase.java:365) at org.drools.common.AbstractRuleBase.removeRule(AbstractRuleBase.java:704) at org.drools.common.AbstractRuleBase.mergePackage(AbstractRuleBase.java:552) at org.drools.common.AbstractRuleBase.addPackage(AbstractRuleBase.java:458) at org.drools.reteoo.ReteooRuleBase.addPackage(ReteooRuleBase.java:374) at com.agfa.hap.drools.UpdateRulesTest.testUpdateRules(UpdateRulesTest.java:32) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.internal.runners.TestMethodRunner.executeMethodBody(TestMethodRunner.java:99) at org.junit.internal.runners.TestMethodRunner.runUnprotected(TestMethodRunner.java:81) at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34) at org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75) at org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45) at org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:71) at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:35) at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42) at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34) at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:38) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196) Reason is that it tries to remove a rule from the RuleBase that does not exist in it.