[jboss-jira] [JBoss JIRA] Closed: (JBREM-822) Avoid deadlock when Connector shuts down while callback client invoker is in handleConnect()

Avoid deadlock when Connector shuts down while callback client invoker is in handleConnect() -------------------------------------------------------------------------------------------- Key: JBREM-822 URL: http://jira.jboss.com/jira/browse/JBREM-822 Project: JBoss Remoting Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.2.GA_CP01, 2.2.2.SP2 Reporter: Ron Sigal Assigned To: Ron Sigal Fix For: 2.4.0.Beta1 (Pinto) Attachments: connect_disconnect_deadlock_thread_dump Clebert Suconic has experienced a deadlock while shutting down the Application Server. The thread dump shows that the AS has called Connector.stop(), which leads to a call to the synchronized method org.jboss.remoting.MicroRemoteClientInvoker.disconnect() on the callback org.jboss.remoting.transport.bisocket.BisocketClientInvoker. However, all this happens at the same time that a callback handler is being installed, which leads to a call to the synchronized method MicroRemoteClientInvoker.connect() on *the same* callback BisocketClientInvoker. The BisocketClientInvoker is in BisocketClientInvoker.handleConnect(), where it is waiting (with, in the case of JBossMessaging, a timeout of 0) to get a control socket. As a result, MicroRemoteClientInvoker.disconnect() is blocked and cannot execute. This situation needs careful study. Do MicroRemoteClientInvoker.connect() and MicroRemoteClientInvoker.disconnect() need to be fully synchronized?