[jboss-jira] [JBoss JIRA] Closed: (JBCACHE-1053) RmiCacheServer and TcpCacheServer try to create an mbean proxy to a CacheImpl

RmiCacheServer and TcpCacheServer try to create an mbean proxy to a CacheImpl ----------------------------------------------------------------------------- Key: JBCACHE-1053 URL: http://jira.jboss.com/jira/browse/JBCACHE-1053 Project: JBoss Cache Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 2.0.0.CR1 Reporter: Brian Stansberry Assigned To: Brian Stansberry Fix For: 2.0.0.CR2 RmiCacheServer.start() has this: MBeanServer server = JmxUtil.getMBeanServer(); if (cacheName != null && server != null) { cache = (CacheImpl) MBeanServerInvocationHandler.newProxyInstance(server, cacheName, CacheImpl.class, false); } There won't be anything registered in JMX that you can proxy with the CacheImpl API. This could work: MBeanServer server = JmxUtil.getMBeanServer(); if (cacheName != null && server != null) { CacheJmxWrapperMBean wrapper = (CacheJmxWrapperMBean ) MBeanServerInvocationHandler.newProxyInstance(server, cacheName, CacheJmxWrapperMBean.class, false); cache = (CacheImpl) wrapper.getCache(); } In this case, cache is no longer a JMX proxy though, it's a ref to the underlying cache. Probably better is just to get rid of this lookup and require injection of the CacheImpl or the CacheJmxWrapper. Also, it would be nice if RemoteTreeCacheImpl could delegate to Cache instead of CacheImpl. Then there's no need to cast the wrapper.getCache() call and it's simpler to do dependency injection.