[jboss-jira] [JBoss JIRA] (WFCORE-3905) Improve SuspendController code

Improve SuspendController code ------------------------------ Key: WFCORE-3905 URL: https://issues.jboss.org/browse/WFCORE-3905 Project: WildFly Core Issue Type: Bug Components: Management Reporter: Jeff Mesnil Assignee: Yeray Borges Priority: Minor From Brians's comment at https://github.com/wildfly/wildfly-core/pull/3336#pullrequestreview-12543...: bq. Reviewing this I see a few issues in SuspendController. 1) The Timer allocated at L98 is pointless unless timeoutMillis > 0. 2) The timeout() method can be private (same with activityPaused()). 3) The logging at L74-L78 is incorrect if timeoutMillis == 0. The "suspendingServerWithNoTimeout" message is not correct in that case as 'no timeout' doesn't mean '0 ms'.