[jboss-jira] [JBoss JIRA] Updated: (JBCACHE-541) Create one true Node class; that's lean and mean and stuff

[ http://jira.jboss.com/jira/browse/JBCACHE-541?page=all ] Manik Surtani updated JBCACHE-541: ---------------------------------- Fix Version/s: 2.0.0.ALPHA2 Description: There are TreeNode, AbstractNode, DataNode and Node as basically Node types. I'm thinking as a simplification in design, that a single Node.java class that's concrete and has a fairly comprehensive but non-bloated method set. This will save on memory and reduce confusion. Also, having interfaces for data classes is fairly difficult, as you end up having so many data accessor methods that it is hard to maintain. The end result would be something like: public class Node { private Fqn fqn; // name is Fqn.getLast() private Map attributes; private Map children; private Lock lock; } Note: No parent, no reference to TreeCache (clients can supply it if they want, no need for every node to have a reference), external locking is done on the Lock, internal locking is done on "this". For all the locking that needs done, create a NodeLock utility class that has these methods, including ten versions of printLocks. :-) I'll create a list of tasks, some possibly now without breaking compatibility, some for later (like post 2.0?) was: There are TreeNode, AbstractNode, DataNode and Node as basically Node types. I'm thinking as a simplification in design, that a single Node.java class that's concrete and has a fairly comprehensive but non-bloated method set. This will save on memory and reduce confusion. Also, having interfaces for data classes is fairly difficult, as you end up having so many data accessor methods that it is hard to maintain. The end result would be something like: public class Node { private Fqn fqn; // name is Fqn.getLast() private Map attributes; private Map children; private Lock lock; } Note: No parent, no reference to TreeCache (clients can supply it if they want, no need for every node to have a reference), external locking is done on the Lock, internal locking is done on "this". For all the locking that needs done, create a NodeLock utility class that has these methods, including ten versions of printLocks. :-) I'll create a list of tasks, some possibly now without breaking compatibility, some for later (like post 2.0?) All a part of the Node/Cache object model refactoring -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira