[jboss-jira] [JBoss JIRA] Reopened: (JBAS-2225) FCI.getTargets() should be Immutable
[ http://jira.jboss.com/jira/browse/JBAS-2225?page=all ]
Brian Stansberry reopened JBAS-2225:
------------------------------------
Serializing the new ImmutableArrayList in a proxy will break clients that don't have
that class, so all the proxy writeObject/External methods need to serialize a clone.
Also, ImmutableArrayList needs to use delegation, not just subclassing. If it's a
subclass, the internal array gets copied as part of the c'tor; if we're going to
do that it makes as much sense to just return a defensive copy of the original ArrayList
and not create a separate class.
FCI.getTargets() should be Immutable
------------------------------------
Key: JBAS-2225
URL: http://jira.jboss.com/jira/browse/JBAS-2225
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: Clustering
Affects Versions: JBossAS-4.0.3RC2
Reporter: Adrian Brock
Assigned To: Brian Stansberry
Fix For: JBossAS-4.0.5.CR1
The targets returned from the FamilyClusterInfoImpl.getTargets() should not be modified,
otherwise you can cause ConcurrentModificationException.
To better trap people introducing errors in this area, make a subclass of ArrayList
called ImmutableArrayList and return an implementation of this class from getTargets.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira