[jboss-jira] [JBoss JIRA] (HAWKULARQE-199) CFME Tests - Make Midddleware Provider WidgetasticTaggable

CFME Tests - Make Midddleware Provider WidgetasticTaggable ---------------------------------------------------------- Key: HAWKULARQE-199 URL: https://issues.jboss.org/browse/HAWKULARQE-199 Project: Hawkular QE Issue Type: Task Reporter: Hayk Hovsepyan Assignee: Hayk Hovsepyan <gshefer> psav, BaseProvider is still Taggable and not yet WidgetasticTaggable, should I replace it in BaseProvider or just inherit this in ContainersProvider? <cfme_bot> PR: #5703 [WIPTEST] Widgetastic conversions - downstream-59z - failure <psav> I think for now yes, unless izapolsk can provide better guidance <psav> once we see it is WTtaggable on all of them <psav> we can convert <izapolsk> gshefer, sure thing, please update BaseProvider as well <izapolsk> gshefer++ <cfme_bot> gshefer == 23 <psav> ahh ok <psav> izapolsk: it's ready for it? <cfme_bot> PR: #5432 [WIPTEST] Revert snapshot tests redone - downstream-59z - failure <gshefer> are you sure, couldn't this effects others which didn't yet implement things like navmazing objects for tagging? <izapolsk> psav, gshefer, checking * kkulkarn (~kkulkarn(a)ovpn-123-9.rdu2.redhat.com) has joined #cfme-qe <psav> OK <psav> wow just think <psav> we _could_ implement the EditTags on the WTTaggable class <psav> as long as it's the same button name for all providers <psav> unless we do this alreayd <izapolsk> checking <psav> :D <vparekh> hey can someone please help me debug this, not getting why it is yelling <vparekh> http://pastebin.test.redhat.com/527476 <psav> looking <izapolsk> cloudinfra prov is alraedy WidgetasticTaggable <psav> vparekh: did you decorate the Tenant object? <psav> is this master? <psav> if not <psav> I need link to code <vparekh> giving code, just a min <psav> excellent <izapolsk> middleware provider looks not updated <psav> hhovsepy_afk: ^^? <psav> ahhh <psav> afk <psav> #sadpanda <psav> izapolsk: how much effort to fix that yup you think? <izapolsk> fix - 1h + testing - 2-3h <psav> hmmm <psav> I wonder if raoul could squeeze that in <izapolsk> I think ~2 h <psav> it would be another big win <izapolsk> yup <psav> would that remove the Taggable class completely <izapolsk> let me check <psav> or just in providers <psav> nah <psav> I can check <izapolsk> 18 usages <izapolsk> most in containter <izapolsk> containters <vparekh> psav, its in https://github.com/ManageIQ/integration_tests/pull/5492 files <psav> looks like containers yeh <psav> and middleware <psav> thta's it <psav> 18 usages <izapolsk> 11 - containers , 6 - midlleware <psav> 1 in common <psav> jejeje <psav> vparekh: looking at it <juwatts> the ones in containers should be going away soon with gshefer's conversion * kkulkarn-wfh has quit (Ping timeout: 600 seconds) <kkulkarn> hello, looking for 2nd level review on https://github.com/ManageIQ/integration_tests/pull/5655 <vparekh> this time, 'The show' had cfme-qe covered :D * sshveta_afk has quit (Ping timeout: 600 seconds) <psav> vparekh: because it's .parent <psav> not .collection <vparekh> ah but where <vparekh> psav, <vparekh> traceback doesn't have it * dmisharo has quit (Quit: Konversation terminated!) * kkulkarn is now known as kkulkarn-wfh <psav> what do you mean? <gshefer> izapolsk, psav, is this make sense that Details view has entities attr? - https://github.com/ManageIQ/integration_tests/blob/master/cfme/common/__i... <psav> where's the traceback? <mpusater> All, have we noticed the IPV4 problem on certain rhv hosts more than others? <psav> lcouz|teambuilding: ^^? <cfme_bot> PR: #5432 [WIPTEST] Revert snapshot tests redone - downstream-57z - failure <vparekh> psav, http://pastebin.test.redhat.com/527476 <gshefer> then it'll require me to do ugly workarounds <izapolsk> ? <psav> I'll find it <psav> line 1459 <psav> prerequisite = NavigateToAttribute('collection', 'All') <izapolsk> gshefer, someone called view with SummaryTables - entities. What exactly is not ok ? <psav> that should be changed to parent <psav> not collection * raoul|afk is now known as raoul <vparekh> ah <vparekh> changing <vparekh> psav++ <cfme_bot> psav == 524 <gshefer> izapolsk, in our object the summary tables are not under entities <gshefer> izapolsk, inconsistency <psav> vparekh: just one of the things to check when you are doing this kind of conversion <vparekh> I was actually finding if I missed something in code, and didn't see the navigation <vparekh> I need coffee, hehe <izapolsk> gshefer, can you fix this in containers ? * You are now known as hhovsepy <psav> ahhh hhovsepy^^? <psav> see the comments about Taggable vs WidgetasticTaggable <psav> any help yo ucan give us here would be appreciated in removing the old class <psav> containers and hawkular are the only two remaining places <psav> mornin mshriver <gshefer> izapolsk, and in provider it called contents <sbulage> hey mshriver o/ <gshefer> izapolsk, that crazy, in everyplace is different <psav> consistency FTL :( <mshriver> late mornin' psav :) feeling much better now <mpusater> ok a quick peak right now indicates that infra-rhv40-sprout{1,2,7} are not having issues and infra-rhv40-sprout{3,4,5,6) are. <mpusater> also vmware as I anticipated is not affected. <izapolsk> gshefer, I'll fix that on Monday, okay ? <cfme_bot> PR: #5670 [1LP][RFR] fix to upgrade testing - downstream-57z - failure <mshriver> mpusater I don't think I ever saw/tested the IPv4 issues on rhv{1,2,7} because those would fail with insufficient resources <gshefer> izapolsk, in which way? because I'm converting now all to WT, I have PR <izapolsk> use entities