[jboss-jira] [JBoss JIRA] (JGRP-1481) SEQUENCER can try forwarding to null coordinator

SEQUENCER can try forwarding to null coordinator ------------------------------------------------ Key: JGRP-1481 URL: https://issues.jboss.org/browse/JGRP-1481 Project: JGroups Issue Type: Bug Affects Versions: 3.0.10 Reporter: David Hotham Assignee: Bela Ban Fix For: 3.1 I've just seen a group go wrong and I think that the first sign of trouble was this line of trace: {noformat} 2012-06-15 08:55:54.690 [ForkJoinPool-1-worker-0] TRACE org.jgroups.protocols.SEQUENCER - [CFS-A-four]: forwarding CFS-A-four::1 to coord null {noformat} ... showing a member trying to forward to a null coordinator. This comes shortly after a new view was installed so SEQUENCER should have seen the VIEW_CHANGE. I think that the suspect code is in handleViewChange() {noformat} if(!coord_changed) { setCoord(new_coord); return; } {noformat} Surely the intention isn't to call setCoord only if the coodinator hasn't changed? I see that setCoord will get called in due course by the flusher. But perhaps it would be safer to do something like: {noformat} if(!coord_changed) { return; } stopFlusher(); setCoord(new_coord); startFlusher(new_coord); // needs to be done in the background, to prevent blocking if down() would block {noformat} ... and possibly the call to setCoord in flush() can then be removed?