[jboss-jira] [JBoss JIRA] Commented: (JBCACHE-1209) Restore existing Option to InvocationContext in TreeCache._gravitateData

Restore existing Option to InvocationContext in TreeCache._gravitateData ------------------------------------------------------------------------ Key: JBCACHE-1209 URL: http://jira.jboss.com/jira/browse/JBCACHE-1209 Project: JBoss Cache Issue Type: Sub-task Security Level: Public(Everyone can see) Affects Versions: 1.4.1.SP6 Reporter: Brian Stansberry Assigned To: Manik Surtani Fix For: 1.4.1.SP6 Attachments: TreeCache.patch The fix for JBCACHE-1192 has introduced a couple of problems that are manifesting themselves in numerous errors in the test suite: 1) _gravitateData changes the value of skipDataGravitation for the Option associated with the call, but then doesn't restore the correct value to *that* instance of Option. 2) _gravitateData calls get(Fqn), and that call actually results in the instance of Option that is associated with the thread being changed (see impl of get(Fqn). But, _gravitateData does not restore the original Option to the thread. Maybe not a problem if _gravitateData is called remotely, since there is no meaningful Option associated with the thread. But _gravitateData can now also be called by DataGravitationInterceptor.localBackupGet, and in that case there very well could be a meaningful Option associated with the thread, and it needs to be restored before _gravitateData returns. I'll attach a possible patch in a minute.