[jboss-jira] [JBoss JIRA] Commented: (JBCOMMON-27) Incorrect behaviour in TCLFilter

Incorrect behaviour in TCLFilter --------------------------------- Key: JBCOMMON-27 URL: http://jira.jboss.com/jira/browse/JBCOMMON-27 Project: JBoss Common Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.0.0.GA Reporter: Scott M Stark Assigned To: Scott M Stark Fix For: 1.2.1.GA, 1.0.5.GA, 2.2.1.GA Just one TCLFilter can be added to an appender, decide method return either ACCEPT or DENY. Should return NEUTRAL is some case. public int decide(LoggingEvent event) { int ok = Filter.DENY; if( acceptOnMatch == true ) { ok = Filter.DENY; if( isMatchingTCL() ){ ok = Filter.ACCEPT; } } else { ok = Filter.ACCEPT; // CHANGING THIS ROW TO ok = Filter.NEUTRAL; should do that you check the other filters to. if( isMatchingTCL() ) ok = Filter.DENY; } return ok; } Log4j.xml: <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender"> <layout class="org.apache.log4j.PatternLayout"> <param name="ConversionPattern" value="%d %-5p [%t] %c - %m%n"/> </layout> <filter class="org.jboss.logging.filter.TCLFilter"> <param name="AcceptOnMatch" value="false"/> <param name="DeployURL" value="jboss-common-client.jarpoyan"/> </filter> <filter class="org.jboss.logging.filter.TCLFilter"> <param name="AcceptOnMatch" value="false"/> <param name="DeployURL" value="dnsns.jarpoyan"/> </filter> </appender>