[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-1505) Parameters class may have a "protected" internal Map, for overriding
[ http://jira.jboss.com/jira/browse/JBPORTAL-1505?page=comments#action_1236... ]
Antoine Herzog commented on JBPORTAL-1505:
------------------------------------------
Sorry, I got confused in the classes.
Parameters are not used in the CommandFactory itself...
When updating my CommandFactory for 2.6, I got (again) that problem :
how to see what params reach to the portlet action or rendering ? (list of keys ?, values
?... no params ?.... )
So it is still usefull to be able to reach this internal map : to get the list of keys,
and view all the params it has in it.
JBossRenderRequest has one.
I saw a jira about a portlet interceptor, that would show the params that the portlet
receive....
Same for org.jboss.portal.common.util.Base64.PortletParametersStateString that contains a
private PortletParameters instance.
It could be usefull to access this PortletParameters, at least in a inherited class.
Without opening widely the API, my idea is :
- in custom CommandFactory, put a MySpecialDebugParametersClass inheriting from
Parameters (or PortletParametersStateString).
- in other classes, use MySpecialDebugParametersClass special debug features to get
what's going on etc...
So protected would be enough. Public would be the easiest but to much and not clean api.
(or with a special method, such as getInternalMap() ?).
Thanks,
Parameters class may have a "protected" internal Map, for
overriding
--------------------------------------------------------------------
Key: JBPORTAL-1505
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1505
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.6 CR3
Environment: JBP2.6 RC3
Reporter: Antoine Herzog
Assigned To: Julien Viet
Priority: Minor
Fix For: 2.8 Final, 2.6.1 Final
The class org.jboss.portlet.util.Parameters has a
private Map parameters;
put it with protected :
protected Map parameters;
so access it possible when overriding this class.
Example of needs :
- overriding the the Parameters class to provide access to the collection, etc...
- use of our own TotoParameters, inheriting from Parameters, to work it with
specific features
for debugging... log what is in it (the Parameters class provide nothing to get the
collection of key, the size() etc...)
and when overriding and modifying some CommandFactory and URLFactory
Turnaround : I use a ParametersHelper, to fill the Map of params, manipulate it, debug...
and just before to pass it to the portal (end of CommandFactory doMapping method), I
build a Parameters instance from it.
It is ok in this use case, but overriding the class would be much better.
Thanks
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira