[jboss-jira] [JBoss JIRA] Commented: (JBREM-895) MicroSocketClientInvoker.transport() must check for timeout after invocation attempt.

MicroSocketClientInvoker.transport() must check for timeout after invocation attempt. ------------------------------------------------------------------------------------- Key: JBREM-895 URL: http://jira.jboss.com/jira/browse/JBREM-895 Project: JBoss Remoting Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 2.2.2.SP4 Reporter: Ron Sigal Assigned To: Ron Sigal Fix For: 2.4.0.Beta1 (Pinto) Unit test org.jboss.test.remoting.callback.pull.CallbackPollerShutdownTestCase revealed a bug in org.jboss.remoting.transport.socket.MicroSocketClientInvoker.transport(). After the invocation attempt loop, there is a test to see if numberOfCallRetries has been exceeded. If so, the semaphore has already been released, and an exception is thrown. Another way the loop could end unsuccessfully is if a per invocation timeout has occurred. Currently, there is no test for this condition, so that semaphore.release() is called again, increasing the semaphore counter incorrectly.