[jboss-jira] [JBoss JIRA] Updated: (JBAS-6179) when an exploded WAR with a non-well-formed web.xml and a jboss-web.xml is copied into deploy/ while the app server is running, it cannot be deleted, because its jboss-web.xml is locked

when an exploded WAR with a non-well-formed web.xml and a jboss-web.xml is copied into deploy/ while the app server is running, it cannot be deleted, because its jboss-web.xml is locked ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Key: JBAS-6179 URL: https://jira.jboss.org/jira/browse/JBAS-6179 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: Web (Tomcat) service Affects Versions: JBossAS-4.2.3.GA Environment: Windows Reporter: Ian Springer Assignee: Remy Maucherat Attachments: invalid-webxml.war Note, the WAR must have a jboss-web.xml in WEB-INF and its web.xml must be a non-well-formed XML file (it's not enough for it to only be invalid). After the deploy fails, the jboss-web.xml is locked and so cannot be deleted without either stopping the app server or using a Windows utility such as Unlocker. Some code in the app server must be neglecting to close the file handle after opening jboss-web.xml. A WAR that can be used to reproduce the bug is attached. Here is the errors that are printed when the WAR is copied (in exploded form) into the deploy dir: 17:07:46,754 ERROR [XmlFileLoader] XmlFileLoader: File file:/C:/opt/jboss-4.2.3.GA/server/default/deploy/invalid-webxml- exploded.war//WEB-INF/web.xml process fatal error. Line: 16. Error message: The element type "dangling-element" must be terminated by the matching end-tag "</dangling-element>". 17:07:46,754 WARN [NestedThrowable] Duplicate throwable nesting of same base type: class org.jboss.deployment.Deploymen tException is assignable from: class org.jboss.deployment.DeploymentException 17:07:46,754 ERROR [MainDeployer] Could not initialise deployment: file:/C:/opt/jboss-4.2.3.GA/server/default/deploy/inv alid-webxml-exploded.war/ org.jboss.deployment.DeploymentException: Failed to parse WEB-INF/web.xml; - nested throwable: (org.jboss.deployment.Dep loymentException: Invalid XML: file=file:/C:/opt/jboss-4.2.3.GA/server/default/deploy/invalid-webxml-exploded.war//WEB-I NF/web.xml@3:16; - nested throwable: (org.xml.sax.SAXParseException: The element type "dangling-element" must be termina ted by the matching end-tag "</dangling-element>".)) at org.jboss.web.AbstractWebContainer.parseMetaData(AbstractWebContainer.java:755) at org.jboss.web.AbstractWebContainer.init(AbstractWebContainer.java:356) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:623) at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:155) at org.jboss.mx.server.Invocation.dispatch(Invocation.java:94) at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:133) at org.jboss.mx.server.Invocation.invoke(Invocation.java:88) at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:142) at org.jboss.mx.interceptor.DynamicInterceptor.invoke(DynamicInterceptor.java:97) at org.jboss.system.InterceptorServiceMBeanSupport.invokeNext(InterceptorServiceMBeanSupport.java:238) at org.jboss.deployment.SubDeployerInterceptorSupport.init(SubDeployerInterceptorSupport.java:119) at org.jboss.deployment.SubDeployerInterceptorSupport$XMBeanInterceptor.init(SubDeployerInterceptorSupport.java: 172) at org.jboss.deployment.SubDeployerInterceptor.invoke(SubDeployerInterceptor.java:87) at org.jboss.mx.server.Invocation.invoke(Invocation.java:88) at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264) at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:659) at org.jboss.mx.util.MBeanProxyExt.invoke(MBeanProxyExt.java:210) at $Proxy45.init(Unknown Source) at org.jboss.deployment.MainDeployer.init(MainDeployer.java:872) at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:809) at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:782) at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:623) at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:155) at org.jboss.mx.server.Invocation.dispatch(Invocation.java:94) at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:133) at org.jboss.mx.server.Invocation.invoke(Invocation.java:88) at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:142) at org.jboss.mx.server.Invocation.invoke(Invocation.java:88) at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264) at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:659) at org.jboss.mx.util.MBeanProxyExt.invoke(MBeanProxyExt.java:210) at $Proxy9.deploy(Unknown Source) at org.jboss.deployment.scanner.URLDeploymentScanner.deploy(URLDeploymentScanner.java:421) at org.jboss.deployment.scanner.URLDeploymentScanner.scan(URLDeploymentScanner.java:634) at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.doScan(AbstractDeploymentScanner.java:26 3) at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.loop(AbstractDeploymentScanner.java:274) at org.jboss.deployment.scanner.AbstractDeploymentScanner$ScannerThread.run(AbstractDeploymentScanner.java:225) Caused by: org.jboss.deployment.DeploymentException: Invalid XML: file=file:/C:/opt/jboss-4.2.3.GA/server/default/deploy /invalid-webxml-exploded.war//WEB-INF/web.xml@3:16; - nested throwable: (org.xml.sax.SAXParseException: The element type "dangling-element" must be terminated by the matching end-tag "</dangling-element>".) at org.jboss.metadata.XmlFileLoader.getDocument(XmlFileLoader.java:342) at org.jboss.metadata.XmlFileLoader.getDocument(XmlFileLoader.java:272) at org.jboss.web.AbstractWebContainer.parseMetaData(AbstractWebContainer.java:748) ... 41 more Caused by: org.xml.sax.SAXParseException: The element type "dangling-element" must be terminated by the matching end-tag "</dangling-element>". at org.apache.xerces.parsers.DOMParser.parse(Unknown Source) at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source) at org.jboss.metadata.XmlFileLoader.getDocument(XmlFileLoader.java:328) ... 43 more