[jboss-jira] [JBoss JIRA] Commented: (JBAS-4292) Legacy MainDeployer.deploy use of checkIncomplete causes leaks/test failures
[ http://jira.jboss.com/jira/browse/JBAS-4292?page=comments#action_12367505 ]
Brian Stansberry commented on JBAS-4292:
----------------------------------------
Simply changing the order of operations in MainDeployer.deploy(URL) fixes my problem
above.
From:
// TODO: JBAS-4292
delegate.checkComplete();
contextMap.put(url, deploymentName);
To:
contextMap.put(url, deploymentName);
// TODO: JBAS-4292
delegate.checkComplete();
Doing that seems a bit dodgy, but it works. If an exception causes a bypass of the
contextMap.put call, you can never undeploy.
Legacy MainDeployer.deploy use of checkIncomplete causes leaks/test
failures
----------------------------------------------------------------------------
Key: JBAS-4292
URL: http://jira.jboss.com/jira/browse/JBAS-4292
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Suite, Deployment services
Affects Versions: JBossAS-5.0.0.Beta2
Reporter: Scott M Stark
Assigned To: Dimitris Andreadis
Fix For: JBossAS-5.0.0.Beta3
If one adds a checkIncomplete call to validate a deployment in the legacy
org.jboss.deployment.MainDeployer used by the testsuite deploy calls, there are additional
failures and memory leaks that prevent the run from completing. It appears that tests are
not cleaning up after failed deployments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira