[jboss-jira] [JBoss JIRA] Resolved: (JBAS-6215) when creating a new Datasource via managementView.applyTemplate(), if the "metadata" CompositeValue property contains no items or a null-valued item, the ds.xml file is written with an empty "metadata" element, which causes the deployer to complain

when creating a new Datasource via managementView.applyTemplate(), if the "metadata" CompositeValue property contains no items or a null-valued item, the ds.xml file is written with an empty "metadata" element, which causes the deployer to complain -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Key: JBAS-6215 URL: https://jira.jboss.org/jira/browse/JBAS-6215 Project: JBoss Application Server Issue Type: Sub-task Security Level: Public(Everyone can see) Components: ProfileService Reporter: Ian Springer Assignee: Scott M Stark Fix For: JBossAS-5.0.0.GA Here's what the "metavalue" property looks like in the template that is passed to applyTemplate(): name=metadata, mappedName=null, required=false, value=CompositeValueSupport: metaType=[MutableCompositeMetaType{org.jb oss.resource.metadata.mcf.DBMSMetaData items=[name=typeMapping type=java.lang.String]}] items=[typeMapping=null] Note, the "typeMapping" item has a null value. The ds.xml file that is written contains the following line: <metadata/> (instead it should not contain a "metadata" element at all) This causes the following error from the deployer: 14:50:19,812 INFO [SerializableDeploymentRepository] Adding application: vfsfile:/C:/opt/jboss-5.0.0.GA/server/default/ deploy/OracleDS22-ds.xml / AbstractVFSDeployment(OracleDS22-ds.xml) 14:50:19,828 ERROR [AbstractKernelController] Error installing to Real: name=vfsfile:/C:/opt/jboss-5.0.0.GA/server/defau lt/deploy/OracleDS22-ds.xml state=PreReal mode=Manual requiredState=Real org.jboss.deployers.spi.DeploymentException: Error during deploy: vfsfile:/C:/opt/jboss-5.0.0.GA/server/default/deploy/O racleDS22-ds.xml at org.jboss.deployers.spi.DeploymentException.rethrowAsDeploymentException(DeploymentException.java:49) at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:177) at org.jboss.deployers.plugins.deployers.DeployersImpl.doDeploy(DeployersImpl.java:1439) at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1157) at org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:1098) at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348) at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1598) at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:934) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1062) at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:984) at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:822) at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:553) at org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:781) at org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:541) at org.jboss.profileservice.management.ManagementViewImpl.applyTemplate(ManagementViewImpl.java:680) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:623) at org.jboss.aop.Dispatcher.invoke(Dispatcher.java:121) at org.jboss.aspects.remoting.AOPRemotingInvocationHandler.invoke(AOPRemotingInvocationHandler.java:82) at org.jboss.profileservice.remoting.ProfileServiceInvocationHandler.invoke(ProfileServiceInvocationHandler.java :67) at org.jboss.remoting.ServerInvoker.invoke(ServerInvoker.java:908) at org.jboss.remoting.transport.local.LocalClientInvoker.invoke(LocalClientInvoker.java:106) at org.jboss.remoting.Client.invoke(Client.java:1708) at org.jboss.remoting.Client.invoke(Client.java:612) at org.jboss.aspects.remoting.InvokeRemoteInterceptor.invoke(InvokeRemoteInterceptor.java:60) at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:102) at org.jboss.aspects.remoting.MergeMetaDataInterceptor.invoke(MergeMetaDataInterceptor.java:74) at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:102) at org.jboss.aspects.security.SecurityClientInterceptor.invoke(SecurityClientInterceptor.java:65) at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:102) at AOPProxy$1.applyTemplate(AOPProxy$1.java) at org.rhq.plugins.jbossas5.ProfileJBossServerComponent.createConfigurationBasedResource(ProfileJBossServerCompo nent.java:218) at org.rhq.plugins.jbossas5.ProfileJBossServerComponent.createResource(ProfileJBossServerComponent.java:132) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:623) at org.rhq.core.pc.inventory.ResourceContainer$ComponentInvocationThread.call(ResourceContainer.java:450) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:713) Caused by: java.lang.IllegalArgumentException: Null text at org.jboss.system.metadata.ServiceTextValueMetaData.setText(ServiceTextValueMetaData.java:94) at org.jboss.system.metadata.ServiceTextValueMetaData.<init>(ServiceTextValueMetaData.java:73) at org.jboss.resource.deployers.builder.AbstractBuilder.buildSimpleAttribute(AbstractBuilder.java:91) at org.jboss.resource.deployers.builder.MetaDataTypeMappingBuilder.buildAttributes(MetaDataTypeMappingBuilder.ja va:70) at org.jboss.resource.deployers.builder.AbstractBuilder.build(AbstractBuilder.java:66) at org.jboss.resource.deployers.builder.MetaDataTypeMappingBuilder.build(MetaDataTypeMappingBuilder.java:83) at org.jboss.resource.deployers.ManagedConnectionFactoryDeployer.deploy(ManagedConnectionFactoryDeployer.java:17 7) at org.jboss.resource.deployers.ManagedConnectionFactoryDeployer.deploy(ManagedConnectionFactoryDeployer.java:52 ) at org.jboss.deployers.spi.deployer.helpers.AbstractSimpleRealDeployer.internalDeploy(AbstractSimpleRealDeployer .java:62) at org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50) at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:171) ... 43 more 14:50:19,906 ERROR [ProfileJBossServerComponent] Unable to apply template [LocalTxDataSourceTemplate]. org.jboss.deployers.client.spi.IncompleteDeploymentException: Summary of incomplete deployments (SEE PREVIOUS ERRORS FOR DETAILS): *** CONTEXTS IN ERROR: Name -> Error vfsfile:/C:/opt/jboss-5.0.0.GA/server/default/deploy/OracleDS22-ds.xml -> java.lang.IllegalArgumentException: Null text