[jboss-jira] [JBoss JIRA] (LOGMGR-191) Amend NullPointerException in regex filters

Amend NullPointerException in regex filters ------------------------------------------- Key: LOGMGR-191 URL: https://issues.jboss.org/browse/LOGMGR-191 Project: JBoss Log Manager Issue Type: Bug Components: core Affects Versions: 2.1.0.Alpha5 Reporter: Toshiya Kobayashi Assignee: Toshiya Kobayashi Labels: support When log message is null, RegexFilter.isLoggable() throws NullPointerException. https://github.com/jboss-logging/jboss-logmanager/blob/master/src/main/ja... It often results in unexpected outcomes. For example, assuming you have a filter-spec with "not(match(xxx))" to suppress some messages in your logger configuration: {code:xml} <subsystem xmlns="urn:jboss:domain:logging:3.0"> <console-handler name="CONSOLE"> <level name="INFO"/> <filter-spec value="not(match(&quot;SOME_MESSAGE&quot;))"/> <formatter> <named-formatter name="COLOR-PATTERN"/> </formatter> </console-handler> {code} and an application has a code like this: {code:java} try { ... } catch (Exception e) { logger.error(e.getMessage(), e); } {code} "e.getMessage()" could be null. But you want to log the stacktrace 'e' anyway. In this case, NullPointerException is thrown from RegexFilter and reaches to LoggerNode and disappears. ConsoleHandler cannot publish the log at all. https://github.com/jboss-logging/jboss-logmanager/blob/master/src/main/ja... I think 'null' message should simply return 'false' in RegexFilter.isLoggable().